revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-17 18:21:11 +01:00
Code Issues Releases Wiki Activity

Fix FileTreeView sprites

Browse source 
Summary: D4453 and D4427 sailed past one another, like ships in the night.

Test Plan: Verified Differential hover and selected states.

Reviewers: asherkin, chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D4577
This commit is contained in:
epriestley 2013-01-22 09:09:57 -08:00
parent 849dc086e4
commit 809f380aa6
4 changed files with 13 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
resources/sprite/manifest/gradient.json
View file

@ -53,7 +53,7 @@
}, },
"gradient-menu-hover" : { "gradient-menu-hover" : {
"name" : "gradient-menu-hover", "name" : "gradient-menu-hover",
"rule" : ".gradient-menu-hover, .device-desktop .phabricator-side-menu a.phabricator-menu-item-type-link:hover", "rule" : ".gradient-menu-hover, .device-desktop .phabricator-side-menu a.phabricator-menu-item-type-link:hover, .phabricator-filetree a.phabricator-filetree-item:hover",
"hash" : "856380207ac8c5cb6770d44dceb245a8" "hash" : "856380207ac8c5cb6770d44dceb245a8"
}, },
"gradient-menu-label" : { "gradient-menu-label" : {
@ -63,13 +63,13 @@
}, },
"gradient-menu-selected" : { "gradient-menu-selected" : {
"name" : "gradient-menu-selected", "name" : "gradient-menu-selected",
"rule" : ".gradient-menu-selected, .phabricator-side-menu .phabricator-menu-item-selected, .device-desktop .phabricator-side-menu a.phabricator-menu-item-selected:hover", "rule" : ".gradient-menu-selected, .phabricator-side-menu .phabricator-menu-item-selected, .device-desktop .phabricator-side-menu a.phabricator-menu-item-selected:hover, .phabricator-nav-local a.phabricator-active-nav-focus",
"hash" : "815bafb94e11c23e1a419ea85dcae113" "hash" : "815bafb94e11c23e1a419ea85dcae113"
} }
}, },
"scales" : [ "scales" : [
1 1
], ],
"header" : "\/**\n * @provides sprite-gradient-css\n * @generated\n *\/\n\n.sprite-gradient, button, a.button, a.button:visited, input.inputsubmit, .phabricator-dark-menu .phabricator-menu-item-type-label, .phabricator-side-menu .phabricator-menu-item-type-label, .device-desktop .phabricator-side-menu a.phabricator-menu-item-type-link:hover, .phabricator-side-menu .phabricator-menu-item-selected, .device-desktop .phabricator-side-menu a.phabricator-menu-item-selected:hover {\n background-image: url(\/rsrc\/image\/sprite-gradient.png);\n background-repeat: repeat-x;\n}\n\n\n", "header" : "\/**\n * @provides sprite-gradient-css\n * @generated\n *\/\n\n.sprite-gradient, button, a.button, a.button:visited, input.inputsubmit, .phabricator-dark-menu .phabricator-menu-item-type-label, .phabricator-side-menu .phabricator-menu-item-type-label, .device-desktop .phabricator-side-menu a.phabricator-menu-item-type-link:hover, .phabricator-side-menu .phabricator-menu-item-selected, .device-desktop .phabricator-side-menu a.phabricator-menu-item-selected:hover, .phabricator-filetree a.phabricator-filetree-item:hover, .phabricator-filetree a.phabricator-active-nav-focus {\n background-image: url(\/rsrc\/image\/sprite-gradient.png);\n background-repeat: repeat-x;\n}\n\n\n",
"type" : "repeat-x" "type" : "repeat-x"
} }

10
src/infrastructure/celerity/CeleritySpriteGenerator.php
View file

@ -202,11 +202,13 @@ final class CeleritySpriteGenerator {
', .phabricator-side-menu .phabricator-menu-item-type-label', ', .phabricator-side-menu .phabricator-menu-item-type-label',
'menu-hover' => 'menu-hover' =>
', .device-desktop .phabricator-side-menu '. ', .device-desktop .phabricator-side-menu '.
'a.phabricator-menu-item-type-link:hover', 'a.phabricator-menu-item-type-link:hover, '.
'.phabricator-filetree a.phabricator-filetree-item:hover',
'menu-selected' => 'menu-selected' =>
', .phabricator-side-menu .phabricator-menu-item-selected, '. ', .phabricator-side-menu .phabricator-menu-item-selected, '.
'.device-desktop .phabricator-side-menu '. '.device-desktop .phabricator-side-menu '.
'a.phabricator-menu-item-selected:hover', 'a.phabricator-menu-item-selected:hover, '.
'.phabricator-nav-local a.phabricator-active-nav-focus',
); );
$sprites = array(); $sprites = array();
@ -233,7 +235,9 @@ final class CeleritySpriteGenerator {
'a.phabricator-menu-item-type-link:hover, '. 'a.phabricator-menu-item-type-link:hover, '.
'.phabricator-side-menu .phabricator-menu-item-selected, '. '.phabricator-side-menu .phabricator-menu-item-selected, '.
'.device-desktop .phabricator-side-menu '. '.device-desktop .phabricator-side-menu '.
'a.phabricator-menu-item-selected:hover '); 'a.phabricator-menu-item-selected:hover, '.
'.phabricator-filetree a.phabricator-filetree-item:hover, '.
'.phabricator-filetree a.phabricator-active-nav-focus');
foreach ($sprites as $sprite) { foreach ($sprites as $sprite) {
$sheet->addSprite($sprite); $sheet->addSprite($sprite);
} }

8
webroot/rsrc/css/layout/phabricator-filetree-view.css
View file

@ -45,8 +45,6 @@
} }
.phabricator-filetree a.phabricator-filetree-item:hover { .phabricator-filetree a.phabricator-filetree-item:hover {
background-image: url(/rsrc/image/menu_hover.png);
background-repeat: repeat-x;
text-decoration: none; text-decoration: none;
} }
@ -57,9 +55,3 @@
.phabricator-filetree-icon-dir { .phabricator-filetree-icon-dir {
background-image: url(/rsrc/image/icon/fatcow/folder.png); background-image: url(/rsrc/image/icon/fatcow/folder.png);
} }
.phabricator-nav-local
a.phabricator-active-nav-focus {
background-image: url(/rsrc/image/menu_selected.png);
background-repeat: repeat-x;
}

6
webroot/rsrc/css/sprite-gradient.css
View file

@ -3,7 +3,7 @@
* @generated * @generated
*/ */
.sprite-gradient, button, a.button, a.button:visited, input.inputsubmit, .phabricator-dark-menu .phabricator-menu-item-type-label, .phabricator-side-menu .phabricator-menu-item-type-label, .device-desktop .phabricator-side-menu a.phabricator-menu-item-type-link:hover, .phabricator-side-menu .phabricator-menu-item-selected, .device-desktop .phabricator-side-menu a.phabricator-menu-item-selected:hover { .sprite-gradient, button, a.button, a.button:visited, input.inputsubmit, .phabricator-dark-menu .phabricator-menu-item-type-label, .phabricator-side-menu .phabricator-menu-item-type-label, .device-desktop .phabricator-side-menu a.phabricator-menu-item-type-link:hover, .phabricator-side-menu .phabricator-menu-item-selected, .device-desktop .phabricator-side-menu a.phabricator-menu-item-selected:hover, .phabricator-filetree a.phabricator-filetree-item:hover, .phabricator-filetree a.phabricator-active-nav-focus {
background-image: url(/rsrc/image/sprite-gradient.png); background-image: url(/rsrc/image/sprite-gradient.png);
background-repeat: repeat-x; background-repeat: repeat-x;
} }
@ -51,7 +51,7 @@
background-position: 0px -240px; background-position: 0px -240px;
} }
.gradient-menu-hover, .device-desktop .phabricator-side-menu a.phabricator-menu-item-type-link:hover { .gradient-menu-hover, .device-desktop .phabricator-side-menu a.phabricator-menu-item-type-link:hover, .phabricator-filetree a.phabricator-filetree-item:hover {
background-position: 0px -267px; background-position: 0px -267px;
} }
@ -59,6 +59,6 @@
background-position: 0px 0px; background-position: 0px 0px;
} }
.gradient-menu-selected, .phabricator-side-menu .phabricator-menu-item-selected, .device-desktop .phabricator-side-menu a.phabricator-menu-item-selected:hover { .gradient-menu-selected, .phabricator-side-menu .phabricator-menu-item-selected, .device-desktop .phabricator-side-menu a.phabricator-menu-item-selected:hover, .phabricator-nav-local a.phabricator-active-nav-focus {
background-position: 0px -296px; background-position: 0px -296px;
} }