revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-08 22:01:03 +01:00
Code Issues Releases Wiki Activity

Stabilize Thread-Topic

Browse source 
Summary: NOTE: This can break current ongoing conversations.

Test Plan: Commented on a revision and checked the header in the e-mail.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T1340

Differential Revision: https://secure.phabricator.com/D2723
This commit is contained in:
vrana 2012-06-12 10:49:42 -07:00
parent 375c921bb0
commit 80de8c93c9
2 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/applications/differential/mail/DifferentialMail.php
View file

@ -96,7 +96,7 @@ abstract class DifferentialMail {
->setBody($body)
->setIsHTML($this->shouldMarkMailAsHTML())
->setParentMessageID($this->parentMessageID)
->addHeader('Thread-Topic', $this->getRevision()->getTitle());
->addHeader('Thread-Topic', $this->getThreadTopic());
$template->setAttachments($attachments);
@ -327,6 +327,11 @@ EOTEXT;
return "differential-rev-{$phid}-req";
}
protected function getThreadTopic() {
$phid = $this->getRevision()->getPHID();
return "Differential Revision {$phid}";
}
public function setComment($comment) {
$this->comment = $comment;
return $this;

2
src/applications/maniphest/editor/ManiphestTransactionEditor.php
View file

@ -278,7 +278,7 @@ final class ManiphestTransactionEditor {
->setVarySubjectPrefix("[{$action}]")
->setFrom($transaction->getAuthorPHID())
->setParentMessageID($this->parentMessageID)
->addHeader('Thread-Topic', 'Maniphest Task '.$task->getID())
->addHeader('Thread-Topic', 'Maniphest Task '.$task->getPHID())
->setThreadID($thread_id, $is_create)
->setRelatedPHID($task->getPHID())
->setIsBulk(true)