mirror of
https://we.phorge.it/source/phorge.git
synced 2025-01-24 05:28:18 +01:00
Stabilize Thread-Topic
Summary: NOTE: This can break current ongoing conversations. Test Plan: Commented on a revision and checked the header in the e-mail. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T1340 Differential Revision: https://secure.phabricator.com/D2723
This commit is contained in:
parent
375c921bb0
commit
80de8c93c9
2 changed files with 7 additions and 2 deletions
|
@ -96,7 +96,7 @@ abstract class DifferentialMail {
|
||||||
->setBody($body)
|
->setBody($body)
|
||||||
->setIsHTML($this->shouldMarkMailAsHTML())
|
->setIsHTML($this->shouldMarkMailAsHTML())
|
||||||
->setParentMessageID($this->parentMessageID)
|
->setParentMessageID($this->parentMessageID)
|
||||||
->addHeader('Thread-Topic', $this->getRevision()->getTitle());
|
->addHeader('Thread-Topic', $this->getThreadTopic());
|
||||||
|
|
||||||
$template->setAttachments($attachments);
|
$template->setAttachments($attachments);
|
||||||
|
|
||||||
|
@ -327,6 +327,11 @@ EOTEXT;
|
||||||
return "differential-rev-{$phid}-req";
|
return "differential-rev-{$phid}-req";
|
||||||
}
|
}
|
||||||
|
|
||||||
|
protected function getThreadTopic() {
|
||||||
|
$phid = $this->getRevision()->getPHID();
|
||||||
|
return "Differential Revision {$phid}";
|
||||||
|
}
|
||||||
|
|
||||||
public function setComment($comment) {
|
public function setComment($comment) {
|
||||||
$this->comment = $comment;
|
$this->comment = $comment;
|
||||||
return $this;
|
return $this;
|
||||||
|
|
|
@ -278,7 +278,7 @@ final class ManiphestTransactionEditor {
|
||||||
->setVarySubjectPrefix("[{$action}]")
|
->setVarySubjectPrefix("[{$action}]")
|
||||||
->setFrom($transaction->getAuthorPHID())
|
->setFrom($transaction->getAuthorPHID())
|
||||||
->setParentMessageID($this->parentMessageID)
|
->setParentMessageID($this->parentMessageID)
|
||||||
->addHeader('Thread-Topic', 'Maniphest Task '.$task->getID())
|
->addHeader('Thread-Topic', 'Maniphest Task '.$task->getPHID())
|
||||||
->setThreadID($thread_id, $is_create)
|
->setThreadID($thread_id, $is_create)
|
||||||
->setRelatedPHID($task->getPHID())
|
->setRelatedPHID($task->getPHID())
|
||||||
->setIsBulk(true)
|
->setIsBulk(true)
|
||||||
|
|
Loading…
Add table
Reference in a new issue