mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-22 23:02:42 +01:00
Update Create Diff page for new Edit UI
Summary: Create a diff page, new UI Test Plan: Create a diff from page Reviewers: epriestley Reviewed By: epriestley Spies: Korvin Differential Revision: https://secure.phabricator.com/D18529
This commit is contained in:
parent
20584a39d9
commit
818b90cf12
2 changed files with 4 additions and 8 deletions
|
@ -182,10 +182,10 @@ final class DifferentialDiffCreateController extends DifferentialController {
|
|||
->setValue($button));
|
||||
|
||||
$form_box = id(new PHUIObjectBoxView())
|
||||
->setHeaderText(pht('Diff'))
|
||||
->setHeaderText($title)
|
||||
->setValidationException($validation_exception)
|
||||
->setForm($form)
|
||||
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
|
||||
->setBackground(PHUIObjectBoxView::WHITE_CONFIG)
|
||||
->setFormErrors($errors);
|
||||
|
||||
$crumbs = $this->buildApplicationCrumbs();
|
||||
|
@ -197,15 +197,10 @@ final class DifferentialDiffCreateController extends DifferentialController {
|
|||
$crumbs->addTextCrumb($title);
|
||||
$crumbs->setBorder(true);
|
||||
|
||||
$header = id(new PHUIHeaderView())
|
||||
->setHeader($title)
|
||||
->setHeaderIcon($header_icon);
|
||||
|
||||
$view = id(new PHUITwoColumnView())
|
||||
->setHeader($header)
|
||||
->setFooter(array(
|
||||
$info_view,
|
||||
$form_box,
|
||||
$info_view,
|
||||
));
|
||||
|
||||
return $this->newPage()
|
||||
|
|
|
@ -59,6 +59,7 @@ final class PHUIInfoView extends AphrontTagView {
|
|||
} else {
|
||||
$icon = id(new PHUIIconView())
|
||||
->setIcon($icon);
|
||||
$this->icon = $icon;
|
||||
}
|
||||
|
||||
return $this;
|
||||
|
|
Loading…
Reference in a new issue