diff --git a/src/applications/almanac/editor/AlmanacDeviceEditor.php b/src/applications/almanac/editor/AlmanacDeviceEditor.php index 211788e441..82263e66c4 100644 --- a/src/applications/almanac/editor/AlmanacDeviceEditor.php +++ b/src/applications/almanac/editor/AlmanacDeviceEditor.php @@ -55,8 +55,6 @@ final class AlmanacDeviceEditor $object->setName($xaction->getNewValue()); return; case AlmanacDeviceTransaction::TYPE_INTERFACE: - case PhabricatorTransactions::TYPE_VIEW_POLICY: - case PhabricatorTransactions::TYPE_EDIT_POLICY: return; } @@ -69,9 +67,6 @@ final class AlmanacDeviceEditor switch ($xaction->getTransactionType()) { case AlmanacDeviceTransaction::TYPE_NAME: - case PhabricatorTransactions::TYPE_VIEW_POLICY: - case PhabricatorTransactions::TYPE_EDIT_POLICY: - return; case AlmanacDeviceTransaction::TYPE_INTERFACE: $old = $xaction->getOldValue(); if ($old) { diff --git a/src/applications/almanac/editor/AlmanacNetworkEditor.php b/src/applications/almanac/editor/AlmanacNetworkEditor.php index 81f0e63d46..4e49cce163 100644 --- a/src/applications/almanac/editor/AlmanacNetworkEditor.php +++ b/src/applications/almanac/editor/AlmanacNetworkEditor.php @@ -52,9 +52,6 @@ final class AlmanacNetworkEditor case AlmanacNetworkTransaction::TYPE_NAME: $object->setName($xaction->getNewValue()); return; - case PhabricatorTransactions::TYPE_VIEW_POLICY: - case PhabricatorTransactions::TYPE_EDIT_POLICY: - return; } return parent::applyCustomInternalTransaction($object, $xaction); @@ -66,8 +63,6 @@ final class AlmanacNetworkEditor switch ($xaction->getTransactionType()) { case AlmanacNetworkTransaction::TYPE_NAME: - case PhabricatorTransactions::TYPE_VIEW_POLICY: - case PhabricatorTransactions::TYPE_EDIT_POLICY: return; } diff --git a/src/applications/almanac/editor/AlmanacServiceEditor.php b/src/applications/almanac/editor/AlmanacServiceEditor.php index 928696dbcd..868f31d026 100644 --- a/src/applications/almanac/editor/AlmanacServiceEditor.php +++ b/src/applications/almanac/editor/AlmanacServiceEditor.php @@ -61,9 +61,6 @@ final class AlmanacServiceEditor case AlmanacServiceTransaction::TYPE_LOCK: $object->setIsLocked((int)$xaction->getNewValue()); return; - case PhabricatorTransactions::TYPE_VIEW_POLICY: - case PhabricatorTransactions::TYPE_EDIT_POLICY: - return; } return parent::applyCustomInternalTransaction($object, $xaction); @@ -75,8 +72,6 @@ final class AlmanacServiceEditor switch ($xaction->getTransactionType()) { case AlmanacServiceTransaction::TYPE_NAME: - case PhabricatorTransactions::TYPE_VIEW_POLICY: - case PhabricatorTransactions::TYPE_EDIT_POLICY: return; case AlmanacServiceTransaction::TYPE_LOCK: $service = id(new AlmanacServiceQuery()) diff --git a/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php b/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php index bb4c772012..203f29222b 100644 --- a/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php +++ b/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php @@ -108,8 +108,6 @@ final class PhabricatorCalendarEventEditor $object->setIsAllDay((int)$xaction->getNewValue()); return; case PhabricatorCalendarEventTransaction::TYPE_INVITE: - case PhabricatorTransactions::TYPE_VIEW_POLICY: - case PhabricatorTransactions::TYPE_EDIT_POLICY: return; } @@ -148,9 +146,6 @@ final class PhabricatorCalendarEventEditor } $object->attachInvitees($invitees); return; - case PhabricatorTransactions::TYPE_VIEW_POLICY: - case PhabricatorTransactions::TYPE_EDIT_POLICY: - return; } return parent::applyCustomExternalTransaction($object, $xaction); diff --git a/src/applications/dashboard/editor/PhabricatorDashboardPanelTransactionEditor.php b/src/applications/dashboard/editor/PhabricatorDashboardPanelTransactionEditor.php index 6f76e2618e..2a56721442 100644 --- a/src/applications/dashboard/editor/PhabricatorDashboardPanelTransactionEditor.php +++ b/src/applications/dashboard/editor/PhabricatorDashboardPanelTransactionEditor.php @@ -62,12 +62,6 @@ final class PhabricatorDashboardPanelTransactionEditor case PhabricatorDashboardPanelTransaction::TYPE_ARCHIVE: $object->setIsArchived((int)$xaction->getNewValue()); return; - case PhabricatorTransactions::TYPE_VIEW_POLICY: - $object->setViewPolicy($xaction->getNewValue()); - return; - case PhabricatorTransactions::TYPE_EDIT_POLICY: - $object->setEditPolicy($xaction->getNewValue()); - return; } return parent::applyCustomInternalTransaction($object, $xaction); @@ -80,8 +74,6 @@ final class PhabricatorDashboardPanelTransactionEditor switch ($xaction->getTransactionType()) { case PhabricatorDashboardPanelTransaction::TYPE_NAME: case PhabricatorDashboardPanelTransaction::TYPE_ARCHIVE: - case PhabricatorTransactions::TYPE_VIEW_POLICY: - case PhabricatorTransactions::TYPE_EDIT_POLICY: return; } diff --git a/src/applications/dashboard/editor/PhabricatorDashboardTransactionEditor.php b/src/applications/dashboard/editor/PhabricatorDashboardTransactionEditor.php index ed16a22a9c..4b1b6533d6 100644 --- a/src/applications/dashboard/editor/PhabricatorDashboardTransactionEditor.php +++ b/src/applications/dashboard/editor/PhabricatorDashboardTransactionEditor.php @@ -109,12 +109,6 @@ final class PhabricatorDashboardTransactionEditor } $object->setLayoutConfigFromObject($new_layout); return; - case PhabricatorTransactions::TYPE_VIEW_POLICY: - $object->setViewPolicy($xaction->getNewValue()); - return; - case PhabricatorTransactions::TYPE_EDIT_POLICY: - $object->setEditPolicy($xaction->getNewValue()); - return; } return parent::applyCustomInternalTransaction($object, $xaction); @@ -127,8 +121,6 @@ final class PhabricatorDashboardTransactionEditor switch ($xaction->getTransactionType()) { case PhabricatorDashboardTransaction::TYPE_NAME: case PhabricatorDashboardTransaction::TYPE_LAYOUT_MODE: - case PhabricatorTransactions::TYPE_VIEW_POLICY: - case PhabricatorTransactions::TYPE_EDIT_POLICY: return; } diff --git a/src/applications/differential/editor/DifferentialDiffEditor.php b/src/applications/differential/editor/DifferentialDiffEditor.php index 25385899b1..235ab84c21 100644 --- a/src/applications/differential/editor/DifferentialDiffEditor.php +++ b/src/applications/differential/editor/DifferentialDiffEditor.php @@ -62,9 +62,6 @@ final class DifferentialDiffEditor $dict = $this->diffDataDict; $this->updateDiffFromDict($object, $dict); return; - case PhabricatorTransactions::TYPE_VIEW_POLICY: - $object->setViewPolicy($xaction->getNewValue()); - return; } return parent::applyCustomInternalTransaction($object, $xaction); @@ -76,7 +73,6 @@ final class DifferentialDiffEditor switch ($xaction->getTransactionType()) { case DifferentialDiffTransaction::TYPE_DIFF_CREATE: - case PhabricatorTransactions::TYPE_VIEW_POLICY: return; } diff --git a/src/applications/differential/editor/DifferentialTransactionEditor.php b/src/applications/differential/editor/DifferentialTransactionEditor.php index 4534123b24..d195d91833 100644 --- a/src/applications/differential/editor/DifferentialTransactionEditor.php +++ b/src/applications/differential/editor/DifferentialTransactionEditor.php @@ -71,10 +71,6 @@ final class DifferentialTransactionEditor PhabricatorApplicationTransaction $xaction) { switch ($xaction->getTransactionType()) { - case PhabricatorTransactions::TYPE_VIEW_POLICY: - return $object->getViewPolicy(); - case PhabricatorTransactions::TYPE_EDIT_POLICY: - return $object->getEditPolicy(); case DifferentialTransaction::TYPE_ACTION: return null; case DifferentialTransaction::TYPE_INLINE: @@ -95,8 +91,6 @@ final class DifferentialTransactionEditor PhabricatorApplicationTransaction $xaction) { switch ($xaction->getTransactionType()) { - case PhabricatorTransactions::TYPE_VIEW_POLICY: - case PhabricatorTransactions::TYPE_EDIT_POLICY: case DifferentialTransaction::TYPE_ACTION: case DifferentialTransaction::TYPE_UPDATE: return $xaction->getNewValue(); @@ -189,12 +183,6 @@ final class DifferentialTransactionEditor $status_abandoned = ArcanistDifferentialRevisionStatus::ABANDONED; switch ($xaction->getTransactionType()) { - case PhabricatorTransactions::TYPE_VIEW_POLICY: - $object->setViewPolicy($xaction->getNewValue()); - return; - case PhabricatorTransactions::TYPE_EDIT_POLICY: - $object->setEditPolicy($xaction->getNewValue()); - return; case DifferentialTransaction::TYPE_INLINE: return; case DifferentialTransaction::TYPE_UPDATE: @@ -573,9 +561,6 @@ final class DifferentialTransactionEditor PhabricatorApplicationTransaction $xaction) { switch ($xaction->getTransactionType()) { - case PhabricatorTransactions::TYPE_VIEW_POLICY: - case PhabricatorTransactions::TYPE_EDIT_POLICY: - return; case DifferentialTransaction::TYPE_ACTION: return; case DifferentialTransaction::TYPE_INLINE: diff --git a/src/applications/files/editor/PhabricatorFileEditor.php b/src/applications/files/editor/PhabricatorFileEditor.php index a611e3da3f..9cd81a4c1e 100644 --- a/src/applications/files/editor/PhabricatorFileEditor.php +++ b/src/applications/files/editor/PhabricatorFileEditor.php @@ -47,9 +47,6 @@ final class PhabricatorFileEditor PhabricatorApplicationTransaction $xaction) { switch ($xaction->getTransactionType()) { - case PhabricatorTransactions::TYPE_VIEW_POLICY: - $object->setViewPolicy($xaction->getNewValue()); - break; case PhabricatorFileTransaction::TYPE_NAME: $object->setName($xaction->getNewValue()); break; diff --git a/src/applications/fund/editor/FundInitiativeEditor.php b/src/applications/fund/editor/FundInitiativeEditor.php index 13296be13f..679e1b5771 100644 --- a/src/applications/fund/editor/FundInitiativeEditor.php +++ b/src/applications/fund/editor/FundInitiativeEditor.php @@ -102,9 +102,6 @@ final class FundInitiativeEditor $object->setTotalAsCurrency($total); return; - case PhabricatorTransactions::TYPE_VIEW_POLICY: - case PhabricatorTransactions::TYPE_EDIT_POLICY: - return; } return parent::applyCustomInternalTransaction($object, $xaction); @@ -154,9 +151,6 @@ final class FundInitiativeEditor $editor->applyTransactions($backer, $subx); return; - case PhabricatorTransactions::TYPE_VIEW_POLICY: - case PhabricatorTransactions::TYPE_EDIT_POLICY: - return; } return parent::applyCustomExternalTransaction($object, $xaction); diff --git a/src/applications/passphrase/editor/PassphraseCredentialTransactionEditor.php b/src/applications/passphrase/editor/PassphraseCredentialTransactionEditor.php index 3fbe35c249..aacc89c027 100644 --- a/src/applications/passphrase/editor/PassphraseCredentialTransactionEditor.php +++ b/src/applications/passphrase/editor/PassphraseCredentialTransactionEditor.php @@ -108,12 +108,6 @@ final class PassphraseCredentialTransactionEditor } } return; - case PhabricatorTransactions::TYPE_VIEW_POLICY: - $object->setViewPolicy($xaction->getNewValue()); - return; - case PhabricatorTransactions::TYPE_EDIT_POLICY: - $object->setEditPolicy($xaction->getNewValue()); - return; case PassphraseCredentialTransaction::TYPE_LOOKEDATSECRET: return; case PassphraseCredentialTransaction::TYPE_LOCK: @@ -140,8 +134,6 @@ final class PassphraseCredentialTransactionEditor case PassphraseCredentialTransaction::TYPE_LOOKEDATSECRET: case PassphraseCredentialTransaction::TYPE_LOCK: case PassphraseCredentialTransaction::TYPE_CONDUIT: - case PhabricatorTransactions::TYPE_VIEW_POLICY: - case PhabricatorTransactions::TYPE_EDIT_POLICY: return; } diff --git a/src/applications/paste/editor/PhabricatorPasteEditor.php b/src/applications/paste/editor/PhabricatorPasteEditor.php index 7e6a18db44..9c966bf724 100644 --- a/src/applications/paste/editor/PhabricatorPasteEditor.php +++ b/src/applications/paste/editor/PhabricatorPasteEditor.php @@ -82,12 +82,6 @@ final class PhabricatorPasteEditor case PhabricatorPasteTransaction::TYPE_LANGUAGE: $object->setLanguage($xaction->getNewValue()); return; - case PhabricatorTransactions::TYPE_VIEW_POLICY: - $object->setViewPolicy($xaction->getNewValue()); - return; - case PhabricatorTransactions::TYPE_EDIT_POLICY: - $object->setEditPolicy($xaction->getNewValue()); - return; } return parent::applyCustomInternalTransaction($object, $xaction); @@ -101,8 +95,6 @@ final class PhabricatorPasteEditor case PhabricatorPasteTransaction::TYPE_CONTENT: case PhabricatorPasteTransaction::TYPE_TITLE: case PhabricatorPasteTransaction::TYPE_LANGUAGE: - case PhabricatorTransactions::TYPE_VIEW_POLICY: - case PhabricatorTransactions::TYPE_EDIT_POLICY: return; } diff --git a/src/applications/phame/editor/PhameBlogEditor.php b/src/applications/phame/editor/PhameBlogEditor.php index f44be159c8..289b55cf57 100644 --- a/src/applications/phame/editor/PhameBlogEditor.php +++ b/src/applications/phame/editor/PhameBlogEditor.php @@ -67,15 +67,6 @@ final class PhameBlogEditor return $object->setDomain($xaction->getNewValue()); case PhameBlogTransaction::TYPE_SKIN: return $object->setSkin($xaction->getNewValue()); - case PhabricatorTransactions::TYPE_VIEW_POLICY: - $object->setViewPolicy($xaction->getNewValue()); - return; - case PhabricatorTransactions::TYPE_EDIT_POLICY: - $object->setEditPolicy($xaction->getNewValue()); - return; - case PhabricatorTransactions::TYPE_JOIN_POLICY: - $object->setJoinPolicy($xaction->getNewValue()); - return; } return parent::applyCustomInternalTransaction($object, $xaction); @@ -90,9 +81,6 @@ final class PhameBlogEditor case PhameBlogTransaction::TYPE_DESCRIPTION: case PhameBlogTransaction::TYPE_DOMAIN: case PhameBlogTransaction::TYPE_SKIN: - case PhabricatorTransactions::TYPE_VIEW_POLICY: - case PhabricatorTransactions::TYPE_EDIT_POLICY: - case PhabricatorTransactions::TYPE_JOIN_POLICY: return; } diff --git a/src/applications/phlux/editor/PhluxVariableEditor.php b/src/applications/phlux/editor/PhluxVariableEditor.php index 9745ee50c8..2e36ba8162 100644 --- a/src/applications/phlux/editor/PhluxVariableEditor.php +++ b/src/applications/phlux/editor/PhluxVariableEditor.php @@ -54,12 +54,6 @@ final class PhluxVariableEditor case PhluxTransaction::TYPE_EDIT_VALUE: $object->setVariableValue($xaction->getNewValue()); return; - case PhabricatorTransactions::TYPE_VIEW_POLICY: - $object->setViewPolicy($xaction->getNewValue()); - return; - case PhabricatorTransactions::TYPE_EDIT_POLICY: - $object->setEditPolicy($xaction->getNewValue()); - return; } return parent::applyCustomInternalTransaction($object, $xaction); } @@ -70,8 +64,6 @@ final class PhluxVariableEditor switch ($xaction->getTransactionType()) { case PhluxTransaction::TYPE_EDIT_KEY: case PhluxTransaction::TYPE_EDIT_VALUE: - case PhabricatorTransactions::TYPE_VIEW_POLICY: - case PhabricatorTransactions::TYPE_EDIT_POLICY: return; } return parent::applyCustomExternalTransaction($object, $xaction); diff --git a/src/applications/phortune/editor/PhortuneMerchantEditor.php b/src/applications/phortune/editor/PhortuneMerchantEditor.php index ae8c1fda54..1c659c0d5f 100644 --- a/src/applications/phortune/editor/PhortuneMerchantEditor.php +++ b/src/applications/phortune/editor/PhortuneMerchantEditor.php @@ -59,8 +59,6 @@ final class PhortuneMerchantEditor case PhortuneMerchantTransaction::TYPE_DESCRIPTION: $object->setDescription($xaction->getNewValue()); return; - case PhabricatorTransactions::TYPE_VIEW_POLICY: - return; } return parent::applyCustomInternalTransaction($object, $xaction); @@ -73,7 +71,6 @@ final class PhortuneMerchantEditor switch ($xaction->getTransactionType()) { case PhortuneMerchantTransaction::TYPE_NAME: case PhortuneMerchantTransaction::TYPE_DESCRIPTION: - case PhabricatorTransactions::TYPE_VIEW_POLICY: return; } diff --git a/src/applications/project/editor/PhabricatorProjectTransactionEditor.php b/src/applications/project/editor/PhabricatorProjectTransactionEditor.php index 348ba53c4d..307e186dbd 100644 --- a/src/applications/project/editor/PhabricatorProjectTransactionEditor.php +++ b/src/applications/project/editor/PhabricatorProjectTransactionEditor.php @@ -102,15 +102,6 @@ final class PhabricatorProjectTransactionEditor case PhabricatorProjectTransaction::TYPE_LOCKED: $object->setIsMembershipLocked($xaction->getNewValue()); return; - case PhabricatorTransactions::TYPE_VIEW_POLICY: - $object->setViewPolicy($xaction->getNewValue()); - return; - case PhabricatorTransactions::TYPE_EDIT_POLICY: - $object->setEditPolicy($xaction->getNewValue()); - return; - case PhabricatorTransactions::TYPE_JOIN_POLICY: - $object->setJoinPolicy($xaction->getNewValue()); - return; } return parent::applyCustomInternalTransaction($object, $xaction); @@ -157,9 +148,6 @@ final class PhabricatorProjectTransactionEditor } return; - case PhabricatorTransactions::TYPE_VIEW_POLICY: - case PhabricatorTransactions::TYPE_EDIT_POLICY: - case PhabricatorTransactions::TYPE_JOIN_POLICY: case PhabricatorProjectTransaction::TYPE_STATUS: case PhabricatorProjectTransaction::TYPE_IMAGE: case PhabricatorProjectTransaction::TYPE_ICON: diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php index 486a20a918..0329613b0e 100644 --- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php +++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php @@ -388,19 +388,12 @@ abstract class PhabricatorApplicationTransactionEditor case PhabricatorTransactions::TYPE_BUILDABLE: case PhabricatorTransactions::TYPE_TOKEN: return; - case PhabricatorTransactions::TYPE_VIEW_POLICY: - $object->setViewPolicy($xaction->getNewValue()); - break; - case PhabricatorTransactions::TYPE_EDIT_POLICY: - $object->setEditPolicy($xaction->getNewValue()); - break; - case PhabricatorTransactions::TYPE_JOIN_POLICY: - $object->setJoinPolicy($xaction->getNewValue()); - break; - case PhabricatorTransactions::TYPE_CUSTOMFIELD: $field = $this->getCustomFieldForTransaction($object, $xaction); return $field->applyApplicationTransactionInternalEffects($xaction); + case PhabricatorTransactions::TYPE_VIEW_POLICY: + case PhabricatorTransactions::TYPE_EDIT_POLICY: + case PhabricatorTransactions::TYPE_JOIN_POLICY: case PhabricatorTransactions::TYPE_SUBSCRIBERS: case PhabricatorTransactions::TYPE_INLINESTATE: case PhabricatorTransactions::TYPE_EDGE: @@ -500,6 +493,9 @@ abstract class PhabricatorApplicationTransactionEditor case PhabricatorTransactions::TYPE_CUSTOMFIELD: $field = $this->getCustomFieldForTransaction($object, $xaction); return $field->applyApplicationTransactionExternalEffects($xaction); + case PhabricatorTransactions::TYPE_VIEW_POLICY: + case PhabricatorTransactions::TYPE_EDIT_POLICY: + case PhabricatorTransactions::TYPE_JOIN_POLICY: case PhabricatorTransactions::TYPE_INLINESTATE: case PhabricatorTransactions::TYPE_COMMENT: return $this->applyBuiltinExternalTransaction($object, $xaction); @@ -534,7 +530,18 @@ abstract class PhabricatorApplicationTransactionEditor protected function applyBuiltinInternalTransaction( PhabricatorLiskDAO $object, PhabricatorApplicationTransaction $xaction) { - return; + + switch ($xaction->getTransactionType()) { + case PhabricatorTransactions::TYPE_VIEW_POLICY: + $object->setViewPolicy($xaction->getNewValue()); + break; + case PhabricatorTransactions::TYPE_EDIT_POLICY: + $object->setEditPolicy($xaction->getNewValue()); + break; + case PhabricatorTransactions::TYPE_JOIN_POLICY: + $object->setJoinPolicy($xaction->getNewValue()); + break; + } } protected function applyBuiltinExternalTransaction(