Always parse the first line of a commit message as a title

Summary: Fixes T10312. If your first line is "Reviewers: xyz", it's a title, not a "Reviewers" field.

Test Plan: Added unit test.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10312

Differential Revision: https://secure.phabricator.com/D17122

src/applications/differential/parser/DifferentialCommitMessageParser.php

@@ -161,17 +161,27 @@ final class DifferentialCommitMessageParser extends Phobject {
 
     $field_map = array();
     foreach ($lines as $key => $line) {
-      $match = null;
+      // We always parse the first line of the message as a title, even if it
-      if (preg_match($label_regexp, $line, $match)) {
+      // contains something we recognize as a field header.
-        $lines[$key] = trim($match['text']);
+      if (!isset($seen[$key_title])) {
-        $field = $label_map[self::normalizeFieldLabel($match['field'])];
+        $field = $key_title;
-        if (!empty($seen[$field])) {
+
-          $this->errors[] = pht(
+        $lines[$key] = trim($line);
-            'Field "%s" occurs twice in commit message!',
-            $field);
-        }
         $seen[$field] = true;
+      } else {
+        $match = null;
+        if (preg_match($label_regexp, $line, $match)) {
+          $lines[$key] = trim($match['text']);
+          $field = $label_map[self::normalizeFieldLabel($match['field'])];
+          if (!empty($seen[$field])) {
+            $this->errors[] = pht(
+              'Field "%s" occurs twice in commit message!',
+              $match['field']);
+          }
+          $seen[$field] = true;
+        }
       }
+
       $field_map[$key] = $field;
     }
 

src/applications/differential/parser/__tests__/messages/title-with-label.txt

@@ -0,0 +1,11 @@
+color: orange
+~~~~~~~~~~
+{
+  "color": "color"
+}
+~~~~~~~~~~
+{
+  "title": "color: orange"
+}
+~~~~~~~~~~
+[]