mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-09 16:32:39 +01:00
Fix PHP 8.1 "strlen(null)" exception in PhabricatorAuthAccountView
Summary: `strlen()` was used in Phabricator to check if a generic value is a non-empty string. This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If phutil_nonempty_string() throws an exception in your instance, report it to Phorge to evaluate and fix that specific corner case. ``` ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/auth/view/PhabricatorAuthAccountView.php:66] ``` Closes T15900 Test Plan: Try to register an account via LDAP. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15900 Differential Revision: https://we.phorge.it/D25761
This commit is contained in:
parent
a110aa471e
commit
81ffe4f8b1
1 changed files with 1 additions and 1 deletions
|
@ -63,7 +63,7 @@ final class PhabricatorAuthAccountView extends AphrontView {
|
|||
));
|
||||
|
||||
$account_uri = $account->getAccountURI();
|
||||
if (strlen($account_uri)) {
|
||||
if (phutil_nonempty_string($account_uri)) {
|
||||
|
||||
// Make sure we don't link a "javascript:" URI if a user somehow
|
||||
// managed to get one here.
|
||||
|
|
Loading…
Reference in a new issue