revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-16 16:58:38 +01:00
Code Issues Releases Wiki Activity

Fix "fullName" rules for Maniphest transaction email

Browse source 
Summary: I changed this from `getName` to `getFullName` to make attached revisions, etc., render with "Dnnn", but accidentally made all users render as "username (Full Name)". Be a little more surgical in application of full names.

Test Plan: Created a task and attached a CC, a task and a revision. Verified the task and revision rendered with "Tnn", "Dnn" but the CC rendered as "username".

Reviewers: btrahan, vrana

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D3041
This commit is contained in:
epriestley 2012-07-23 14:01:09 -07:00
parent 8cbd860e31
commit 8213a70f3d
1 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/applications/maniphest/view/ManiphestTransactionDetailView.php
View file

@ -619,11 +619,15 @@ final class ManiphestTransactionDetailView extends ManiphestView {
'show details');
}
private function renderHandles($phids) {
private function renderHandles($phids, $full = false) {
$links = array();
foreach ($phids as $phid) {
if ($this->forEmail) {
$links[] = $this->handles[$phid]->getFullName();
if ($full) {
$links[] = $this->handles[$phid]->getFullName();
} else {
$links[] = $this->handles[$phid]->getName();
}
} else {
$links[] = $this->handles[$phid]->renderLink();
}
@ -739,7 +743,7 @@ final class ManiphestTransactionDetailView extends ManiphestView {
* @task strings
*/
private function getEdgeAddList($type, array $add) {
$list = $this->renderHandles(array_keys($add));
$list = $this->renderHandles(array_keys($add), $full = true);
$count = count($add);
switch ($type) {
@ -761,7 +765,7 @@ final class ManiphestTransactionDetailView extends ManiphestView {
* @task strings
*/
private function getEdgeRemList($type, array $rem) {
$list = $this->renderHandles(array_keys($rem));
$list = $this->renderHandles(array_keys($rem), $full = true);
$count = count($rem);
switch ($type) {
@ -783,8 +787,8 @@ final class ManiphestTransactionDetailView extends ManiphestView {
* @task strings
*/
private function getEdgeEditList($type, array $add, array $rem) {
$add_list = $this->renderHandles(array_keys($add));
$rem_list = $this->renderHandles(array_keys($rem));
$add_list = $this->renderHandles(array_keys($add), $full = true);
$rem_list = $this->renderHandles(array_keys($rem), $full = true);
$add_count = count($add_list);
$rem_count = count($rem_list);