Show draft icon in attributes?

Summary: Ref T3485. Maybe this is OK?

Test Plan: {F48656}

Reviewers: chad

Reviewed By: chad

CC: aran

Maniphest Tasks: T3485

Differential Revision: https://secure.phabricator.com/D6356

src/__celerity_resource_map__.php

@@ -3249,7 +3249,7 @@ celerity_register_resource_map(array(
   ),
   'phabricator-object-item-list-view-css' =>
   array(
-    'uri' => '/res/4e44cc37/rsrc/css/layout/phabricator-object-item-list-view.css',
+    'uri' => '/res/85921314/rsrc/css/layout/phabricator-object-item-list-view.css',
     'type' => 'css',
     'requires' =>
     array(
@@ -4073,7 +4073,7 @@ celerity_register_resource_map(array(
 ), array(
   'packages' =>
   array(
-    '8000c812' =>
+    'e00fd709' =>
     array(
       'name' => 'core.pkg.css',
       'symbols' =>
@@ -4121,7 +4121,7 @@ celerity_register_resource_map(array(
         40 => 'phabricator-property-list-view-css',
         41 => 'phabricator-tag-view-css',
       ),
-      'uri' => '/res/pkg/8000c812/core.pkg.css',
+      'uri' => '/res/pkg/e00fd709/core.pkg.css',
       'type' => 'css',
     ),
     'f2ad0683' =>
@@ -4315,16 +4315,16 @@ celerity_register_resource_map(array(
   'reverse' =>
   array(
     'aphront-attached-file-view-css' => 'adc3c36d',
-    'aphront-dialog-view-css' => '8000c812',
-    'aphront-error-view-css' => '8000c812',
-    'aphront-form-view-css' => '8000c812',
-    'aphront-list-filter-view-css' => '8000c812',
-    'aphront-pager-view-css' => '8000c812',
-    'aphront-panel-view-css' => '8000c812',
-    'aphront-table-view-css' => '8000c812',
-    'aphront-tokenizer-control-css' => '8000c812',
-    'aphront-tooltip-css' => '8000c812',
-    'aphront-typeahead-control-css' => '8000c812',
+    'aphront-dialog-view-css' => 'e00fd709',
+    'aphront-error-view-css' => 'e00fd709',
+    'aphront-form-view-css' => 'e00fd709',
+    'aphront-list-filter-view-css' => 'e00fd709',
+    'aphront-pager-view-css' => 'e00fd709',
+    'aphront-panel-view-css' => 'e00fd709',
+    'aphront-table-view-css' => 'e00fd709',
+    'aphront-tokenizer-control-css' => 'e00fd709',
+    'aphront-tooltip-css' => 'e00fd709',
+    'aphront-typeahead-control-css' => 'e00fd709',
     'differential-changeset-view-css' => 'dd27a69b',
     'differential-core-view-css' => 'dd27a69b',
     'differential-inline-comment-editor' => '9488bb69',
@@ -4338,7 +4338,7 @@ celerity_register_resource_map(array(
     'differential-table-of-contents-css' => 'dd27a69b',
     'diffusion-commit-view-css' => 'c8ce2d88',
     'diffusion-icons-css' => 'c8ce2d88',
-    'global-drag-and-drop-css' => '8000c812',
+    'global-drag-and-drop-css' => 'e00fd709',
     'inline-comment-summary-css' => 'dd27a69b',
     'javelin-aphlict' => 'f2ad0683',
     'javelin-behavior' => 'a9f14d76',
@@ -4412,55 +4412,55 @@ celerity_register_resource_map(array(
     'javelin-util' => 'a9f14d76',
     'javelin-vector' => 'a9f14d76',
     'javelin-workflow' => 'a9f14d76',
-    'lightbox-attachment-css' => '8000c812',
+    'lightbox-attachment-css' => 'e00fd709',
     'maniphest-task-summary-css' => 'adc3c36d',
     'maniphest-transaction-detail-css' => 'adc3c36d',
-    'phabricator-action-list-view-css' => '8000c812',
-    'phabricator-application-launch-view-css' => '8000c812',
+    'phabricator-action-list-view-css' => 'e00fd709',
+    'phabricator-application-launch-view-css' => 'e00fd709',
     'phabricator-busy' => 'f2ad0683',
     'phabricator-content-source-view-css' => 'dd27a69b',
-    'phabricator-core-css' => '8000c812',
-    'phabricator-crumbs-view-css' => '8000c812',
+    'phabricator-core-css' => 'e00fd709',
+    'phabricator-crumbs-view-css' => 'e00fd709',
     'phabricator-drag-and-drop-file-upload' => '9488bb69',
     'phabricator-dropdown-menu' => 'f2ad0683',
     'phabricator-file-upload' => 'f2ad0683',
-    'phabricator-filetree-view-css' => '8000c812',
-    'phabricator-flag-css' => '8000c812',
-    'phabricator-form-view-css' => '8000c812',
-    'phabricator-header-view-css' => '8000c812',
+    'phabricator-filetree-view-css' => 'e00fd709',
+    'phabricator-flag-css' => 'e00fd709',
+    'phabricator-form-view-css' => 'e00fd709',
+    'phabricator-header-view-css' => 'e00fd709',
     'phabricator-hovercard' => 'f2ad0683',
-    'phabricator-jump-nav' => '8000c812',
+    'phabricator-jump-nav' => 'e00fd709',
     'phabricator-keyboard-shortcut' => 'f2ad0683',
     'phabricator-keyboard-shortcut-manager' => 'f2ad0683',
-    'phabricator-main-menu-view' => '8000c812',
+    'phabricator-main-menu-view' => 'e00fd709',
     'phabricator-menu-item' => 'f2ad0683',
-    'phabricator-nav-view-css' => '8000c812',
+    'phabricator-nav-view-css' => 'e00fd709',
     'phabricator-notification' => 'f2ad0683',
-    'phabricator-notification-css' => '8000c812',
-    'phabricator-notification-menu-css' => '8000c812',
-    'phabricator-object-item-list-view-css' => '8000c812',
+    'phabricator-notification-css' => 'e00fd709',
+    'phabricator-notification-menu-css' => 'e00fd709',
+    'phabricator-object-item-list-view-css' => 'e00fd709',
     'phabricator-object-selector-css' => 'dd27a69b',
     'phabricator-phtize' => 'f2ad0683',
     'phabricator-prefab' => 'f2ad0683',
     'phabricator-project-tag-css' => 'adc3c36d',
-    'phabricator-property-list-view-css' => '8000c812',
-    'phabricator-remarkup-css' => '8000c812',
+    'phabricator-property-list-view-css' => 'e00fd709',
+    'phabricator-remarkup-css' => 'e00fd709',
     'phabricator-shaped-request' => '9488bb69',
-    'phabricator-side-menu-view-css' => '8000c812',
-    'phabricator-standard-page-view' => '8000c812',
-    'phabricator-tag-view-css' => '8000c812',
+    'phabricator-side-menu-view-css' => 'e00fd709',
+    'phabricator-standard-page-view' => 'e00fd709',
+    'phabricator-tag-view-css' => 'e00fd709',
     'phabricator-textareautils' => 'f2ad0683',
     'phabricator-tooltip' => 'f2ad0683',
-    'phabricator-transaction-view-css' => '8000c812',
-    'phabricator-zindex-css' => '8000c812',
-    'phui-button-css' => '8000c812',
-    'phui-form-css' => '8000c812',
-    'phui-icon-view-css' => '8000c812',
-    'phui-spacing-css' => '8000c812',
-    'sprite-apps-large-css' => '8000c812',
-    'sprite-gradient-css' => '8000c812',
-    'sprite-icons-css' => '8000c812',
-    'sprite-menu-css' => '8000c812',
-    'syntax-highlighting-css' => '8000c812',
+    'phabricator-transaction-view-css' => 'e00fd709',
+    'phabricator-zindex-css' => 'e00fd709',
+    'phui-button-css' => 'e00fd709',
+    'phui-form-css' => 'e00fd709',
+    'phui-icon-view-css' => 'e00fd709',
+    'phui-spacing-css' => 'e00fd709',
+    'sprite-apps-large-css' => 'e00fd709',
+    'sprite-gradient-css' => 'e00fd709',
+    'sprite-icons-css' => 'e00fd709',
+    'sprite-menu-css' => 'e00fd709',
+    'syntax-highlighting-css' => 'e00fd709',
   ),
 ));

src/applications/differential/view/DifferentialRevisionListView.php

@@ -131,9 +131,7 @@ final class DifferentialRevisionListView extends AphrontView {
           '');
       }
       if (array_key_exists($revision->getID(), $this->drafts)) {
-        $icons['draft'] = array(
-          'icon' => 'file-grey',
-        );
+        $icons['draft'] = true;
       }
 
       $modified = $revision->getDateModified();
@@ -175,6 +173,19 @@ final class DifferentialRevisionListView extends AphrontView {
       $item->setHeader(phutil_tag('a',
         array('href' => '/D'.$revision->getID()),
         $revision->getTitle()));
+
+      if (isset($icons['draft'])) {
+        $draft = id(new PHUIIconView())
+          ->setSpriteSheet(PHUIIconView::SPRITE_ICONS)
+          ->setSpriteIcon('file-grey')
+          ->addSigil('has-tooltip')
+          ->setMetadata(
+            array(
+              'tip' => pht('Unsubmitted Comments'),
+            ));
+        $item->addAttribute($draft);
+      }
+
       $item->addAttribute($status_name);
 
       // Author
@@ -184,16 +195,6 @@ final class DifferentialRevisionListView extends AphrontView {
       // Reviewers
       $item->addAttribute(pht('Reviewers: %s', $rev_fields['Reviewers']));
 
-      $item->setStateIconColumns(1);
-
-      if (isset($icons['draft'])) {
-        $item->addStateIcon(
-          $icons['draft']['icon'],
-          pht('Saved Comments'));
-      } else {
-        $item->addStateIcon('none');
-      }
-
       $time_icon = 'none';
       $time_attr = array();
       if ($this->highlightAge) {

webroot/rsrc/css/layout/phabricator-object-item-list-view.css

@@ -33,6 +33,10 @@
   box-shadow: 0px 1px 1px rgba(0, 0, 0, 0.10);
 }
 
+.phabricator-object-item .phui-icon-view {
+  display: inline-block;
+}
+
 .phabricator-object-item-frame {
   border-style: solid;
   border-color: #c0c5d1;