revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 22:10:55 +01:00
Code Issues Releases Wiki Activity

When users choose a default project icon, make a permanent file

Browse source 
Summary:
Fixes T10907. As written, this workflow will incorrectly reuse a temporary file if one exists.

Instead, make a new permanent file.

(Storage is still shared, so this usually will not actually create a copy of the file's data.)

Test Plan:
  - Set a project's icon by clicking first button in "Use Picture" row.
  - Before patch: temporary image was reused.
  - After patch: new permanent file is generated.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10907

Differential Revision: https://secure.phabricator.com/D16270
This commit is contained in:
epriestley 2016-07-11 08:20:42 -07:00
parent 553c335fbd
commit 830f3eb8f8
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/files/controller/PhabricatorFileComposeController.php
View file

@ -35,7 +35,7 @@ final class PhabricatorFileComposeController
$data = $composer->loadBuiltinFileData(); $data = $composer->loadBuiltinFileData();
$file = PhabricatorFile::buildFromFileDataOrHash( $file = PhabricatorFile::newFromFileData(
$data, $data,
array( array(
'name' => $composer->getBuiltinDisplayName(), 'name' => $composer->getBuiltinDisplayName(),