revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-29 18:22:41 +01:00
Code Issues Releases Wiki Activity

Reload subscribers before sending mail, etc

Browse source 
Summary: Fixes T4629. CCs added by Herald don't get added to the cached subscriber list. Just reload subscribers before sending mail to pick up effects.

Test Plan: Created an "always add X as CC" Herald rule for revisions, created a revision, saw them get initial mail.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: spicyj, epriestley

Maniphest Tasks: T4629

Differential Revision: https://secure.phabricator.com/D8565
This commit is contained in:
epriestley 2014-03-18 16:01:21 -07:00
parent 5721560663
commit 833b8a78d8
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
View file

@ -695,6 +695,11 @@ abstract class PhabricatorApplicationTransactionEditor
} }
} }
// Before sending mail or publishing feed stories, reload the object
// subscribers to pick up changes caused by Herald (or by other side effects
// in various transaction phases).
$this->loadSubscribers($object);
$this->loadHandles($xactions); $this->loadHandles($xactions);
$mail = null; $mail = null;