revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-19 05:12:41 +01:00
Code Issues Releases Wiki Activity

Rename TypehaeadUserParameterizedDatasource to PeopleUserFunctionDatasource

Browse source 
Summary: Ref T4100. This improves application scoping (Typeahead -> People) and uses a more consitent and concise name (Parameterized -> Function).

Test Plan:
  - `grep`
  - Used affected datasource.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4100

Differential Revision: https://secure.phabricator.com/D12532
This commit is contained in:
epriestley 2015-04-23 08:06:46 -07:00
parent e094af4618
commit 83617073f5
7 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/__phutil_library_map__.php
View file

@ -2218,6 +2218,7 @@ phutil_register_library_map(array(
'PhabricatorPeopleRenameController' => 'applications/people/controller/PhabricatorPeopleRenameController.php',
'PhabricatorPeopleSearchEngine' => 'applications/people/query/PhabricatorPeopleSearchEngine.php',
'PhabricatorPeopleTestDataGenerator' => 'applications/people/lipsum/PhabricatorPeopleTestDataGenerator.php',
'PhabricatorPeopleUserFunctionDatasource' => 'applications/people/typeahead/PhabricatorPeopleUserFunctionDatasource.php',
'PhabricatorPeopleUserPHIDType' => 'applications/people/phid/PhabricatorPeopleUserPHIDType.php',
'PhabricatorPeopleWelcomeController' => 'applications/people/controller/PhabricatorPeopleWelcomeController.php',
'PhabricatorPersonaAuthProvider' => 'applications/auth/provider/PhabricatorPersonaAuthProvider.php',
@ -2652,7 +2653,6 @@ phutil_register_library_map(array(
'PhabricatorTypeaheadResult' => 'applications/typeahead/storage/PhabricatorTypeaheadResult.php',
'PhabricatorTypeaheadRuntimeCompositeDatasource' => 'applications/typeahead/datasource/PhabricatorTypeaheadRuntimeCompositeDatasource.php',
'PhabricatorTypeaheadTokenView' => 'applications/typeahead/view/PhabricatorTypeaheadTokenView.php',
'PhabricatorTypeaheadUserParameterizedDatasource' => 'applications/typeahead/datasource/PhabricatorTypeaheadUserParameterizedDatasource.php',
'PhabricatorUIConfigOptions' => 'applications/config/option/PhabricatorUIConfigOptions.php',
'PhabricatorUIExample' => 'applications/uiexample/examples/PhabricatorUIExample.php',
'PhabricatorUIExampleRenderController' => 'applications/uiexample/controller/PhabricatorUIExampleRenderController.php',
@ -5590,6 +5590,7 @@ phutil_register_library_map(array(
'PhabricatorPeopleRenameController' => 'PhabricatorPeopleController',
'PhabricatorPeopleSearchEngine' => 'PhabricatorApplicationSearchEngine',
'PhabricatorPeopleTestDataGenerator' => 'PhabricatorTestDataGenerator',
'PhabricatorPeopleUserFunctionDatasource' => 'PhabricatorTypeaheadCompositeDatasource',
'PhabricatorPeopleUserPHIDType' => 'PhabricatorPHIDType',
'PhabricatorPeopleWelcomeController' => 'PhabricatorPeopleController',
'PhabricatorPersonaAuthProvider' => 'PhabricatorAuthProvider',
@ -6072,7 +6073,6 @@ phutil_register_library_map(array(
'PhabricatorTypeaheadMonogramDatasource' => 'PhabricatorTypeaheadDatasource',
'PhabricatorTypeaheadRuntimeCompositeDatasource' => 'PhabricatorTypeaheadCompositeDatasource',
'PhabricatorTypeaheadTokenView' => 'AphrontTagView',
'PhabricatorTypeaheadUserParameterizedDatasource' => 'PhabricatorTypeaheadCompositeDatasource',
'PhabricatorUIConfigOptions' => 'PhabricatorApplicationConfigOptions',
'PhabricatorUIExampleRenderController' => 'PhabricatorController',
'PhabricatorUIExamplesApplication' => 'PhabricatorApplication',

4
src/applications/differential/query/DifferentialRevisionSearchEngine.php
View file

@ -71,7 +71,7 @@ final class DifferentialRevisionSearchEngine
->needDrafts(true)
->needRelationships(true);
$datasource = id(new PhabricatorTypeaheadUserParameterizedDatasource())
$datasource = id(new PhabricatorPeopleUserFunctionDatasource())
->setViewer($this->requireViewer());
$responsible_phids = $saved->getParameter('responsiblePHIDs', array());
@ -140,7 +140,7 @@ final class DifferentialRevisionSearchEngine
id(new AphrontFormTokenizerControl())
->setLabel(pht('Responsible Users'))
->setName('responsibles')
->setDatasource(new PhabricatorTypeaheadUserParameterizedDatasource())
->setDatasource(new PhabricatorPeopleUserFunctionDatasource())
->setValue($responsible_phids))
->appendControl(
id(new AphrontFormTokenizerControl())

4
src/applications/maniphest/query/ManiphestTaskSearchEngine.php
View file

@ -113,7 +113,7 @@ final class ManiphestTaskSearchEngine
$viewer = $this->requireViewer();
$datasource = id(new PhabricatorTypeaheadUserParameterizedDatasource())
$datasource = id(new PhabricatorPeopleUserFunctionDatasource())
->setViewer($viewer);
$author_phids = $saved->getParameter('authorPHIDs', array());
@ -265,7 +265,7 @@ final class ManiphestTaskSearchEngine
->setValue($projects))
->appendControl(
id(new AphrontFormTokenizerControl())
->setDatasource(new PhabricatorTypeaheadUserParameterizedDatasource())
->setDatasource(new PhabricatorPeopleUserFunctionDatasource())
->setName('authors')
->setLabel(pht('Authors'))
->setValue($author_phids))

2
src/applications/typeahead/datasource/PhabricatorTypeaheadUserParameterizedDatasource.php → src/applications/people/typeahead/PhabricatorPeopleUserFunctionDatasource.php
View file

@ -1,6 +1,6 @@
<?php
final class PhabricatorTypeaheadUserParameterizedDatasource
final class PhabricatorPeopleUserFunctionDatasource
extends PhabricatorTypeaheadCompositeDatasource {
public function getBrowseTitle() {

2
src/applications/pholio/query/PholioMockQuery.php
View file

@ -182,7 +182,7 @@ final class PholioMockQuery
return 'PhabricatorPholioApplication';
}
public function getPrimaryTableAlias() {
protected function getPrimaryTableAlias() {
return 'mock';
}

4
src/applications/pholio/query/PholioMockSearchEngine.php
View file

@ -34,7 +34,7 @@ final class PholioMockSearchEngine extends PhabricatorApplicationSearchEngine {
->needImages(true)
->needTokenCounts(true);
$datasource = id(new PhabricatorTypeaheadUserParameterizedDatasource())
$datasource = id(new PhabricatorPeopleUserFunctionDatasource())
->setViewer($this->requireViewer());
$author_phids = $saved->getParameter('authorPHIDs', array());
@ -72,7 +72,7 @@ final class PholioMockSearchEngine extends PhabricatorApplicationSearchEngine {
$form
->appendControl(
id(new AphrontFormTokenizerControl())
->setDatasource(new PhabricatorTypeaheadUserParameterizedDatasource())
->setDatasource(new PhabricatorPeopleUserFunctionDatasource())
->setName('authors')
->setLabel(pht('Authors'))
->setValue($author_phids))

4
src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php
View file

@ -62,7 +62,7 @@ final class PhabricatorSearchApplicationSearchEngine
$config->setParameter('ownerPHIDs', $owner_phids);
$datasource = id(new PhabricatorTypeaheadUserParameterizedDatasource())
$datasource = id(new PhabricatorPeopleUserFunctionDatasource())
->setViewer($viewer);
$author_phids = $config->getParameter('authorPHIDs', array());
$author_phids = $datasource->evaluateTokens($author_phids);
@ -142,7 +142,7 @@ final class PhabricatorSearchApplicationSearchEngine
id(new AphrontFormTokenizerControl())
->setName('authorPHIDs')
->setLabel('Authors')
->setDatasource(new PhabricatorTypeaheadUserParameterizedDatasource())
->setDatasource(new PhabricatorPeopleUserFunctionDatasource())
->setValue($author_phids))
->appendControl(
id(new AphrontFormTokenizerControl())