Update Config to new UI

Summary: Converts Config to new UI, updates to `newPage`

Test Plan: Review all pages in Config, setup issues, ignore an issue, edit a config option

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15587

src/applications/config/controller/PhabricatorConfigAllController.php

@@ -64,12 +64,10 @@ final class PhabricatorConfigAllController
     $nav->setCrumbs($crumbs);
     $nav->appendChild($panel);
 
+    return $this->newPage()
+      ->setTitle($title)
+      ->appendChild($nav);
 
-    return $this->buildApplicationPage(
-      $nav,
-      array(
-        'title' => $title,
-      ));
   }
 
 }

src/applications/config/controller/PhabricatorConfigCacheController.php

@@ -25,11 +25,9 @@ final class PhabricatorConfigCacheController
         $data_box,
       ));
 
-    return $this->buildApplicationPage(
+    return $this->newPage()
-      $nav,
+      ->setTitle($title)
-      array(
+      ->appendChild($nav);
-        'title' => $title,
-      ));
   }
 
   private function renderCodeBox() {

src/applications/config/controller/PhabricatorConfigDatabaseIssueController.php

@@ -159,11 +159,9 @@ final class PhabricatorConfigDatabaseIssueController
         $table_box,
       ));
 
-    return $this->buildApplicationPage(
+    return $this->newPage()
-      $nav,
+      ->setTitle($title)
-      array(
+      ->appendChild($nav);
-        'title' => $title,
-      ));
   }
 
 }

src/applications/config/controller/PhabricatorConfigDatabaseStatusController.php

@@ -94,11 +94,9 @@ final class PhabricatorConfigDatabaseStatusController
     $nav->setCrumbs($crumbs);
     $nav->appendChild($body);
 
-    return $this->buildApplicationPage(
+    return $this->newPage()
-      $nav,
+      ->setTitle($title)
-      array(
+      ->appendChild($nav);
-        'title' => $title,
-      ));
   }
 
 

src/applications/config/controller/PhabricatorConfigEditController.php

@@ -227,11 +227,13 @@ final class PhabricatorConfigEditController
           ->setValue($examples));
     }
 
-    $title = pht('Edit %s', $key);
+    $title = pht('Edit Option: %s', $key);
+    $header_icon = 'fa-pencil';
     $short = pht('Edit');
 
     $form_box = id(new PHUIObjectBoxView())
-      ->setHeaderText($title)
+      ->setHeaderText(pht('Config Option'))
+      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
       ->setForm($form);
 
     if ($error_view) {
@@ -246,21 +248,25 @@ final class PhabricatorConfigEditController
     }
 
     $crumbs->addTextCrumb($key, '/config/edit/'.$key);
+    $crumbs->setBorder(true);
 
     $timeline = $this->buildTransactionTimeline(
       $config_entry,
       new PhabricatorConfigTransactionQuery());
     $timeline->setShouldTerminate(true);
 
-    return $this->buildApplicationPage(
+    $header = id(new PHUIHeaderView())
-      array(
+      ->setHeader($title)
-        $crumbs,
+      ->setHeaderIcon($header_icon);
-        $form_box,
+
-        $timeline,
+    $view = id(new PHUITwoColumnView())
-      ),
+      ->setHeader($header)
-      array(
+      ->setFooter($form_box);
-        'title' => $title,
+
-      ));
+    return $this->newPage()
+      ->setTitle($title)
+      ->setCrumbs($crumbs)
+      ->appendChild($view);
   }
 
   private function readRequest(

src/applications/config/controller/PhabricatorConfigGroupController.php

@@ -17,22 +17,26 @@ final class PhabricatorConfigGroupController
     $list = $this->buildOptionList($options->getOptions());
 
     $box = id(new PHUIObjectBoxView())
-      ->setHeaderText($title)
       ->setObjectList($list);
 
     $crumbs = $this
       ->buildApplicationCrumbs()
       ->addTextCrumb(pht('Config'), $this->getApplicationURI())
-      ->addTextCrumb($options->getName(), $this->getApplicationURI());
+      ->addTextCrumb($options->getName(), $this->getApplicationURI())
+      ->setBorder(true);
 
-    return $this->buildApplicationPage(
+    $header = id(new PHUIHeaderView())
-      array(
+      ->setHeader($title)
-        $crumbs,
+      ->setHeaderIcon('fa-sliders');
-        $box,
+
-      ),
+    $view = id(new PHUITwoColumnView())
-      array(
+      ->setHeader($header)
-        'title' => $title,
+      ->setFooter($box);
-      ));
+
+    return $this->newPage()
+      ->setTitle($title)
+      ->setCrumbs($crumbs)
+      ->appendChild($view);
   }
 
   private function buildOptionList(array $options) {

src/applications/config/controller/PhabricatorConfigHistoryController.php

@@ -40,13 +40,9 @@ final class PhabricatorConfigHistoryController
     $nav->setCrumbs($crumbs);
     $nav->appendChild($timeline);
 
-    return $this->buildApplicationPage(
+    return $this->newPage()
-      array(
+      ->setTitle($title)
-        $nav,
+      ->appendChild($nav);
-      ),
-      array(
-        'title' => $title,
-      ));
   }
 
 }

src/applications/config/controller/PhabricatorConfigIgnoreController.php

@@ -32,14 +32,12 @@ final class PhabricatorConfigIgnoreController
       throw new Exception(pht('Unrecognized verb: %s', $verb));
     }
 
-    $dialog = id(new AphrontDialogView())
+    return $this->newDialog()
-      ->setUser($request->getUser())
       ->setTitle($title)
       ->appendChild($body)
       ->addSubmitButton($submit_title)
       ->addCancelButton($issue_uri);
 
-    return id(new AphrontDialogResponse())->setDialog($dialog);
   }
 
   public function manageApplication($issue) {

src/applications/config/controller/PhabricatorConfigIssueListController.php

@@ -66,11 +66,9 @@ final class PhabricatorConfigIssueListController
 
     $nav->setCrumbs($crumbs);
 
-    return $this->buildApplicationPage(
+    return $this->newPage()
-      $nav,
+      ->setTitle($title)
-      array(
+      ->appendChild($nav);
-        'title' => $title,
-      ));
   }
 
   private function buildIssueList(array $issues, $group) {

src/applications/config/controller/PhabricatorConfigIssueViewController.php

@@ -36,14 +36,10 @@ final class PhabricatorConfigIssueViewController
       ->addTextCrumb(pht('Setup Issues'), $this->getApplicationURI('issue/'))
       ->addTextCrumb($title, $request->getRequestURI());
 
-    return $this->buildApplicationPage(
+    return $this->newPage()
-      array(
+      ->setTitle($title)
-        $crumbs,
+      ->setCrumbs($crumbs)
-        $content,
+      ->appendChild($content);
-      ),
-      array(
-        'title' => $title,
-      ));
   }
 
   private function renderIssue(PhabricatorSetupIssue $issue) {

src/applications/config/controller/PhabricatorConfigListController.php

@@ -35,11 +35,9 @@ final class PhabricatorConfigListController
 
     $nav->setCrumbs($crumbs);
 
-    return $this->buildApplicationPage(
+    return $this->newPage()
-      $nav,
+      ->setTitle($title)
-      array(
+      ->appendChild($nav);
-        'title' => $title,
-      ));
   }
 
   private function buildConfigOptionsList(array $groups, $type) {

src/applications/config/controller/PhabricatorConfigModuleController.php

@@ -14,10 +14,10 @@ final class PhabricatorConfigModuleController
 
     $module = $all_modules[$key];
     $content = $module->renderModuleStatus($request);
-    $name = $module->getModuleName();
+    $title = $module->getModuleName();
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addTextCrumb($name);
+    $crumbs->addTextCrumb($title);
 
     $nav = $this->buildSideNavView();
     $nav->selectFilter('module/'.$key.'/');
@@ -27,11 +27,9 @@ final class PhabricatorConfigModuleController
         $content,
       ));
 
-    return $this->buildApplicationPage(
+    return $this->newPage()
-      $nav,
+      ->setTitle($title)
-      array(
+      ->appendChild($nav);
-        'title' => $name,
-      ));
   }
 
 }

src/applications/config/controller/PhabricatorConfigWelcomeController.php

@@ -18,11 +18,9 @@ final class PhabricatorConfigWelcomeController
     $nav->setCrumbs($crumbs);
     $nav->appendChild($this->buildWelcomeScreen($request));
 
-    return $this->buildApplicationPage(
+    return $this->newPage()
-      $nav,
+      ->setTitle($title)
-      array(
+      ->appendChild($nav);
-        'title' => $title,
-      ));
   }
 
   public function buildWelcomeScreen(AphrontRequest $request) {