From 83dc10f6ac4b4665d959d5b88a22d959a7b55493 Mon Sep 17 00:00:00 2001
From: Chad Little <chad@chadsdomain.com>
Date: Fri, 2 May 2014 14:25:58 -0700
Subject: [PATCH] Fix minor design nits, Herald

Summary:
 - Personal Rules display like globals
 - Remove "boxy" look around transcripts
 - Fix Property list widths, breaks, on mobile
 - Add proper blank state for no actions

Test Plan: Tested Herald on mobile and desktop, used simulator in Chrome

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D8958
---
 resources/celerity/map.php                             | 10 +++++-----
 .../herald/controller/HeraldRuleListController.php     |  1 +
 .../controller/HeraldTranscriptListController.php      |  8 +-------
 webroot/rsrc/css/phui/phui-object-item-list-view.css   |  9 +++++++++
 webroot/rsrc/css/phui/phui-property-list-view.css      |  7 ++++---
 5 files changed, 20 insertions(+), 15 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 0d4fe61a2c..be128c0a72 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
 return array(
   'names' =>
   array(
-    'core.pkg.css' => 'f6bd0a00',
+    'core.pkg.css' => 'afe6e16d',
     'core.pkg.js' => '417722ff',
     'darkconsole.pkg.js' => 'ca8671ce',
     'differential.pkg.css' => '4b8686e3',
@@ -137,9 +137,9 @@ return array(
     'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
     'rsrc/css/phui/phui-list.css' => 'ef8035b6',
     'rsrc/css/phui/phui-object-box.css' => 'ce92d8ec',
-    'rsrc/css/phui/phui-object-item-list-view.css' => '574faec3',
+    'rsrc/css/phui/phui-object-item-list-view.css' => '24444832',
     'rsrc/css/phui/phui-pinboard-view.css' => '4b346c2a',
-    'rsrc/css/phui/phui-property-list-view.css' => 'c4d44192',
+    'rsrc/css/phui/phui-property-list-view.css' => 'af4b381f',
     'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b',
     'rsrc/css/phui/phui-spacing.css' => '042804d6',
     'rsrc/css/phui/phui-status.css' => '2f562399',
@@ -761,9 +761,9 @@ return array(
     'phui-info-panel-css' => '27ea50a1',
     'phui-list-view-css' => 'ef8035b6',
     'phui-object-box-css' => 'ce92d8ec',
-    'phui-object-item-list-view-css' => '574faec3',
+    'phui-object-item-list-view-css' => '24444832',
     'phui-pinboard-view-css' => '4b346c2a',
-    'phui-property-list-view-css' => 'c4d44192',
+    'phui-property-list-view-css' => 'af4b381f',
     'phui-remarkup-preview-css' => '19ad512b',
     'phui-spacing-css' => '042804d6',
     'phui-status-list-view-css' => '2f562399',
diff --git a/src/applications/herald/controller/HeraldRuleListController.php b/src/applications/herald/controller/HeraldRuleListController.php
index 7ef7a8faf8..40f8080ada 100644
--- a/src/applications/herald/controller/HeraldRuleListController.php
+++ b/src/applications/herald/controller/HeraldRuleListController.php
@@ -47,6 +47,7 @@ final class HeraldRuleListController extends HeraldController
         ->setHref($this->getApplicationURI("rule/{$id}/"));
 
       if ($rule->isPersonalRule()) {
+        $item->addIcon('user', pht('Personal Rule'));
         $item->addByline(
           pht(
             'Authored by %s',
diff --git a/src/applications/herald/controller/HeraldTranscriptListController.php b/src/applications/herald/controller/HeraldTranscriptListController.php
index f3a108177f..e77c7be30e 100644
--- a/src/applications/herald/controller/HeraldTranscriptListController.php
+++ b/src/applications/herald/controller/HeraldTranscriptListController.php
@@ -64,7 +64,6 @@ final class HeraldTranscriptListController extends HeraldController
 
     $list = new PHUIObjectItemListView();
     $list->setCards(true);
-    $list->setFlush(true);
     foreach ($transcripts as $xscript) {
       $view_href = phutil_tag(
         'a',
@@ -89,12 +88,7 @@ final class HeraldTranscriptListController extends HeraldController
       $list->addItem($item);
     }
 
-    // Render the whole page.
-    $box = new PHUIObjectBoxView();
-    $box->setHeaderText(pht('Herald Transcripts'));
-    $box->appendChild($list);
-
-    return $box;
+    return $list;
 
   }
 
diff --git a/webroot/rsrc/css/phui/phui-object-item-list-view.css b/webroot/rsrc/css/phui/phui-object-item-list-view.css
index b7fece3626..44d60f5362 100644
--- a/webroot/rsrc/css/phui/phui-object-item-list-view.css
+++ b/webroot/rsrc/css/phui/phui-object-item-list-view.css
@@ -271,6 +271,10 @@
   background: #fff;
 }
 
+.device-phone .phui-object-item-with-1-actions .phui-object-icon-pane {
+  right: 25px;
+}
+
 .device-desktop .phui-object-item-with-icons
   .phui-object-item-content,
 .device-desktop .phui-object-item-with-handle-icons
@@ -624,6 +628,11 @@
   padding: 0;
 }
 
+.phui-object-list-states .aphront-error-view {
+  margin: 0;
+  border: none;
+}
+
 .phui-object-box .phui-object-list-states li:last-child .phui-object-item-frame {
   border: none;
   padding-bottom: 0;
diff --git a/webroot/rsrc/css/phui/phui-property-list-view.css b/webroot/rsrc/css/phui/phui-property-list-view.css
index 9068c3b9d8..63dd032a6a 100644
--- a/webroot/rsrc/css/phui/phui-property-list-view.css
+++ b/webroot/rsrc/css/phui/phui-property-list-view.css
@@ -61,7 +61,7 @@
   padding-left: 12px;
   text-align: left;
   margin-left: 0;
-  width: 100%;
+  width: auto;
 }
 
 .phui-property-list-value {
@@ -79,9 +79,10 @@
 .device .phui-property-list-value,
 .phui-property-list-properties.phui-property-list-stacked
   .phui-property-list-value {
-  padding-left: 16px;
+  padding: 0 16px;
   margin-bottom: 8px;
-  width: 100%;
+  width: auto;
+  word-break: break-word;
 }
 
 .phui-property-list-section-header {