revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-30 02:32:42 +01:00
Code Issues Releases Wiki Activity

Use text, not icons, to indicate content sources

Browse source 
Summary:
oh god everyone hates this

revert revert

https://www.facebook.com/photo.php?fbid=787360256660&set=p.787360256660&type=1&theater

(I left the icons themselves since I have some plans to do other things with
them.)

Test Plan: I am not good at designer

Reviewers: ola, elynde, bh, ashwin, jungejason, kdelong, zrait, tomo, aran

Reviewed By: aran

CC: aran, epriestley, tomo

Differential Revision: 885
This commit is contained in:
epriestley 2011-09-01 09:35:35 -07:00
parent a1d1c69506
commit 83f1140785
3 changed files with 8 additions and 36 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/__celerity_resource_map__.php
View file

@ -1180,7 +1180,7 @@ celerity_register_resource_map(array(
), ),
'phabricator-content-source-view-css' => 'phabricator-content-source-view-css' =>
array( array(
'uri' => '/res/7147f14c/rsrc/css/application/contentsource/content-source-view.css', 'uri' => '/res/361cae20/rsrc/css/application/contentsource/content-source-view.css',
'type' => 'css', 'type' => 'css',
'requires' => 'requires' =>
array( array(

17
src/applications/metamta/contentsource/view/PhabricatorContentSourceView.php
View file

@ -35,13 +35,12 @@ final class PhabricatorContentSourceView extends AphrontView {
public function render() { public function render() {
require_celerity_resource('phabricator-content-source-view-css'); require_celerity_resource('phabricator-content-source-view-css');
$type = null;
$map = array( $map = array(
PhabricatorContentSource::SOURCE_WEB => 'web', PhabricatorContentSource::SOURCE_WEB => 'Web',
PhabricatorContentSource::SOURCE_CONDUIT => 'conduit', PhabricatorContentSource::SOURCE_CONDUIT => 'Conduit',
PhabricatorContentSource::SOURCE_EMAIL => 'email', PhabricatorContentSource::SOURCE_EMAIL => 'Email',
PhabricatorContentSource::SOURCE_MOBILE => 'mobile', PhabricatorContentSource::SOURCE_MOBILE => 'Mobile',
PhabricatorContentSource::SOURCE_TABLET => 'tablet', PhabricatorContentSource::SOURCE_TABLET => 'Tablet',
); );
$source = $this->contentSource->getSource(); $source = $this->contentSource->getSource();
@ -51,14 +50,12 @@ final class PhabricatorContentSourceView extends AphrontView {
return; return;
} }
$type_class = 'phabricator-content-source-'.$type;
return phutil_render_tag( return phutil_render_tag(
'span', 'span',
array( array(
'class' => "phabricator-content-source-view {$type_class}", 'class' => "phabricator-content-source-view",
), ),
'Via'); "Via {$type}");
} }
} }

25
webroot/rsrc/css/application/contentsource/content-source-view.css
View file

@ -3,30 +3,5 @@
*/ */
.phabricator-content-source-view { .phabricator-content-source-view {
padding: 2px 20px 2px 0;
font-size: 11px;
color: #888888; color: #888888;
font-weight: normal;
background: no-repeat right center;
position: relative;
}
.phabricator-content-source-web {
background-image: url(/rsrc/image/icon/fatcow/source/web.png);
}
.phabricator-content-source-email {
background-image: url(/rsrc/image/icon/fatcow/source/email.png);
}
.phabricator-content-source-conduit {
background-image: url(/rsrc/image/icon/fatcow/source/conduit.png);
}
.phabricator-content-source-mobile {
background-image: url(/rsrc/image/icon/fatcow/source/mobile.png);
}
.phabricator-content-source-tablet {
background-image: url(/rsrc/image/icon/fatcow/source/tablet.png);
} }