From 84049e6d075b8ae91de9bac4b3848f476789d61c Mon Sep 17 00:00:00 2001 From: Chad Little Date: Mon, 27 Jul 2015 15:12:03 -0700 Subject: [PATCH] Fix public/private profile edit note Summary: Fixes T8976. Checks state of note before applying to box. Test Plan: Set policy to login, edit profile. Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T8976 Differential Revision: https://secure.phabricator.com/D13739 --- .../controller/PhabricatorPeopleProfileEditController.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/applications/people/controller/PhabricatorPeopleProfileEditController.php b/src/applications/people/controller/PhabricatorPeopleProfileEditController.php index 65bf9df0d5..f53278b536 100644 --- a/src/applications/people/controller/PhabricatorPeopleProfileEditController.php +++ b/src/applications/people/controller/PhabricatorPeopleProfileEditController.php @@ -84,10 +84,13 @@ final class PhabricatorPeopleProfileEditController $form_box = id(new PHUIObjectBoxView()) ->setHeaderText(pht('Edit Profile')) - ->setInfoView($note) ->setValidationException($validation_exception) ->setForm($form); + if ($note) { + $form_box->setInfoView($note); + } + $nav = $this->buildIconNavView($user); $nav->selectFilter('/'); $nav->appendChild($form_box);