diff --git a/src/applications/countdown/view/PhabricatorCountdownView.php b/src/applications/countdown/view/PhabricatorCountdownView.php index 11f43825dd..7ede4ef887 100644 --- a/src/applications/countdown/view/PhabricatorCountdownView.php +++ b/src/applications/countdown/view/PhabricatorCountdownView.php @@ -17,7 +17,7 @@ final class PhabricatorCountdownView extends AphrontTagView { } - public function getTagContent() { + protected function getTagContent() { $countdown = $this->countdown; require_celerity_resource('phabricator-countdown-css'); diff --git a/src/applications/diviner/view/DivinerBookItemView.php b/src/applications/diviner/view/DivinerBookItemView.php index b396dcc5d1..227a791308 100644 --- a/src/applications/diviner/view/DivinerBookItemView.php +++ b/src/applications/diviner/view/DivinerBookItemView.php @@ -27,18 +27,18 @@ final class DivinerBookItemView extends AphrontTagView { return $this; } - public function getTagName() { + protected function getTagName() { return 'a'; } - public function getTagAttributes() { + protected function getTagAttributes() { return array( 'class' => 'diviner-book-item', 'href' => $this->href, ); } - public function getTagContent() { + protected function getTagContent() { require_celerity_resource('diviner-shared-css'); $title = phutil_tag( diff --git a/src/applications/diviner/view/DivinerParameterTableView.php b/src/applications/diviner/view/DivinerParameterTableView.php index f5eaddbfd6..fbb150e884 100644 --- a/src/applications/diviner/view/DivinerParameterTableView.php +++ b/src/applications/diviner/view/DivinerParameterTableView.php @@ -15,17 +15,17 @@ final class DivinerParameterTableView extends AphrontTagView { return $this; } - public function getTagName() { + protected function getTagName() { return 'div'; } - public function getTagAttributes() { + protected function getTagAttributes() { return array( 'class' => 'diviner-table-view', ); } - public function getTagContent() { + protected function getTagContent() { require_celerity_resource('diviner-shared-css'); $rows = array(); diff --git a/src/applications/diviner/view/DivinerReturnTableView.php b/src/applications/diviner/view/DivinerReturnTableView.php index fa1f450200..ff89024236 100644 --- a/src/applications/diviner/view/DivinerReturnTableView.php +++ b/src/applications/diviner/view/DivinerReturnTableView.php @@ -15,17 +15,17 @@ final class DivinerReturnTableView extends AphrontTagView { return $this; } - public function getTagName() { + protected function getTagName() { return 'div'; } - public function getTagAttributes() { + protected function getTagAttributes() { return array( 'class' => 'diviner-table-view', ); } - public function getTagContent() { + protected function getTagContent() { require_celerity_resource('diviner-shared-css'); $return = $this->return; diff --git a/src/applications/diviner/view/DivinerSectionView.php b/src/applications/diviner/view/DivinerSectionView.php index 0f48858db6..f12fb01fab 100644 --- a/src/applications/diviner/view/DivinerSectionView.php +++ b/src/applications/diviner/view/DivinerSectionView.php @@ -15,17 +15,17 @@ final class DivinerSectionView extends AphrontTagView { return $this; } - public function getTagName() { + protected function getTagName() { return 'div'; } - public function getTagAttributes() { + protected function getTagAttributes() { return array( 'class' => 'diviner-document-section', ); } - public function getTagContent() { + protected function getTagContent() { require_celerity_resource('diviner-shared-css'); $header = id(new PHUIHeaderView()) diff --git a/src/view/form/PHUIPagedFormView.php b/src/view/form/PHUIPagedFormView.php index 11b1db9441..ee40c3d496 100644 --- a/src/view/form/PHUIPagedFormView.php +++ b/src/view/form/PHUIPagedFormView.php @@ -220,7 +220,7 @@ final class PHUIPagedFormView extends AphrontTagView { return $this->cancelURI; } - public function getTagContent() { + protected function getTagContent() { $form = id(new AphrontFormView()) ->setUser($this->getUser()); diff --git a/src/view/phui/PHUIBoxView.php b/src/view/phui/PHUIBoxView.php index 4a0653a3ab..bc805515f0 100644 --- a/src/view/phui/PHUIBoxView.php +++ b/src/view/phui/PHUIBoxView.php @@ -37,11 +37,11 @@ final class PHUIBoxView extends AphrontTagView { return array('class' => $outer_classes); } - public function getTagName() { + protected function getTagName() { return 'div'; } - public function getTagContent() { + protected function getTagContent() { return $this->renderChildren(); } } diff --git a/src/view/phui/PHUIButtonBarView.php b/src/view/phui/PHUIButtonBarView.php index 861ea34ebf..ad4fd21665 100644 --- a/src/view/phui/PHUIButtonBarView.php +++ b/src/view/phui/PHUIButtonBarView.php @@ -13,11 +13,11 @@ final class PHUIButtonBarView extends AphrontTagView { return array('class' => 'phui-button-bar'); } - public function getTagName() { + protected function getTagName() { return 'div'; } - public function getTagContent() { + protected function getTagContent() { require_celerity_resource('phui-button-css'); $i = 1; diff --git a/src/view/phui/PHUIButtonView.php b/src/view/phui/PHUIButtonView.php index e0019f7edf..5de56909d2 100644 --- a/src/view/phui/PHUIButtonView.php +++ b/src/view/phui/PHUIButtonView.php @@ -82,7 +82,7 @@ final class PHUIButtonView extends AphrontTagView { return $this; } - public function getTagName() { + protected function getTagName() { return $this->tag; } diff --git a/src/view/phui/PHUIDocumentView.php b/src/view/phui/PHUIDocumentView.php index 60f099730b..d043da1e17 100644 --- a/src/view/phui/PHUIDocumentView.php +++ b/src/view/phui/PHUIDocumentView.php @@ -57,7 +57,7 @@ final class PHUIDocumentView extends AphrontTagView { return $this; } - public function getTagAttributes() { + protected function getTagAttributes() { $classes = array(); if ($this->offset) { @@ -69,7 +69,7 @@ final class PHUIDocumentView extends AphrontTagView { ); } - public function getTagContent() { + protected function getTagContent() { require_celerity_resource('phui-document-view-css'); if ($this->fontKit) { require_celerity_resource('phui-fontkit-css'); diff --git a/src/view/phui/PHUIIconView.php b/src/view/phui/PHUIIconView.php index 4f8ab8c871..0314c86c26 100644 --- a/src/view/phui/PHUIIconView.php +++ b/src/view/phui/PHUIIconView.php @@ -56,7 +56,7 @@ final class PHUIIconView extends AphrontTagView { return $this; } - public function getTagName() { + protected function getTagName() { $tag = 'span'; if ($this->href) { $tag = 'a'; @@ -64,7 +64,7 @@ final class PHUIIconView extends AphrontTagView { return $tag; } - public function getTagAttributes() { + protected function getTagAttributes() { require_celerity_resource('phui-icon-view-css'); $style = null; diff --git a/src/view/phui/PHUIImageMaskView.php b/src/view/phui/PHUIImageMaskView.php index 44233db93c..6d899841c3 100644 --- a/src/view/phui/PHUIImageMaskView.php +++ b/src/view/phui/PHUIImageMaskView.php @@ -41,11 +41,11 @@ final class PHUIImageMaskView extends AphrontTagView { return $this; } - public function getTagName() { + protected function getTagName() { return 'div'; } - public function getTagAttributes() { + protected function getTagAttributes() { require_celerity_resource('phui-image-mask-css'); $classes = array(); @@ -62,7 +62,7 @@ final class PHUIImageMaskView extends AphrontTagView { } - public function getTagContent() { + protected function getTagContent() { /* Center it in the middle of the selected area */ $center_x = round($this->centerX + ($this->maskW / 2)); diff --git a/src/view/phui/PHUIListView.php b/src/view/phui/PHUIListView.php index 3a7e9bd831..1d67b1b241 100644 --- a/src/view/phui/PHUIListView.php +++ b/src/view/phui/PHUIListView.php @@ -166,7 +166,7 @@ final class PHUIListView extends AphrontTagView { } } - public function getTagName() { + protected function getTagName() { return 'ul'; } diff --git a/src/view/phui/PHUIObjectItemView.php b/src/view/phui/PHUIObjectItemView.php index 389e2c1c81..82a39a3cb0 100644 --- a/src/view/phui/PHUIObjectItemView.php +++ b/src/view/phui/PHUIObjectItemView.php @@ -307,7 +307,7 @@ final class PHUIObjectItemView extends AphrontTagView { ); } - public function getTagContent() { + protected function getTagContent() { $content_classes = array(); $content_classes[] = 'phui-object-item-content'; diff --git a/src/view/phui/PHUIRemarkupPreviewPanel.php b/src/view/phui/PHUIRemarkupPreviewPanel.php index 91ad7a4be4..8fa02f983c 100644 --- a/src/view/phui/PHUIRemarkupPreviewPanel.php +++ b/src/view/phui/PHUIRemarkupPreviewPanel.php @@ -50,11 +50,11 @@ final class PHUIRemarkupPreviewPanel extends AphrontTagView { return $this; } - public function getTagName() { + protected function getTagName() { return 'div'; } - public function getTagAttributes() { + protected function getTagAttributes() { $classes = array(); $classes[] = 'phui-remarkup-preview'; diff --git a/src/view/phui/PHUIStatusListView.php b/src/view/phui/PHUIStatusListView.php index 9200da4531..433efc9610 100644 --- a/src/view/phui/PHUIStatusListView.php +++ b/src/view/phui/PHUIStatusListView.php @@ -13,7 +13,7 @@ final class PHUIStatusListView extends AphrontTagView { return false; } - public function getTagName() { + protected function getTagName() { return 'table'; } diff --git a/src/view/phui/PHUITagView.php b/src/view/phui/PHUITagView.php index b85ebcc902..afca3a445e 100644 --- a/src/view/phui/PHUITagView.php +++ b/src/view/phui/PHUITagView.php @@ -142,7 +142,7 @@ final class PHUITagView extends AphrontTagView { return $attributes + array('class' => $classes); } - public function getTagContent() { + protected function getTagContent() { if (!$this->type) { throw new Exception(pht('You must call setType() before render()!')); } diff --git a/src/view/phui/PHUITextView.php b/src/view/phui/PHUITextView.php index d34883027e..e075e1f205 100644 --- a/src/view/phui/PHUITextView.php +++ b/src/view/phui/PHUITextView.php @@ -9,11 +9,11 @@ final class PHUITextView extends AphrontTagView { return $this; } - public function getTagName() { + protected function getTagName() { return 'span'; } - public function getTagAttributes() { + protected function getTagAttributes() { require_celerity_resource('phui-text-css'); return array(); } diff --git a/src/view/phui/PHUIWorkboardView.php b/src/view/phui/PHUIWorkboardView.php index 948d1c5740..04a0941d70 100644 --- a/src/view/phui/PHUIWorkboardView.php +++ b/src/view/phui/PHUIWorkboardView.php @@ -27,13 +27,13 @@ final class PHUIWorkboardView extends AphrontTagView { return $this; } - public function getTagAttributes() { + protected function getTagAttributes() { return array( 'class' => 'phui-workboard-view', ); } - public function getTagContent() { + protected function getTagContent() { require_celerity_resource('phui-workboard-view-css'); $action_list = null; diff --git a/src/view/phui/PHUIWorkpanelView.php b/src/view/phui/PHUIWorkpanelView.php index 967ebd1d2c..6c2273f126 100644 --- a/src/view/phui/PHUIWorkpanelView.php +++ b/src/view/phui/PHUIWorkpanelView.php @@ -55,13 +55,13 @@ final class PHUIWorkpanelView extends AphrontTagView { return $this; } - public function getTagAttributes() { + protected function getTagAttributes() { return array( 'class' => 'phui-workpanel-view', ); } - public function getTagContent() { + protected function getTagContent() { require_celerity_resource('phui-workpanel-view-css'); $classes = array(); diff --git a/src/view/phui/calendar/PHUICalendarListView.php b/src/view/phui/calendar/PHUICalendarListView.php index 953abc6d1a..b337efb0b4 100644 --- a/src/view/phui/calendar/PHUICalendarListView.php +++ b/src/view/phui/calendar/PHUICalendarListView.php @@ -15,11 +15,11 @@ final class PHUICalendarListView extends AphrontTagView { return $this; } - public function getTagName() { + protected function getTagName() { return 'div'; } - public function getTagAttributes() { + protected function getTagAttributes() { require_celerity_resource('phui-calendar-css'); require_celerity_resource('phui-calendar-list-css'); return array('class' => 'phui-calendar-day-list'); diff --git a/src/view/phui/calendar/PHUICalendarWidgetView.php b/src/view/phui/calendar/PHUICalendarWidgetView.php index 1f294abebd..d5e1d2d24a 100644 --- a/src/view/phui/calendar/PHUICalendarWidgetView.php +++ b/src/view/phui/calendar/PHUICalendarWidgetView.php @@ -15,11 +15,11 @@ final class PHUICalendarWidgetView extends AphrontTagView { return $this; } - public function getTagName() { + protected function getTagName() { return 'div'; } - public function getTagAttributes() { + protected function getTagAttributes() { require_celerity_resource('phui-calendar-list-css'); return array('class' => 'phui-calendar-list-container'); }