revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-16 16:58:38 +01:00
Code Issues Releases Wiki Activity

Don't open symbols on double click

Browse source 
Summary:
My average double click speed is 10 ms but I tried to double click as I think normal people double clicks and it was around 200 ms.
I don't want to make the timeout much longer because it looks like that something doesn't work.

Test Plan:
Double clicked on symbol.
Clicked on symbol.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3509
This commit is contained in:
vrana 2012-09-17 14:50:49 -07:00
parent e4703c6c96
commit 8481f7ef09
3 changed files with 98 additions and 73 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
externals/javelin vendored

@ -1 +1 @@
Subproject commit 6ad17a59326690ed11c4b72c506a6218e438cad9 Subproject commit a875df7b8fa43e43602fec93fa8d34f1d104fb87

120
src/__celerity_resource_map__.php
View file

@ -65,8 +65,8 @@ celerity_register_resource_map(array(
), ),
'/rsrc/image/autosprite.png' => '/rsrc/image/autosprite.png' =>
array( array(
'hash' => '0b78a23fb4cec90e3a35ba1b9ce20f0c', 'hash' => '7b29558c2c67f5e667cc51b380a1795e',
'uri' => '/res/0b78a23f/rsrc/image/autosprite.png', 'uri' => '/res/7b29558c/rsrc/image/autosprite.png',
'disk' => '/rsrc/image/autosprite.png', 'disk' => '/rsrc/image/autosprite.png',
'type' => 'png', 'type' => 'png',
), ),
@ -671,7 +671,7 @@ celerity_register_resource_map(array(
), ),
'autosprite-css' => 'autosprite-css' =>
array( array(
'uri' => '/res/cb9c82fd/rsrc/css/autosprite.css', 'uri' => '/res/c6a807c2/rsrc/css/autosprite.css',
'type' => 'css', 'type' => 'css',
'requires' => 'requires' =>
array( array(
@ -1702,13 +1702,14 @@ celerity_register_resource_map(array(
), ),
'javelin-behavior-repository-crossreference' => 'javelin-behavior-repository-crossreference' =>
array( array(
'uri' => '/res/6a59668a/rsrc/js/application/repository/repository-crossreference.js', 'uri' => '/res/244c5251/rsrc/js/application/repository/repository-crossreference.js',
'type' => 'js', 'type' => 'js',
'requires' => 'requires' =>
array( array(
0 => 'javelin-behavior', 0 => 'javelin-behavior',
1 => 'javelin-dom', 1 => 'javelin-dom',
2 => 'javelin-uri', 2 => 'javelin-stratcom',
3 => 'javelin-uri',
), ),
'disk' => '/rsrc/js/application/repository/repository-crossreference.js', 'disk' => '/rsrc/js/application/repository/repository-crossreference.js',
), ),
@ -1821,7 +1822,7 @@ celerity_register_resource_map(array(
), ),
'javelin-fx' => 'javelin-fx' =>
array( array(
'uri' => '/res/97e25a7f/rsrc/js/javelin/ext/fx/FX.js', 'uri' => '/res/30ef0914/rsrc/js/javelin/ext/fx/FX.js',
'type' => 'js', 'type' => 'js',
'requires' => 'requires' =>
array( array(
@ -1867,7 +1868,7 @@ celerity_register_resource_map(array(
), ),
'javelin-magical-init' => 'javelin-magical-init' =>
array( array(
'uri' => '/res/caa86a45/rsrc/js/javelin/core/init.js', 'uri' => '/res/4f3c705c/rsrc/js/javelin/core/init.js',
'type' => 'js', 'type' => 'js',
'requires' => 'requires' =>
array( array(
@ -1938,7 +1939,7 @@ celerity_register_resource_map(array(
), ),
'javelin-request' => 'javelin-request' =>
array( array(
'uri' => '/res/f256e263/rsrc/js/javelin/lib/Request.js', 'uri' => '/res/6350e673/rsrc/js/javelin/lib/Request.js',
'type' => 'js', 'type' => 'js',
'requires' => 'requires' =>
array( array(
@ -1953,7 +1954,7 @@ celerity_register_resource_map(array(
), ),
'javelin-resource' => 'javelin-resource' =>
array( array(
'uri' => '/res/0058cd36/rsrc/js/javelin/lib/Resource.js', 'uri' => '/res/d5a3f835/rsrc/js/javelin/lib/Resource.js',
'type' => 'js', 'type' => 'js',
'requires' => 'requires' =>
array( array(
@ -1979,7 +1980,7 @@ celerity_register_resource_map(array(
), ),
'javelin-tokenizer' => 'javelin-tokenizer' =>
array( array(
'uri' => '/res/a8275d0d/rsrc/js/javelin/lib/control/tokenizer/Tokenizer.js', 'uri' => '/res/a10ae640/rsrc/js/javelin/lib/control/tokenizer/Tokenizer.js',
'type' => 'js', 'type' => 'js',
'requires' => 'requires' =>
array( array(
@ -1992,7 +1993,7 @@ celerity_register_resource_map(array(
), ),
'javelin-typeahead' => 'javelin-typeahead' =>
array( array(
'uri' => '/res/2f694700/rsrc/js/javelin/lib/control/typeahead/Typeahead.js', 'uri' => '/res/ba188749/rsrc/js/javelin/lib/control/typeahead/Typeahead.js',
'type' => 'js', 'type' => 'js',
'requires' => 'requires' =>
array( array(
@ -2055,7 +2056,7 @@ celerity_register_resource_map(array(
), ),
'javelin-typeahead-source' => 'javelin-typeahead-source' =>
array( array(
'uri' => '/res/83bf292a/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadSource.js', 'uri' => '/res/74b1f091/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadSource.js',
'type' => 'js', 'type' => 'js',
'requires' => 'requires' =>
array( array(
@ -2066,9 +2067,20 @@ celerity_register_resource_map(array(
), ),
'disk' => '/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadSource.js', 'disk' => '/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadSource.js',
), ),
'javelin-typeahead-static-source' =>
array(
'uri' => '/res/c8e247fc/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-typeahead-source',
),
'disk' => '/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js',
),
'javelin-uri' => 'javelin-uri' =>
array( array(
'uri' => '/res/393ace00/rsrc/js/javelin/lib/URI.js', 'uri' => '/res/8c7cb610/rsrc/js/javelin/lib/URI.js',
'type' => 'js', 'type' => 'js',
'requires' => 'requires' =>
array( array(
@ -2080,7 +2092,7 @@ celerity_register_resource_map(array(
), ),
'javelin-util' => 'javelin-util' =>
array( array(
'uri' => '/res/2180bc95/rsrc/js/javelin/core/util.js', 'uri' => '/res/25786b6c/rsrc/js/javelin/core/util.js',
'type' => 'js', 'type' => 'js',
'requires' => 'requires' =>
array( array(
@ -3034,7 +3046,7 @@ celerity_register_resource_map(array(
'uri' => '/res/pkg/2ba14b3d/differential.pkg.css', 'uri' => '/res/pkg/2ba14b3d/differential.pkg.css',
'type' => 'css', 'type' => 'css',
), ),
'670ad7f1' => '577c3e68' =>
array( array(
'name' => 'differential.pkg.js', 'name' => 'differential.pkg.js',
'symbols' => 'symbols' =>
@ -3057,7 +3069,7 @@ celerity_register_resource_map(array(
15 => 'differential-inline-comment-editor', 15 => 'differential-inline-comment-editor',
16 => 'javelin-behavior-differential-dropdown-menus', 16 => 'javelin-behavior-differential-dropdown-menus',
), ),
'uri' => '/res/pkg/670ad7f1/differential.pkg.js', 'uri' => '/res/pkg/577c3e68/differential.pkg.js',
'type' => 'js', 'type' => 'js',
), ),
'c8ce2d88' => 'c8ce2d88' =>
@ -3083,7 +3095,7 @@ celerity_register_resource_map(array(
'uri' => '/res/pkg/5e68be89/diffusion.pkg.js', 'uri' => '/res/pkg/5e68be89/diffusion.pkg.js',
'type' => 'js', 'type' => 'js',
), ),
'6fb20113' => '63e59d27' =>
array( array(
'name' => 'javelin.pkg.js', 'name' => 'javelin.pkg.js',
'symbols' => 'symbols' =>
@ -3099,7 +3111,7 @@ celerity_register_resource_map(array(
8 => 'javelin-json', 8 => 'javelin-json',
9 => 'javelin-uri', 9 => 'javelin-uri',
), ),
'uri' => '/res/pkg/6fb20113/javelin.pkg.js', 'uri' => '/res/pkg/63e59d27/javelin.pkg.js',
'type' => 'js', 'type' => 'js',
), ),
'7839ae2d' => '7839ae2d' =>
@ -3129,7 +3141,7 @@ celerity_register_resource_map(array(
'uri' => '/res/pkg/7707de41/maniphest.pkg.js', 'uri' => '/res/pkg/7707de41/maniphest.pkg.js',
'type' => 'js', 'type' => 'js',
), ),
'97f65640' => '81c9cd69' =>
array( array(
'name' => 'typeahead.pkg.js', 'name' => 'typeahead.pkg.js',
'symbols' => 'symbols' =>
@ -3142,7 +3154,7 @@ celerity_register_resource_map(array(
5 => 'javelin-tokenizer', 5 => 'javelin-tokenizer',
6 => 'javelin-behavior-aphront-basic-tokenizer', 6 => 'javelin-behavior-aphront-basic-tokenizer',
), ),
'uri' => '/res/pkg/97f65640/typeahead.pkg.js', 'uri' => '/res/pkg/81c9cd69/typeahead.pkg.js',
'type' => 'js', 'type' => 'js',
), ),
), ),
@ -3165,7 +3177,7 @@ celerity_register_resource_map(array(
'aphront-typeahead-control-css' => '1db83c80', 'aphront-typeahead-control-css' => '1db83c80',
'differential-changeset-view-css' => '2ba14b3d', 'differential-changeset-view-css' => '2ba14b3d',
'differential-core-view-css' => '2ba14b3d', 'differential-core-view-css' => '2ba14b3d',
'differential-inline-comment-editor' => '670ad7f1', 'differential-inline-comment-editor' => '577c3e68',
'differential-local-commits-view-css' => '2ba14b3d', 'differential-local-commits-view-css' => '2ba14b3d',
'differential-results-table-css' => '2ba14b3d', 'differential-results-table-css' => '2ba14b3d',
'differential-revision-add-comment-css' => '2ba14b3d', 'differential-revision-add-comment-css' => '2ba14b3d',
@ -3177,22 +3189,22 @@ celerity_register_resource_map(array(
'diffusion-commit-view-css' => 'c8ce2d88', 'diffusion-commit-view-css' => 'c8ce2d88',
'diffusion-icons-css' => 'c8ce2d88', 'diffusion-icons-css' => 'c8ce2d88',
'inline-comment-summary-css' => '2ba14b3d', 'inline-comment-summary-css' => '2ba14b3d',
'javelin-behavior' => '6fb20113', 'javelin-behavior' => '63e59d27',
'javelin-behavior-aphront-basic-tokenizer' => '97f65640', 'javelin-behavior-aphront-basic-tokenizer' => '81c9cd69',
'javelin-behavior-aphront-drag-and-drop' => '670ad7f1', 'javelin-behavior-aphront-drag-and-drop' => '577c3e68',
'javelin-behavior-aphront-drag-and-drop-textarea' => '670ad7f1', 'javelin-behavior-aphront-drag-and-drop-textarea' => '577c3e68',
'javelin-behavior-aphront-form-disable-on-submit' => '3a455e4f', 'javelin-behavior-aphront-form-disable-on-submit' => '3a455e4f',
'javelin-behavior-audit-preview' => '5e68be89', 'javelin-behavior-audit-preview' => '5e68be89',
'javelin-behavior-differential-accept-with-errors' => '670ad7f1', 'javelin-behavior-differential-accept-with-errors' => '577c3e68',
'javelin-behavior-differential-add-reviewers-and-ccs' => '670ad7f1', 'javelin-behavior-differential-add-reviewers-and-ccs' => '577c3e68',
'javelin-behavior-differential-comment-jump' => '670ad7f1', 'javelin-behavior-differential-comment-jump' => '577c3e68',
'javelin-behavior-differential-diff-radios' => '670ad7f1', 'javelin-behavior-differential-diff-radios' => '577c3e68',
'javelin-behavior-differential-dropdown-menus' => '670ad7f1', 'javelin-behavior-differential-dropdown-menus' => '577c3e68',
'javelin-behavior-differential-edit-inline-comments' => '670ad7f1', 'javelin-behavior-differential-edit-inline-comments' => '577c3e68',
'javelin-behavior-differential-feedback-preview' => '670ad7f1', 'javelin-behavior-differential-feedback-preview' => '577c3e68',
'javelin-behavior-differential-keyboard-navigation' => '670ad7f1', 'javelin-behavior-differential-keyboard-navigation' => '577c3e68',
'javelin-behavior-differential-populate' => '670ad7f1', 'javelin-behavior-differential-populate' => '577c3e68',
'javelin-behavior-differential-show-more' => '670ad7f1', 'javelin-behavior-differential-show-more' => '577c3e68',
'javelin-behavior-diffusion-commit-graph' => '5e68be89', 'javelin-behavior-diffusion-commit-graph' => '5e68be89',
'javelin-behavior-diffusion-pull-lastmodified' => '5e68be89', 'javelin-behavior-diffusion-pull-lastmodified' => '5e68be89',
'javelin-behavior-maniphest-batch-selector' => '7707de41', 'javelin-behavior-maniphest-batch-selector' => '7707de41',
@ -3202,29 +3214,29 @@ celerity_register_resource_map(array(
'javelin-behavior-maniphest-transaction-preview' => '7707de41', 'javelin-behavior-maniphest-transaction-preview' => '7707de41',
'javelin-behavior-phabricator-autofocus' => '3a455e4f', 'javelin-behavior-phabricator-autofocus' => '3a455e4f',
'javelin-behavior-phabricator-keyboard-shortcuts' => '3a455e4f', 'javelin-behavior-phabricator-keyboard-shortcuts' => '3a455e4f',
'javelin-behavior-phabricator-object-selector' => '670ad7f1', 'javelin-behavior-phabricator-object-selector' => '577c3e68',
'javelin-behavior-phabricator-oncopy' => '3a455e4f', 'javelin-behavior-phabricator-oncopy' => '3a455e4f',
'javelin-behavior-phabricator-tooltips' => '3a455e4f', 'javelin-behavior-phabricator-tooltips' => '3a455e4f',
'javelin-behavior-phabricator-watch-anchor' => '3a455e4f', 'javelin-behavior-phabricator-watch-anchor' => '3a455e4f',
'javelin-behavior-refresh-csrf' => '3a455e4f', 'javelin-behavior-refresh-csrf' => '3a455e4f',
'javelin-behavior-repository-crossreference' => '670ad7f1', 'javelin-behavior-repository-crossreference' => '577c3e68',
'javelin-behavior-workflow' => '3a455e4f', 'javelin-behavior-workflow' => '3a455e4f',
'javelin-dom' => '6fb20113', 'javelin-dom' => '63e59d27',
'javelin-event' => '6fb20113', 'javelin-event' => '63e59d27',
'javelin-install' => '6fb20113', 'javelin-install' => '63e59d27',
'javelin-json' => '6fb20113', 'javelin-json' => '63e59d27',
'javelin-mask' => '3a455e4f', 'javelin-mask' => '3a455e4f',
'javelin-request' => '6fb20113', 'javelin-request' => '63e59d27',
'javelin-stratcom' => '6fb20113', 'javelin-stratcom' => '63e59d27',
'javelin-tokenizer' => '97f65640', 'javelin-tokenizer' => '81c9cd69',
'javelin-typeahead' => '97f65640', 'javelin-typeahead' => '81c9cd69',
'javelin-typeahead-normalizer' => '97f65640', 'javelin-typeahead-normalizer' => '81c9cd69',
'javelin-typeahead-ondemand-source' => '97f65640', 'javelin-typeahead-ondemand-source' => '81c9cd69',
'javelin-typeahead-preloaded-source' => '97f65640', 'javelin-typeahead-preloaded-source' => '81c9cd69',
'javelin-typeahead-source' => '97f65640', 'javelin-typeahead-source' => '81c9cd69',
'javelin-uri' => '6fb20113', 'javelin-uri' => '63e59d27',
'javelin-util' => '6fb20113', 'javelin-util' => '63e59d27',
'javelin-vector' => '6fb20113', 'javelin-vector' => '63e59d27',
'javelin-workflow' => '3a455e4f', 'javelin-workflow' => '3a455e4f',
'maniphest-task-summary-css' => '7839ae2d', 'maniphest-task-summary-css' => '7839ae2d',
'maniphest-transaction-detail-css' => '7839ae2d', 'maniphest-transaction-detail-css' => '7839ae2d',
@ -3233,7 +3245,7 @@ celerity_register_resource_map(array(
'phabricator-core-buttons-css' => '1db83c80', 'phabricator-core-buttons-css' => '1db83c80',
'phabricator-core-css' => '1db83c80', 'phabricator-core-css' => '1db83c80',
'phabricator-directory-css' => '1db83c80', 'phabricator-directory-css' => '1db83c80',
'phabricator-drag-and-drop-file-upload' => '670ad7f1', 'phabricator-drag-and-drop-file-upload' => '577c3e68',
'phabricator-dropdown-menu' => '3a455e4f', 'phabricator-dropdown-menu' => '3a455e4f',
'phabricator-flag-css' => '1db83c80', 'phabricator-flag-css' => '1db83c80',
'phabricator-jump-nav' => '1db83c80', 'phabricator-jump-nav' => '1db83c80',
@ -3245,7 +3257,7 @@ celerity_register_resource_map(array(
'phabricator-prefab' => '3a455e4f', 'phabricator-prefab' => '3a455e4f',
'phabricator-project-tag-css' => '7839ae2d', 'phabricator-project-tag-css' => '7839ae2d',
'phabricator-remarkup-css' => '1db83c80', 'phabricator-remarkup-css' => '1db83c80',
'phabricator-shaped-request' => '670ad7f1', 'phabricator-shaped-request' => '577c3e68',
'phabricator-standard-page-view' => '1db83c80', 'phabricator-standard-page-view' => '1db83c80',
'phabricator-tooltip' => '3a455e4f', 'phabricator-tooltip' => '3a455e4f',
'phabricator-transaction-view-css' => '1db83c80', 'phabricator-transaction-view-css' => '1db83c80',

49
webroot/rsrc/js/application/repository/repository-crossreference.js
View file

@ -2,6 +2,7 @@
* @provides javelin-behavior-repository-crossreference * @provides javelin-behavior-repository-crossreference
* @requires javelin-behavior * @requires javelin-behavior
* javelin-dom * javelin-dom
* javelin-stratcom
* javelin-uri * javelin-uri
*/ */
@ -11,6 +12,8 @@ JX.behavior('repository-crossreference', function(config) {
// constrained by the markup generated by the syntax highlighters. // constrained by the markup generated by the syntax highlighters.
function link(element, lang) { function link(element, lang) {
var timeout;
JX.DOM.alterClass(element, 'repository-crossreference', true); JX.DOM.alterClass(element, 'repository-crossreference', true);
JX.DOM.listen( JX.DOM.listen(
element, element,
@ -24,30 +27,40 @@ JX.behavior('repository-crossreference', function(config) {
var map = {nc : 'class', nf : 'function', na : null}; var map = {nc : 'class', nf : 'function', na : null};
while (target !== document.body) { while (target !== document.body) {
if (JX.DOM.isNode(target, 'span') && (target.className in map)) { if (JX.DOM.isNode(target, 'span') && (target.className in map)) {
var symbol = target.textContent || target.innerText; timeout = setTimeout(function() {
var query = { var symbol = target.textContent || target.innerText;
lang : lang, var query = {
projects : config.projects.join(','), lang : lang,
jump : true projects : config.projects.join(','),
}; jump : true
if (map[target.className]) { };
query.type = map[target.className]; if (map[target.className]) {
} query.type = map[target.className];
if (target.hasAttribute('data-symbol-context')) { }
query.context = target.getAttribute('data-symbol-context'); if (target.hasAttribute('data-symbol-context')) {
} query.context = target.getAttribute('data-symbol-context');
if (target.hasAttribute('data-symbol-name')) { }
symbol = target.getAttribute('data-symbol-name'); if (target.hasAttribute('data-symbol-name')) {
} symbol = target.getAttribute('data-symbol-name');
var uri = JX.$U('/diffusion/symbol/' + symbol + '/'); }
uri.addQueryParams(query); var uri = JX.$U('/diffusion/symbol/' + symbol + '/');
window.open(uri); uri.addQueryParams(query);
window.open(uri);
}, 250);
e.kill(); e.kill();
break; break;
} }
target = target.parentNode; target = target.parentNode;
} }
}); });
JX.DOM.listen(
element,
'dblclick',
'tag:span',
function(e) {
clearTimeout(timeout);
});
} }
function linkAll(section) { function linkAll(section) {