revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-15 01:01:09 +01:00
Code Issues Releases Wiki Activity

Small button dropdowns

Browse source 
Summary: Adds the small caret to differential. Cleans up dropdown frame.

Test Plan: Test caret in differential.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: Korvin, aran

Differential Revision: https://secure.phabricator.com/D6983
This commit is contained in:
Chad Little 2013-09-13 10:48:02 -07:00
parent b38a688cf7
commit 85424e7472
3 changed files with 54 additions and 49 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

88
src/__celerity_resource_map__.php
View file

@ -3738,7 +3738,7 @@ celerity_register_resource_map(array(
), ),
'phui-button-css' => 'phui-button-css' =>
array( array(
'uri' => '/res/bed5fc2c/rsrc/css/phui/phui-button.css', 'uri' => '/res/3718b375/rsrc/css/phui/phui-button.css',
'type' => 'css', 'type' => 'css',
'requires' => 'requires' =>
array( array(
@ -4171,7 +4171,7 @@ celerity_register_resource_map(array(
), array( ), array(
'packages' => 'packages' =>
array( array(
'1911a285' => '1200d176' =>
array( array(
'name' => 'core.pkg.css', 'name' => 'core.pkg.css',
'symbols' => 'symbols' =>
@ -4218,7 +4218,7 @@ celerity_register_resource_map(array(
39 => 'phabricator-property-list-view-css', 39 => 'phabricator-property-list-view-css',
40 => 'phabricator-tag-view-css', 40 => 'phabricator-tag-view-css',
), ),
'uri' => '/res/pkg/1911a285/core.pkg.css', 'uri' => '/res/pkg/1200d176/core.pkg.css',
'type' => 'css', 'type' => 'css',
), ),
'8977e356' => '8977e356' =>
@ -4409,15 +4409,15 @@ celerity_register_resource_map(array(
), ),
'reverse' => 'reverse' =>
array( array(
'aphront-dialog-view-css' => '1911a285', 'aphront-dialog-view-css' => '1200d176',
'aphront-error-view-css' => '1911a285', 'aphront-error-view-css' => '1200d176',
'aphront-list-filter-view-css' => '1911a285', 'aphront-list-filter-view-css' => '1200d176',
'aphront-pager-view-css' => '1911a285', 'aphront-pager-view-css' => '1200d176',
'aphront-panel-view-css' => '1911a285', 'aphront-panel-view-css' => '1200d176',
'aphront-table-view-css' => '1911a285', 'aphront-table-view-css' => '1200d176',
'aphront-tokenizer-control-css' => '1911a285', 'aphront-tokenizer-control-css' => '1200d176',
'aphront-tooltip-css' => '1911a285', 'aphront-tooltip-css' => '1200d176',
'aphront-typeahead-control-css' => '1911a285', 'aphront-typeahead-control-css' => '1200d176',
'differential-changeset-view-css' => '44bfe40c', 'differential-changeset-view-css' => '44bfe40c',
'differential-core-view-css' => '44bfe40c', 'differential-core-view-css' => '44bfe40c',
'differential-inline-comment-editor' => '5e9e5c4e', 'differential-inline-comment-editor' => '5e9e5c4e',
@ -4431,7 +4431,7 @@ celerity_register_resource_map(array(
'differential-table-of-contents-css' => '44bfe40c', 'differential-table-of-contents-css' => '44bfe40c',
'diffusion-commit-view-css' => 'c8ce2d88', 'diffusion-commit-view-css' => 'c8ce2d88',
'diffusion-icons-css' => 'c8ce2d88', 'diffusion-icons-css' => 'c8ce2d88',
'global-drag-and-drop-css' => '1911a285', 'global-drag-and-drop-css' => '1200d176',
'inline-comment-summary-css' => '44bfe40c', 'inline-comment-summary-css' => '44bfe40c',
'javelin-aphlict' => '8977e356', 'javelin-aphlict' => '8977e356',
'javelin-behavior' => 'f32597c9', 'javelin-behavior' => 'f32597c9',
@ -4504,55 +4504,55 @@ celerity_register_resource_map(array(
'javelin-util' => 'f32597c9', 'javelin-util' => 'f32597c9',
'javelin-vector' => 'f32597c9', 'javelin-vector' => 'f32597c9',
'javelin-workflow' => 'f32597c9', 'javelin-workflow' => 'f32597c9',
'lightbox-attachment-css' => '1911a285', 'lightbox-attachment-css' => '1200d176',
'maniphest-task-summary-css' => '0a9e494f', 'maniphest-task-summary-css' => '0a9e494f',
'maniphest-transaction-detail-css' => '0a9e494f', 'maniphest-transaction-detail-css' => '0a9e494f',
'phabricator-action-list-view-css' => '1911a285', 'phabricator-action-list-view-css' => '1200d176',
'phabricator-application-launch-view-css' => '1911a285', 'phabricator-application-launch-view-css' => '1200d176',
'phabricator-busy' => '8977e356', 'phabricator-busy' => '8977e356',
'phabricator-content-source-view-css' => '44bfe40c', 'phabricator-content-source-view-css' => '44bfe40c',
'phabricator-core-css' => '1911a285', 'phabricator-core-css' => '1200d176',
'phabricator-crumbs-view-css' => '1911a285', 'phabricator-crumbs-view-css' => '1200d176',
'phabricator-drag-and-drop-file-upload' => '5e9e5c4e', 'phabricator-drag-and-drop-file-upload' => '5e9e5c4e',
'phabricator-dropdown-menu' => '8977e356', 'phabricator-dropdown-menu' => '8977e356',
'phabricator-file-upload' => '8977e356', 'phabricator-file-upload' => '8977e356',
'phabricator-filetree-view-css' => '1911a285', 'phabricator-filetree-view-css' => '1200d176',
'phabricator-flag-css' => '1911a285', 'phabricator-flag-css' => '1200d176',
'phabricator-header-view-css' => '1911a285', 'phabricator-header-view-css' => '1200d176',
'phabricator-hovercard' => '8977e356', 'phabricator-hovercard' => '8977e356',
'phabricator-jump-nav' => '1911a285', 'phabricator-jump-nav' => '1200d176',
'phabricator-keyboard-shortcut' => '8977e356', 'phabricator-keyboard-shortcut' => '8977e356',
'phabricator-keyboard-shortcut-manager' => '8977e356', 'phabricator-keyboard-shortcut-manager' => '8977e356',
'phabricator-main-menu-view' => '1911a285', 'phabricator-main-menu-view' => '1200d176',
'phabricator-menu-item' => '8977e356', 'phabricator-menu-item' => '8977e356',
'phabricator-nav-view-css' => '1911a285', 'phabricator-nav-view-css' => '1200d176',
'phabricator-notification' => '8977e356', 'phabricator-notification' => '8977e356',
'phabricator-notification-css' => '1911a285', 'phabricator-notification-css' => '1200d176',
'phabricator-notification-menu-css' => '1911a285', 'phabricator-notification-menu-css' => '1200d176',
'phabricator-object-selector-css' => '44bfe40c', 'phabricator-object-selector-css' => '44bfe40c',
'phabricator-phtize' => '8977e356', 'phabricator-phtize' => '8977e356',
'phabricator-prefab' => '8977e356', 'phabricator-prefab' => '8977e356',
'phabricator-project-tag-css' => '0a9e494f', 'phabricator-project-tag-css' => '0a9e494f',
'phabricator-property-list-view-css' => '1911a285', 'phabricator-property-list-view-css' => '1200d176',
'phabricator-remarkup-css' => '1911a285', 'phabricator-remarkup-css' => '1200d176',
'phabricator-shaped-request' => '5e9e5c4e', 'phabricator-shaped-request' => '5e9e5c4e',
'phabricator-side-menu-view-css' => '1911a285', 'phabricator-side-menu-view-css' => '1200d176',
'phabricator-standard-page-view' => '1911a285', 'phabricator-standard-page-view' => '1200d176',
'phabricator-tag-view-css' => '1911a285', 'phabricator-tag-view-css' => '1200d176',
'phabricator-textareautils' => '8977e356', 'phabricator-textareautils' => '8977e356',
'phabricator-tooltip' => '8977e356', 'phabricator-tooltip' => '8977e356',
'phabricator-transaction-view-css' => '1911a285', 'phabricator-transaction-view-css' => '1200d176',
'phabricator-zindex-css' => '1911a285', 'phabricator-zindex-css' => '1200d176',
'phui-button-css' => '1911a285', 'phui-button-css' => '1200d176',
'phui-form-css' => '1911a285', 'phui-form-css' => '1200d176',
'phui-form-view-css' => '1911a285', 'phui-form-view-css' => '1200d176',
'phui-icon-view-css' => '1911a285', 'phui-icon-view-css' => '1200d176',
'phui-object-item-list-view-css' => '1911a285', 'phui-object-item-list-view-css' => '1200d176',
'phui-spacing-css' => '1911a285', 'phui-spacing-css' => '1200d176',
'sprite-apps-large-css' => '1911a285', 'sprite-apps-large-css' => '1200d176',
'sprite-gradient-css' => '1911a285', 'sprite-gradient-css' => '1200d176',
'sprite-icons-css' => '1911a285', 'sprite-icons-css' => '1200d176',
'sprite-menu-css' => '1911a285', 'sprite-menu-css' => '1200d176',
'syntax-highlighting-css' => '1911a285', 'syntax-highlighting-css' => '1200d176',
), ),
)); ));

5
src/applications/differential/view/DifferentialChangesetListView.php
View file

@ -311,17 +311,18 @@ final class DifferentialChangesetListView extends AphrontView {
} }
$meta['containerID'] = $detail->getID(); $meta['containerID'] = $detail->getID();
$caret = phutil_tag('span', array('class' => 'caret'), '');
return javelin_tag( return javelin_tag(
'a', 'a',
array( array(
'class' => 'button small grey', 'class' => 'button grey small dropdown',
'meta' => $meta, 'meta' => $meta,
'href' => idx($meta, 'detailURI', '#'), 'href' => idx($meta, 'detailURI', '#'),
'target' => '_blank', 'target' => '_blank',
'sigil' => 'differential-view-options', 'sigil' => 'differential-view-options',
), ),
pht('View Options') . " \xE2\x96\xBC"); array(pht('View Options'), $caret));
} }
} }

10
webroot/rsrc/css/phui/phui-button.css
View file

@ -152,8 +152,8 @@ button.link:hover {
margin-top: -1px; margin-top: -1px;
padding: 5px 0; padding: 5px 0;
box-shadow: 0px 2px 6px rgba(0, 0, 0, 0.3); box-shadow: 0px 2px 6px rgba(0, 0, 0, 0.3);
border: 1px solid #d7d7d7; border: 1px solid {$lightgreyborder};
border-radius: 3px; border-bottom-color: {$greyborder};
} }
.dropdown-menu-frame a, .dropdown-menu-frame a,
@ -224,7 +224,7 @@ a.toggle-fixed {
width: 0; width: 0;
height: 0; height: 0;
vertical-align: middle; vertical-align: middle;
border-left: 7px solid #74777D; border-left: 7px solid {$greytext};
border-top: 5px solid transparent; border-top: 5px solid transparent;
border-bottom: 5px solid transparent; border-bottom: 5px solid transparent;
content: ""; content: "";
@ -248,6 +248,10 @@ a.toggle-fixed {
margin-left: 4px; margin-left: 4px;
} }
.small.dropdown .caret {
margin-top: 6px;
}
.grey.dropdown .caret { .grey.dropdown .caret {
border-top-color: #000; border-top-color: #000;
} }