revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-28 16:30:59 +01:00
Code Issues Releases Wiki Activity

Remove click to view on ghosties

Browse source 
Summary: Ref T7447, these are more work than needed at least on an indivdual basis. JS openning all feels poor as well.

Test Plan: Review comments, past present and future.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7447

Differential Revision: https://secure.phabricator.com/D12702
This commit is contained in:
Chad Little 2015-05-04 11:59:04 -07:00
parent 460d68ba27
commit 861155ea73
3 changed files with 10 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
resources/celerity/map.php
View file

@ -10,7 +10,7 @@ return array(
'core.pkg.css' => 'ca3f6a60', 'core.pkg.css' => 'ca3f6a60',
'core.pkg.js' => '3331b919', 'core.pkg.js' => '3331b919',
'darkconsole.pkg.js' => 'e7393ebb', 'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => '0a253fbe', 'differential.pkg.css' => '13312972',
'differential.pkg.js' => '3cfa26f9', 'differential.pkg.js' => '3cfa26f9',
'diffusion.pkg.css' => '591664fa', 'diffusion.pkg.css' => '591664fa',
'diffusion.pkg.js' => '0115b37c', 'diffusion.pkg.js' => '0115b37c',
@ -58,7 +58,7 @@ return array(
'rsrc/css/application/differential/add-comment.css' => 'c47f8c40', 'rsrc/css/application/differential/add-comment.css' => 'c47f8c40',
'rsrc/css/application/differential/changeset-view.css' => 'e19cfd6e', 'rsrc/css/application/differential/changeset-view.css' => 'e19cfd6e',
'rsrc/css/application/differential/core.css' => '7ac3cabc', 'rsrc/css/application/differential/core.css' => '7ac3cabc',
'rsrc/css/application/differential/phui-inline-comment.css' => '48766bbe', 'rsrc/css/application/differential/phui-inline-comment.css' => 'df8fbd63',
'rsrc/css/application/differential/results-table.css' => '181aa9d9', 'rsrc/css/application/differential/results-table.css' => '181aa9d9',
'rsrc/css/application/differential/revision-comment.css' => '024dda6b', 'rsrc/css/application/differential/revision-comment.css' => '024dda6b',
'rsrc/css/application/differential/revision-history.css' => '0e8eb855', 'rsrc/css/application/differential/revision-history.css' => '0e8eb855',
@ -795,7 +795,7 @@ return array(
'phui-image-mask-css' => '5a8b09c8', 'phui-image-mask-css' => '5a8b09c8',
'phui-info-panel-css' => '27ea50a1', 'phui-info-panel-css' => '27ea50a1',
'phui-info-view-css' => 'c6f0aef8', 'phui-info-view-css' => 'c6f0aef8',
'phui-inline-comment-view-css' => '48766bbe', 'phui-inline-comment-view-css' => 'df8fbd63',
'phui-list-view-css' => '2e25ebfb', 'phui-list-view-css' => '2e25ebfb',
'phui-object-box-css' => '7d160002', 'phui-object-box-css' => '7d160002',
'phui-object-item-list-view-css' => '9db65899', 'phui-object-item-list-view-css' => '9db65899',

16
src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php
View file

@ -128,12 +128,11 @@ final class PHUIDiffInlineCommentDetailView
if ($ghost) { if ($ghost) {
if ($ghost['new']) { if ($ghost['new']) {
$ghosticon = 'fa-fast-forward'; $ghosticon = 'fa-fast-forward';
$reason = pht('View forward comment'); $reason = pht('View on forward revision');
} else { } else {
$ghosticon = 'fa-fast-backward'; $ghosticon = 'fa-fast-backward';
$reason = pht('View previous comment'); $reason = pht('View on previous revision');
} }
$ghost_id = celerity_generate_unique_node_id();
$ghost_icon = id(new PHUIIconView()) $ghost_icon = id(new PHUIIconView())
->setIconFont($ghosticon) ->setIconFont($ghosticon)
@ -143,16 +142,12 @@ final class PHUIDiffInlineCommentDetailView
'tip' => $reason, 'tip' => $reason,
'size' => 300, 'size' => 300,
)); ));
$ghost_tag = javelin_tag( $ghost_tag = phutil_tag(
'a', 'a',
array( array(
'class' => 'ghost-icon', 'class' => 'ghost-icon',
'sigil' => 'jx-toggle-class', 'href' => $ghost['href'],
'meta' => array( 'target' => '_blank',
'map' => array(
$ghost_id => 'ghost-is-expanded',
),
),
), ),
$ghost_icon); $ghost_icon);
$classes[] = 'inline-comment-ghost'; $classes[] = 'inline-comment-ghost';
@ -415,7 +410,6 @@ final class PHUIDiffInlineCommentDetailView
'class' => $classes, 'class' => $classes,
'sigil' => $sigil, 'sigil' => $sigil,
'meta' => $metadata, 'meta' => $metadata,
'id' => $ghost_id,
), ),
array( array(
phutil_tag_div('differential-inline-comment-head grouped', array( phutil_tag_div('differential-inline-comment-head grouped', array(

19
webroot/rsrc/css/application/differential/phui-inline-comment.css
View file

@ -47,7 +47,7 @@
font-weight: bold; font-weight: bold;
color: {$darkbluetext}; color: {$darkbluetext};
border-bottom: 1px solid {$sh-lightyellowborder}; border-bottom: 1px solid {$sh-lightyellowborder};
padding: 4px 5px 2px 12px; padding: 4px 5px 4px 12px;
background-color: {$sh-yellowbackground}; background-color: {$sh-yellowbackground};
} }
@ -415,7 +415,7 @@
} }
.ghost-icon .phui-icon-view { .ghost-icon .phui-icon-view {
padding: 7px 7px 8px; padding: 8px 7px;
font-size: 15px; font-size: 15px;
color: {$lightbluetext}; color: {$lightbluetext};
} }
@ -424,23 +424,8 @@
color: {$sky}; color: {$sky};
} }
.inline-comment-ghost .differential-inline-comment-content {
display: none;
}
.inline-comment-ghost.ghost-is-expanded .differential-inline-comment-content {
display: block;
}
.differential-inline-comment.inline-comment-ghost .differential-inline-comment.inline-comment-ghost
.differential-inline-comment-head { .differential-inline-comment-head {
border-bottom-color: transparent;
position: relative;
}
.differential-inline-comment.inline-comment-ghost.ghost-is-expanded
.differential-inline-comment-head {
border-bottom-color: {$thinblueborder};
position: relative; position: relative;
} }