revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 01:02:42 +01:00
Code Issues Releases Wiki Activity

Allow disabled users to be typeaheaded in Differential

Browse source 
Summary: Fixes T3773. By default, the `/users/` datasource excludes disabled users (since it doesn't make sense to assign them tasks or make them reviewers, for example). However, for ApplicationSearch it does make sense to look for objects, e.g., authored by a disabled user.

Test Plan: Searched for disabled users in Differential.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T3773

Differential Revision: https://secure.phabricator.com/D6834
This commit is contained in:
epriestley 2013-08-28 15:37:53 -07:00
parent 7b5471b1ae
commit 86455b8591
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/applications/differential/query/DifferentialRevisionSearchEngine.php
View file

@ -116,25 +116,25 @@ final class DifferentialRevisionSearchEngine
id(new AphrontFormTokenizerControl())
->setLabel(pht('Responsible Users'))
->setName('responsiblePHIDs')
->setDatasource('/typeahead/common/users/')
->setDatasource('/typeahead/common/accounts/')
->setValue(array_select_keys($tokens, $responsible_phids)))
->appendChild(
id(new AphrontFormTokenizerControl())
->setLabel(pht('Authors'))
->setName('authorPHIDs')
->setDatasource('/typeahead/common/authors/')
->setDatasource('/typeahead/common/accounts/')
->setValue(array_select_keys($tokens, $author_phids)))
->appendChild(
id(new AphrontFormTokenizerControl())
->setLabel(pht('Reviewers'))
->setName('reviewerPHIDs')
->setDatasource('/typeahead/common/users/')
->setDatasource('/typeahead/common/accounts/')
->setValue(array_select_keys($tokens, $reviewer_phids)))
->appendChild(
id(new AphrontFormTokenizerControl())
->setLabel(pht('Subscribers'))
->setName('subscriberPHIDs')
->setDatasource('/typeahead/common/mailable/')
->setDatasource('/typeahead/common/allmailable/')
->setValue(array_select_keys($tokens, $subscriber_phids)))
->appendChild(
id(new AphrontFormSelectControl())