revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-30 02:32:42 +01:00
Code Issues Releases Wiki Activity

Fix XSS hole in inline comment editing

Browse source 
Summary:
Thanks to erling for the report. This was XSSable, although you could
only get yourself.

Test Plan:
Made a comment like "</textarea><h1>" and edited it before and after
the patch. Proper behavior with this patch.

Reviewed By: aran
Reviewers: erling, jungejason, tuomaspelkonen, aran
CC: aran
Differential Revision: 187
This commit is contained in:
epriestley 2011-04-29 20:18:12 -07:00
parent 78d33b1771
commit 864e0d8a2f
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/differential/controller/inlinecommentedit/DifferentialInlineCommentEditController.php
View file

@ -188,7 +188,7 @@ class DifferentialInlineCommentEditController extends DifferentialController {
'class' => 'differential-inline-comment-edit-textarea', 'class' => 'differential-inline-comment-edit-textarea',
'name' => 'text', 'name' => 'text',
), ),
$text); phutil_escape_html($text));
} }
} }