From 8739ea4dc1035e0590b47ffe296f14679b5245ec Mon Sep 17 00:00:00 2001 From: Bob Trahan <bob.trahan@gmail.com> Date: Tue, 11 Feb 2014 10:38:27 -0800 Subject: [PATCH] Diffusion - fix browse file bug Summary: we were calling a member method on a diffusion hash. not sure why. Fixes T4402 Test Plan: clicked about, no fatals and seemed to move sensical backwards in time Reviewers: epriestley Reviewed By: epriestley CC: Korvin, epriestley, aran Maniphest Tasks: T4402 Differential Revision: https://secure.phabricator.com/D8194 --- .../diffusion/controller/DiffusionBrowseFileController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/diffusion/controller/DiffusionBrowseFileController.php b/src/applications/diffusion/controller/DiffusionBrowseFileController.php index 6a14f5ac53..1a908e3e80 100644 --- a/src/applications/diffusion/controller/DiffusionBrowseFileController.php +++ b/src/applications/diffusion/controller/DiffusionBrowseFileController.php @@ -891,7 +891,7 @@ final class DiffusionBrowseFileController extends DiffusionBrowseController { $follow = 'created'; } else if ($parent) { // If we found a parent, jump to it. This is the normal case. - $target_commit = $parent->getCommitIdentifier(); + $target_commit = $parent; } else { // If there's no parent, this was probably created in the initial commit? // And the "was_created" check will fail because we can't identify the