From 874282db7589feb801874ef17895aca00ea46c82 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 17 Jun 2019 10:36:59 -0700 Subject: [PATCH] Correct "msort()" vs "msortv()" to more fully stabilize transaction sorts after recent changes Summary: Ref T13303. I upgraded this to a vector-based sort but forgot to type a "v", which means the sort has different stability under PHP 5.5. See D20582 for a root cause fix. Test Plan: Locally, on PHP7, not much changes. I expect this to fix the odd selection of title stories in mail and notification stories on `secure`, which is running PHP 5.5. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13303 Differential Revision: https://secure.phabricator.com/D20583 --- .../editor/PhabricatorApplicationTransactionEditor.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php index 55dedb863b..bcce014669 100644 --- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php +++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php @@ -3267,7 +3267,7 @@ abstract class PhabricatorApplicationTransactionEditor protected function getStrongestAction( PhabricatorLiskDAO $object, array $xactions) { - return head(msort($xactions, 'newActionStrengthSortVector')); + return head(msortv($xactions, 'newActionStrengthSortVector')); }