Disallow awarding a badge without selecting recipient

Summary:
Do not continue on missing fields (in this case: the badge recipient) in `PhabricatorBadgesEditRecipientsController`.

Closes T15827

Test Plan: See steps in T15827.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15827

Differential Revision: https://we.phorge.it/D25740

src/applications/badges/controller/PhabricatorBadgesEditRecipientsController.php

@@ -7,6 +7,8 @@ final class PhabricatorBadgesEditRecipientsController
     $viewer = $request->getViewer();
     $id = $request->getURIData('id');
     $xactions = array();
+    $errors = array();
+    $e_recipient = true;
 
     $badge = id(new PhabricatorBadgesQuery())
       ->setViewer($viewer)
@@ -29,10 +31,14 @@ final class PhabricatorBadgesEditRecipientsController
       $add_recipients = $request->getArr('phids');
       if ($add_recipients) {
         foreach ($add_recipients as $phid) {
-          $award_phids[] = $phid;
+          $award_phids[$phid] = $phid;
         }
+      } else {
+        $errors[] = pht('Recipient name is required.');
+        $e_recipient = pht('Required');
       }
 
+      if (!$errors) {
         $xactions[] = id(new PhabricatorBadgesTransaction())
           ->setTransactionType(
             PhabricatorBadgesBadgeAwardTransaction::TRANSACTIONTYPE)
@@ -48,6 +54,7 @@ final class PhabricatorBadgesEditRecipientsController
         return id(new AphrontRedirectResponse())
           ->setURI($view_uri);
       }
+    }
 
     $form = new AphrontFormView();
     $form
@@ -57,6 +64,7 @@ final class PhabricatorBadgesEditRecipientsController
         id(new AphrontFormTokenizerControl())
           ->setName('phids')
           ->setLabel(pht('Recipients'))
+          ->setError($e_recipient)
           ->setDatasource(new PhabricatorPeopleDatasource()));
 
     $dialog = id(new AphrontDialogView())