revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 05:50:55 +01:00
Code Issues Releases Wiki Activity

Prevent notice for missing configuration in PhabricatorIRCDifferentialNotificationHandler

Browse source 
Summary: Provide array() default so we don't foreach() over null in the case of a missing config (from @dctrwatson).

Test Plan: Will verify with @dctrwatson.

Reviewers: vrana, btrahan, dctrwatson

Reviewed By: vrana

CC: aran

Differential Revision: https://secure.phabricator.com/D3686
This commit is contained in:
epriestley 2012-10-11 15:00:25 -07:00
parent 16703fbf04
commit 8798d2189e
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/infrastructure/daemon/irc/handler/PhabricatorIRCDifferentialNotificationHandler.php
View file

@ -57,7 +57,8 @@ final class PhabricatorIRCDifferentialNotificationHandler
$actor_name = $handles[$actor_phid]->getName();
$message = "{$actor_name} {$verb} revision D".$data['revision_id'].".";
foreach ($this->getConfig('notification.channels') as $channel) {
$channels = $this->getConfig('notification.channels', array());
foreach ($channels as $channel) {
$this->write('PRIVMSG', "{$channel} :{$message}");
}
}