mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-09 16:32:39 +01:00
Remove "iconv" PHP extension dependency
Summary: Depends on D20069. Ref T13232. This is a very, very weak dependency and we can reasonably polyfill it. Test Plan: Grepped for `iconv` in libphutil, arcanist, and Phabricator. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13232 Differential Revision: https://secure.phabricator.com/D20070
This commit is contained in:
parent
48a3760814
commit
87b0ef8839
3 changed files with 5 additions and 4 deletions
|
@ -55,8 +55,8 @@ foreach (array('text', 'html') as $part) {
|
|||
}
|
||||
|
||||
$headers = $parser->getHeaders();
|
||||
$headers['subject'] = iconv_mime_decode($headers['subject'], 0, 'UTF-8');
|
||||
$headers['from'] = iconv_mime_decode($headers['from'], 0, 'UTF-8');
|
||||
$headers['subject'] = phutil_decode_mime_header($headers['subject']);
|
||||
$headers['from'] = phutil_decode_mime_header($headers['from']);
|
||||
|
||||
if ($args->getArg('process-duplicates')) {
|
||||
$headers['message-id'] = Filesystem::readRandomCharacters(64);
|
||||
|
|
|
@ -11,14 +11,13 @@ final class PhabricatorExtensionsSetupCheck extends PhabricatorSetupCheck {
|
|||
}
|
||||
|
||||
protected function executeChecks() {
|
||||
// TODO: Make 'mbstring' and 'iconv' soft requirements.
|
||||
// TODO: Make 'mbstring' a soft requirement.
|
||||
|
||||
$required = array(
|
||||
'hash',
|
||||
'json',
|
||||
'openssl',
|
||||
'mbstring',
|
||||
'iconv',
|
||||
'ctype',
|
||||
|
||||
// There is a tiny chance we might not need this, but a significant
|
||||
|
|
|
@ -63,6 +63,8 @@ final class PhabricatorConfigVersionController
|
|||
$version_from_file);
|
||||
}
|
||||
|
||||
$version_property_list->addProperty('php', phpversion());
|
||||
|
||||
$binaries = PhutilBinaryAnalyzer::getAllBinaries();
|
||||
foreach ($binaries as $binary) {
|
||||
if (!$binary->isBinaryAvailable()) {
|
||||
|
|
Loading…
Reference in a new issue