revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-20 13:52:40 +01:00
Code Issues Releases Wiki Activity

Display Reviewed By instead of first Reviewer in revisions overview

Browse source 
Summary:
Displaying reviewer who was by coincidence listed first is quite confusing, especially for committed revisions.
This displays the one who really reviewed the revision if available.

This implementation is pretty bad from performance perspective - O(N) queries to retrieve all comments.
The page load still feels quite fast.

Test Plan: /differential/filter/revisions/

Reviewers: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1772
This commit is contained in:
vrana 2012-03-04 02:44:35 -08:00
parent f2caa6888e
commit 87c60abbd0
1 changed files with 16 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
src/applications/differential/field/specification/reviewers/DifferentialReviewersFieldSpecification.php
View file

@ -19,6 +19,7 @@
final class DifferentialReviewersFieldSpecification
extends DifferentialFieldSpecification {
private $primaryReviewers = array();
private $reviewers;
private $error;
@ -149,15 +150,16 @@ final class DifferentialReviewersFieldSpecification
}
public function renderValueForRevisionList(DifferentialRevision $revision) {
$reviewer_phids = $revision->getReviewers();
if ($reviewer_phids) {
$first = reset($reviewer_phids);
if (count($reviewer_phids) > 1) {
$suffix = ' (+'.(count($reviewer_phids) - 1).')';
if (isset($this->primaryReviewers[$revision->getID()])) {
$primary_reviewer = $this->primaryReviewers[$revision->getID()];
$other_reviewers = array_flip($revision->getReviewers());
unset($other_reviewers[$primary_reviewer]);
if ($other_reviewers) {
$suffix = ' (+'.(count($other_reviewers)).')';
} else {
$suffix = null;
}
return $this->getHandle($first)->renderLink().$suffix;
return $this->getHandle($primary_reviewer)->renderLink().$suffix;
} else {
return '<em>None</em>';
}
@ -165,9 +167,14 @@ final class DifferentialReviewersFieldSpecification
public function getRequiredHandlePHIDsForRevisionList(
DifferentialRevision $revision) {
$reviewer_phids = $revision->getReviewers();
if ($reviewer_phids) {
return array(reset($reviewer_phids));
$primary_reviewer = $revision->loadReviewedBy();
if (!$primary_reviewer) {
$reviewer_phids = $revision->getReviewers();
$primary_reviewer = reset($reviewer_phids);
}
if ($primary_reviewer) {
$this->primaryReviewers[$revision->getID()] = $primary_reviewer;
return array($primary_reviewer);
}
return array();
}