revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-22 21:40:55 +01:00
Code Issues Releases Wiki Activity

Throw instead of log for invalid properties

Browse source 
Summary: Continue work started at D3601.

Test Plan:
Commented declaration `AphrontController::$request`, saw exception.
Brought it back, didn't see exception.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4233
This commit is contained in:
vrana 2012-12-18 16:11:07 -08:00
parent 4a81ae6d6d
commit 8816f08765
3 changed files with 4 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/__phutil_library_map__.php
View file

@ -1361,6 +1361,7 @@ phutil_register_library_map(array(
'AphrontCalendarEventView' => 'AphrontView',
'AphrontCalendarMonthView' => 'AphrontView',
'AphrontContextBarView' => 'AphrontView',
'AphrontController' => 'Phobject',
'AphrontCrumbsView' => 'AphrontView',
'AphrontCursorPagerView' => 'AphrontView',
'AphrontDefaultApplicationConfiguration' => 'AphrontApplicationConfiguration',
@ -1422,6 +1423,7 @@ phutil_register_library_map(array(
'AphrontTokenizerTemplateView' => 'AphrontView',
'AphrontTypeaheadTemplateView' => 'AphrontView',
'AphrontUsageException' => 'AphrontException',
'AphrontView' => 'Phobject',
'AphrontWebpageResponse' => 'AphrontHTMLResponse',
'CelerityPhabricatorResourceController' => 'CelerityResourceController',
'CelerityResourceController' => 'PhabricatorController',

7
src/aphront/AphrontController.php
View file

@ -3,7 +3,7 @@
/**
* @group aphront
*/
abstract class AphrontController {
abstract class AphrontController extends Phobject {
private $request;
private $currentApplication;
@ -45,9 +45,4 @@ abstract class AphrontController {
return $this->currentApplication;
}
public function __set($name, $value) {
phlog('Wrote to undeclared property '.get_class($this).'::$'.$name.'.');
$this->$name = $value;
}
}

7
src/view/AphrontView.php
View file

@ -1,6 +1,6 @@
<?php
abstract class AphrontView {
abstract class AphrontView extends Phobject {
protected $children = array();
@ -42,9 +42,4 @@ abstract class AphrontView {
abstract public function render();
public function __set($name, $value) {
phlog('Wrote to undeclared property '.get_class($this).'::$'.$name.'.');
$this->$name = $value;
}
}