From 88698bec0be114bbc9bafa374fa2024fb8e21c8e Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 22 Feb 2013 06:53:35 -0800 Subject: [PATCH] Make use of "Mnn" in Pholio more consistent Summary: - Drop it from crumb. - Add it to pinboard. - Drop it from header. - Add it to title. Test Plan: looked at stuff Reviewers: chad, ljalonen Reviewed By: ljalonen CC: aran Differential Revision: https://secure.phabricator.com/D5068 --- .../pholio/controller/PholioMockListController.php | 2 +- .../pholio/controller/PholioMockViewController.php | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/applications/pholio/controller/PholioMockListController.php b/src/applications/pholio/controller/PholioMockListController.php index 72aa56f315..6dd41d92c2 100644 --- a/src/applications/pholio/controller/PholioMockListController.php +++ b/src/applications/pholio/controller/PholioMockListController.php @@ -43,7 +43,7 @@ final class PholioMockListController extends PholioController { foreach ($mocks as $mock) { $board->addItem( id(new PhabricatorPinboardItemView()) - ->setHeader($mock->getName()) + ->setHeader('M'.$mock->getID().' '.$mock->getName()) ->setURI('/M'.$mock->getID()) ->setImageURI($mock->getCoverFile()->getThumb220x165URI()) ->setImageSize(220, 165)); diff --git a/src/applications/pholio/controller/PholioMockViewController.php b/src/applications/pholio/controller/PholioMockViewController.php index dc2fc0dfc7..7dcd20d948 100644 --- a/src/applications/pholio/controller/PholioMockViewController.php +++ b/src/applications/pholio/controller/PholioMockViewController.php @@ -54,7 +54,7 @@ final class PholioMockViewController extends PholioController { } $engine->process(); - $title = 'M'.$mock->getID().' '.$mock->getName(); + $title = $mock->getName(); $header = id(new PhabricatorHeaderView()) ->setHeader($title); @@ -78,8 +78,8 @@ final class PholioMockViewController extends PholioController { $crumbs = $this->buildApplicationCrumbs($this->buildSideNav()); $crumbs->addCrumb( id(new PhabricatorCrumbView()) - ->setName($title) - ->setHref($this->getApplicationURI().'M'.$this->id)); + ->setName('M'.$mock->getID()) + ->setHref('/M'.$mock->getID())); $content = array( $crumbs, @@ -98,7 +98,7 @@ final class PholioMockViewController extends PholioController { return $this->buildApplicationPage( $content, array( - 'title' => $title, + 'title' => 'M'.$mock->getID().' '.$title, 'device' => true, 'pageObjects' => array($mock->getPHID()), ));