From 888604c9dd01614d8eda2ac84747a95f5d87ebd3 Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 26 Jan 2021 08:39:59 -0800 Subject: [PATCH] Fix a "setExternalURI()" fatal while browsing directories with submodules Summary: Ref T13595. See that task for discussion. D21511 renamed the iteration variable here (previously "$path") but did not rename this use of it. Test Plan: - In Diffusion, browsed a directory with a submodule. - Before: "setExternalURI()" fatal in conduit call. - After: directory listing including submodule. Maniphest Tasks: T13595 Differential Revision: https://secure.phabricator.com/D21520 --- .../diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php index 4402c2a5d0..d3fe3b922e 100644 --- a/src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php +++ b/src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php @@ -240,7 +240,7 @@ final class DiffusionBrowseQueryConduitAPIMethod $full_path = $submodule_path->getFullPath(); $key = 'submodule.'.$full_path.'.url'; if (isset($dict[$key])) { - $path->setExternalURI($dict[$key]); + $submodule_path->setExternalURI($dict[$key]); } } }