Fix specifications of some "Visual Only" elements

Summary: See PHI823. These got "visual-only" but should acutally get "aural => false" to pick up "aria-hidden".

Test Plan: Viewed page source, saw both "visual-only" and "aria-hidden".

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20157

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

@@ -254,11 +254,12 @@ final class PhabricatorApplicationTransactionCommentView
 
     require_celerity_resource('phui-comment-form-css');
     $image_uri = $viewer->getProfileImageURI();
-    $image = phutil_tag(
+    $image = javelin_tag(
       'div',
       array(
         'style' => 'background-image: url('.$image_uri.')',
-        'class' => 'phui-comment-image visual-only',
+        'class' => 'phui-comment-image',
+        'aural' => false,
       ));
     $wedge = phutil_tag(
       'div',

src/view/phui/PHUIHeadThingView.php

@@ -52,12 +52,13 @@ final class PHUIHeadThingView extends AphrontTagView {
 
   protected function getTagContent() {
 
-    $image = phutil_tag(
+    $image = javelin_tag(
       'a',
       array(
-        'class' => 'phui-head-thing-image visual-only',
+        'class' => 'phui-head-thing-image',
         'style' => 'background-image: url('.$this->image.');',
         'href' => $this->imageHref,
+        'aural' => false,
       ));
 
     if ($this->image) {

src/view/phui/PHUITimelineEventView.php

@@ -420,12 +420,13 @@ final class PHUITimelineEventView extends AphrontView {
     $image = null;
     $badges = null;
     if ($image_uri) {
-      $image = phutil_tag(
+      $image = javelin_tag(
         ($this->userHandle->getURI()) ? 'a' : 'div',
         array(
           'style' => 'background-image: url('.$image_uri.')',
-          'class' => 'phui-timeline-image visual-only',
+          'class' => 'phui-timeline-image',
           'href' => $this->userHandle->getURI(),
+          'aural' => false,
         ),
         '');
       if ($this->badges && $show_badges) {