revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 00:42:41 +01:00
Code Issues Releases Wiki Activity

Fix specifications of some "Visual Only" elements

Browse source 
Summary: See PHI823. These got "visual-only" but should acutally get "aural => false" to pick up "aria-hidden".

Test Plan: Viewed page source, saw both "visual-only" and "aria-hidden".

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20157
This commit is contained in:
epriestley 2019-02-13 04:38:41 -08:00
parent 9a9fa8bed2
commit 88d5233b77
3 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
View file

@ -254,11 +254,12 @@ final class PhabricatorApplicationTransactionCommentView
require_celerity_resource('phui-comment-form-css'); require_celerity_resource('phui-comment-form-css');
$image_uri = $viewer->getProfileImageURI(); $image_uri = $viewer->getProfileImageURI();
$image = phutil_tag( $image = javelin_tag(
'div', 'div',
array( array(
'style' => 'background-image: url('.$image_uri.')', 'style' => 'background-image: url('.$image_uri.')',
'class' => 'phui-comment-image visual-only', 'class' => 'phui-comment-image',
'aural' => false,
)); ));
$wedge = phutil_tag( $wedge = phutil_tag(
'div', 'div',

5
src/view/phui/PHUIHeadThingView.php
View file

@ -52,12 +52,13 @@ final class PHUIHeadThingView extends AphrontTagView {
protected function getTagContent() { protected function getTagContent() {
$image = phutil_tag( $image = javelin_tag(
'a', 'a',
array( array(
'class' => 'phui-head-thing-image visual-only', 'class' => 'phui-head-thing-image',
'style' => 'background-image: url('.$this->image.');', 'style' => 'background-image: url('.$this->image.');',
'href' => $this->imageHref, 'href' => $this->imageHref,
'aural' => false,
)); ));
if ($this->image) { if ($this->image) {

5
src/view/phui/PHUITimelineEventView.php
View file

@ -420,12 +420,13 @@ final class PHUITimelineEventView extends AphrontView {
$image = null; $image = null;
$badges = null; $badges = null;
if ($image_uri) { if ($image_uri) {
$image = phutil_tag( $image = javelin_tag(
($this->userHandle->getURI()) ? 'a' : 'div', ($this->userHandle->getURI()) ? 'a' : 'div',
array( array(
'style' => 'background-image: url('.$image_uri.')', 'style' => 'background-image: url('.$image_uri.')',
'class' => 'phui-timeline-image visual-only', 'class' => 'phui-timeline-image',
'href' => $this->userHandle->getURI(), 'href' => $this->userHandle->getURI(),
'aural' => false,
), ),
''); '');
if ($this->badges && $show_badges) { if ($this->badges && $show_badges) {