revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-04-10 03:18:41 +02:00
Code Issues Releases Wiki Activity

Force Aphlict server connections to HTTP

Browse source 
Summary: This port is always HTTP, so use HTTP even if users have set the URI to "https".

Test Plan: Launched server and hit status page, status good.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D11799
This commit is contained in:
epriestley 2015-02-18 07:07:26 -08:00
parent 3469265e17
commit 894025778c
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/applications/notification/client/PhabricatorNotificationClient.php
View file

@ -10,6 +10,11 @@ final class PhabricatorNotificationClient {
->setPath('/status/') ->setPath('/status/')
->setQueryParam('instance', self::getInstance()); ->setQueryParam('instance', self::getInstance());
// We always use HTTP to connect to the server itself: it's simpler and
// there's no meaningful security benefit to securing this link today.
// Force the protocol to HTTP in case users have set it to something else.
$uri->setProtocol('http');
list($body) = id(new HTTPSFuture($uri)) list($body) = id(new HTTPSFuture($uri))
->setTimeout(3) ->setTimeout(3)
->resolvex(); ->resolvex();