From 8941bbfcea7d333482a93ba052824c8dc5e0f230 Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 21 Sep 2016 14:30:59 -0700 Subject: [PATCH] Make "text" custom fields appear in ApplicationSearch again Summary: Fixes T11675. This capability was erroneously (probably?) removed in D14766. This search implementation (which uses exact match) probably isn't perfect for all cases of "text" fields, but empirically it seems to be what a significant number of users are after. Test Plan: Searched for a custom text field value. {F1843383} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11675 Differential Revision: https://secure.phabricator.com/D16582 --- .../standard/PhabricatorStandardCustomFieldText.php | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldText.php b/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldText.php index 8a4ae97bcf..8242c477fd 100644 --- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldText.php +++ b/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldText.php @@ -72,10 +72,6 @@ final class PhabricatorStandardCustomFieldText return new AphrontStringHTTPParameterType(); } - public function shouldAppearInApplicationSearch() { - return false; - } - public function getConduitEditParameterType() { return new ConduitStringParameterType(); }