From 895cdaca5d1f1afdea565bc457a3b864b35c53e5 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Fri, 16 Dec 2016 10:06:12 -0800
Subject: [PATCH] Simplify "Blame Revision" field in Differential

Summary: Ref T11114. This is still mostly in use, but toss a few commit message parsing things.

Test Plan: Viewed/edited/upated blame rev from CLI/web UI.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11114

Differential Revision: https://secure.phabricator.com/D17089
---
 .../DifferentialBlameRevisionField.php        | 23 ++++---------------
 1 file changed, 4 insertions(+), 19 deletions(-)

diff --git a/src/applications/differential/customfield/DifferentialBlameRevisionField.php b/src/applications/differential/customfield/DifferentialBlameRevisionField.php
index 99915440c8..b2d8872225 100644
--- a/src/applications/differential/customfield/DifferentialBlameRevisionField.php
+++ b/src/applications/differential/customfield/DifferentialBlameRevisionField.php
@@ -32,6 +32,10 @@ final class DifferentialBlameRevisionField
   }
 
   public function renderPropertyViewValue(array $handles) {
+    if (!strlen($this->getValue())) {
+      return null;
+    }
+
     return $this->getValue();
   }
 
@@ -91,25 +95,6 @@ final class DifferentialBlameRevisionField
     return true;
   }
 
-  public function shouldAllowEditInCommitMessage() {
-    return true;
-  }
-
-  public function shouldOverwriteWhenCommitMessageIsEdited() {
-    return true;
-  }
-
-  public function getCommitMessageLabels() {
-    return array(
-      'Blame Revision',
-      'Blame Rev',
-    );
-  }
-
-  public function renderCommitMessageValue(array $handles) {
-    return $this->getValue();
-  }
-
   public function shouldAppearInConduitDictionary() {
     return true;
   }