From 89ab9d4acbf730dcdc7bab9c462149af030f3732 Mon Sep 17 00:00:00 2001 From: vrana Date: Fri, 7 Dec 2012 18:15:46 -0800 Subject: [PATCH] Support `git svn dcommit` in `arc land` Test Plan: Displayed accepted Git SVN revision. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4124 --- ...entialRevisionStatusFieldSpecification.php | 22 +++++++------------ 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/src/applications/differential/field/specification/DifferentialRevisionStatusFieldSpecification.php b/src/applications/differential/field/specification/DifferentialRevisionStatusFieldSpecification.php index 22788e1fc1..45d38cf835 100644 --- a/src/applications/differential/field/specification/DifferentialRevisionStatusFieldSpecification.php +++ b/src/applications/differential/field/specification/DifferentialRevisionStatusFieldSpecification.php @@ -25,20 +25,14 @@ final class DifferentialRevisionStatusFieldSpecification if ($status == ArcanistDifferentialRevisionStatus::ACCEPTED) { $next_step = null; - if ($local_vcs == $backing_vcs) { - switch ($local_vcs) { - case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL: - $next_step = 'hg push'; - break; - case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT: - $next_step = 'arc land'; - break; - case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN: - $next_step = 'arc commit'; - break; - } - } else { - $next_step = 'arc amend'; + switch ($local_vcs) { + case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL: + case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT: + $next_step = 'arc land'; + break; + case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN: + $next_step = 'arc commit'; + break; } if ($next_step) { $info = ' · Next step: '.$next_step;