From 8a2afa14d24f3cc9feaefbf62e65e0a8f3cc5333 Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 13 Dec 2016 04:55:53 -0800 Subject: [PATCH] Make the documentation more clear that storage.mysql-engine.max-size is measured in bytes Summary: Fixes T12001. I think we're consistent about using bytes everywhere, but users won't necessarily know that and this documentation could certainly be more clear. Test Plan: Read new text. Reviewers: chad Reviewed By: chad Maniphest Tasks: T12001 Differential Revision: https://secure.phabricator.com/D17037 --- .../user/configuration/configuring_file_storage.diviner | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/docs/user/configuration/configuring_file_storage.diviner b/src/docs/user/configuration/configuring_file_storage.diviner index 64942b493e..d6abb22c13 100644 --- a/src/docs/user/configuration/configuring_file_storage.diviner +++ b/src/docs/user/configuration/configuring_file_storage.diviner @@ -133,15 +133,15 @@ Engine: MySQL MySQL storage is configured by default, for files up to (just under) 1MB. You can configure it with these keys: - - `storage.mysql-engine.max-size`: Change the filesize limit. Set to 0 - to disable. + - `storage.mysql-engine.max-size`: Change the filesize limit, in bytes. Set + to 0 to disable. For most installs, it is reasonable to leave this engine as-is and let small files (like thumbnails and profile images) be stored in MySQL, which is usually the lowest-latency filestore, even if you configure another storage engine. -To support large files, increase this limit to at least **8MB**. This will -activate chunk storage in MySQL. +To support large files, increase this limit to at least `8388608` (8MB). +This will activate chunk storage in MySQL. Engine: Local Disk ==================