Fix parsing of "Reviewed By" field

Summary: In the Message parser, we read this field and expect to get an array of PHIDs out of it. Currently, we get a string. Instead, get an array of PHIDs.

Test Plan: Wrote a message like "Fixes Tnnn" with "Reviewed by: duck", and saw no more parse error during message parsing.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: aran, epriestley

Differential Revision: https://secure.phabricator.com/D8510

src/applications/differential/customfield/DifferentialCustomField.php

@@ -51,11 +51,15 @@ abstract class DifferentialCustomField
     return array();
   }
 
-  protected function parseObjectList($value, array $types) {
+  protected function parseObjectList(
+    $value,
+    array $types,
+    $allow_partial = false) {
     return id(new PhabricatorObjectListQuery())
       ->setViewer($this->getViewer())
       ->setAllowedTypes($types)
       ->setObjectList($value)
+      ->setAllowPartialResults($allow_partial)
       ->execute();
   }
 

src/applications/differential/customfield/DifferentialReviewedByField.php

@@ -51,6 +51,16 @@ final class DifferentialReviewedByField
     return true;
   }
 
+  public function parseValueFromCommitMessage($value) {
+    return $this->parseObjectList(
+      $value,
+      array(
+        PhabricatorPeoplePHIDTypeUser::TYPECONST,
+        PhabricatorProjectPHIDTypeProject::TYPECONST,
+      ),
+      $allow_partial = true);
+  }
+
   public function getRequiredHandlePHIDsForCommitMessage() {
     return $this->getValue();
   }