From 8a6d767843631e1858459cf7da018388d022870a Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 24 Aug 2018 10:07:47 -0700 Subject: [PATCH] Fix a minor text alignment issue for static text comment actions like "Accept Revision" Summary: Ref T13187. See PHI836. The "action" comment actions in Differential (Accept, Reject, etc) render a single line of descriptive text. This is currently slightly misaligned. Give it similar sizing information to the label element to the left, so it lines up properly. Test Plan: Note that "Request Review" and "This revision will be..." are now aligned: {F5828077} Reviewers: amckinley Maniphest Tasks: T13187 Differential Revision: https://secure.phabricator.com/D19600 --- resources/celerity/map.php | 6 +++--- webroot/rsrc/css/phui/phui-form-view.css | 3 ++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index c60c2f7e85..66a568dabe 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -9,7 +9,7 @@ return array( 'names' => array( 'conpherence.pkg.css' => 'e68cf1fa', 'conpherence.pkg.js' => '15191c65', - 'core.pkg.css' => 'f515619b', + 'core.pkg.css' => 'fc4839c8', 'core.pkg.js' => '2058ec09', 'differential.pkg.css' => '06dc617c', 'differential.pkg.js' => 'c1cfa143', @@ -151,7 +151,7 @@ return array( 'rsrc/css/phui/phui-document.css' => '878c2f52', 'rsrc/css/phui/phui-feed-story.css' => '44a9c8e9', 'rsrc/css/phui/phui-fontkit.css' => '1320ed01', - 'rsrc/css/phui/phui-form-view.css' => 'ae9f8d16', + 'rsrc/css/phui/phui-form-view.css' => 'f808e5be', 'rsrc/css/phui/phui-form.css' => '7aaa04e3', 'rsrc/css/phui/phui-head-thing.css' => 'fd311e5f', 'rsrc/css/phui/phui-header-view.css' => 'edeb9252', @@ -819,7 +819,7 @@ return array( 'phui-font-icon-base-css' => '870a7360', 'phui-fontkit-css' => '1320ed01', 'phui-form-css' => '7aaa04e3', - 'phui-form-view-css' => 'ae9f8d16', + 'phui-form-view-css' => 'f808e5be', 'phui-head-thing-view-css' => 'fd311e5f', 'phui-header-view-css' => 'edeb9252', 'phui-hovercard' => '1bd28176', diff --git a/webroot/rsrc/css/phui/phui-form-view.css b/webroot/rsrc/css/phui/phui-form-view.css index 1b7400656a..9824196882 100644 --- a/webroot/rsrc/css/phui/phui-form-view.css +++ b/webroot/rsrc/css/phui/phui-form-view.css @@ -546,7 +546,8 @@ properly, and submit values. */ } .phui-form-static-action { - padding: 4px; + height: 28px; + line-height: 28px; color: {$bluetext}; }