From 8a81d208c4873b68fa135f21a1c9bddabb723c53 Mon Sep 17 00:00:00 2001 From: epriestley Date: Sat, 19 Dec 2015 12:55:35 -0800 Subject: [PATCH] Don't show "master (branched from master)" in UI Summary: Ref T3462. If someone works directly on `master`, we currently show "Branch: master (branched from master)" in the UI. Although this is sort of technically accurate, it is confusing. Instead, just show "Branch: master" in this situation. Test Plan: Saw "master" instead of "master (branched from master)". Reviewers: chad Reviewed By: chad Maniphest Tasks: T3462 Differential Revision: https://secure.phabricator.com/D14829 --- .../differential/customfield/DifferentialBranchField.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/differential/customfield/DifferentialBranchField.php b/src/applications/differential/customfield/DifferentialBranchField.php index 62f47a5e1a..16be0ce0c9 100644 --- a/src/applications/differential/customfield/DifferentialBranchField.php +++ b/src/applications/differential/customfield/DifferentialBranchField.php @@ -45,7 +45,7 @@ final class DifferentialBranchField return pht('%s (bookmark)', $bookmark); } else if (strlen($branch)) { $onto = $diff->loadTargetBranch(); - if (strlen($onto)) { + if (strlen($onto) && ($onto !== $branch)) { return pht( '%s (branched from %s)', $branch,