From 8aa047766d2ca52dca3382a126f1a44aeaab34d3 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Tue, 7 Oct 2014 14:49:22 -0700 Subject: [PATCH] Check for presence of any Columns before triggering initialization of Workboard Summary: Ref T6256, this prevents more installs from getting in this weird state. We'll have to follow up if possible to "fix" the issue retroactively. Test Plan: Test moving a backlog column to new position, hiding rest of other panels. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6256 Differential Revision: https://secure.phabricator.com/D10651 --- .../controller/PhabricatorProjectBoardViewController.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/applications/project/controller/PhabricatorProjectBoardViewController.php b/src/applications/project/controller/PhabricatorProjectBoardViewController.php index c8380998a4..130301955a 100644 --- a/src/applications/project/controller/PhabricatorProjectBoardViewController.php +++ b/src/applications/project/controller/PhabricatorProjectBoardViewController.php @@ -68,7 +68,9 @@ final class PhabricatorProjectBoardViewController $columns = $column_query->execute(); $columns = mpull($columns, null, 'getSequence'); - if (empty($columns[0])) { + // TODO: Expand the checks here if we add the ability + // to hide the Backlog column + if (!$columns) { switch ($request->getStr('initialize-type')) { case 'backlog-only': $unguarded = AphrontWriteGuard::beginScopedUnguardedWrites();