Normalize casing on property boxes

Summary: Going to render these all normal case instead of all caps, and bump up the font size. Should be more consistent. Yellow if you green anything orange. Test Plan: grep, lint Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15645
2024-12-20 20:40:56 +01:00 · 2016-04-06 15:20:53 -07:00 · 2016-04-06 15:20:53 -07:00 · 8aad862cd4
commit 8aad862cd4
parent 439821c7b2
33 changed files with 44 additions and 44 deletions
--- a/src/applications/almanac/controller/AlmanacBindingViewController.php
+++ b/src/applications/almanac/controller/AlmanacBindingViewController.php
@ -68,7 +68,7 @@ final class AlmanacBindingViewController
          $this->buildAlmanacPropertiesTable($binding),
          $timeline,
        ))
-      ->addPropertySection(pht('DETAILS'), $details);
+      ->addPropertySection(pht('Details'), $details);

    return $this->newPage()
      ->setTitle($title)
--- a/src/applications/almanac/controller/AlmanacController.php
+++ b/src/applications/almanac/controller/AlmanacController.php
@ -158,7 +158,7 @@ abstract class AlmanacController
      ->setIcon('fa-plus');

    $header = id(new PHUIHeaderView())
-      ->setHeader(pht('PROPERTIES'))
+      ->setHeader(pht('Properties'))
      ->addActionLink($add_button);

    return id(new PHUIObjectBoxView())
--- a/src/applications/almanac/controller/AlmanacServiceViewController.php
+++ b/src/applications/almanac/controller/AlmanacServiceViewController.php
@ -81,7 +81,7 @@ final class AlmanacServiceViewController
      $service->getServiceImplementation()->getServiceTypeShortName());

    return id(new PHUIObjectBoxView())
-      ->setHeaderText(pht('DETAILS'))
+      ->setHeaderText(pht('Details'))
      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
      ->appendChild($properties);
  }
--- a/src/applications/badges/controller/PhabricatorBadgesViewController.php
+++ b/src/applications/badges/controller/PhabricatorBadgesViewController.php
@ -72,7 +72,7 @@ final class PhabricatorBadgesViewController
          $timeline,
          $comment_view,
        ))
-      ->addPropertySection(pht('DESCRIPTION'), $details);
+      ->addPropertySection(pht('Description'), $details);

    return $this->newPage()
      ->setTitle($title)
--- a/src/applications/calendar/controller/PhabricatorCalendarEventViewController.php
+++ b/src/applications/calendar/controller/PhabricatorCalendarEventViewController.php
@ -94,8 +94,8 @@ final class PhabricatorCalendarEventViewController
          $add_comment_form,
        ))
      ->setCurtain($curtain)
-      ->addPropertySection(pht('DETAILS'), $details)
-      ->addPropertySection(pht('DESCRIPTION'), $description);
+      ->addPropertySection(pht('Details'), $details)
+      ->addPropertySection(pht('Description'), $description);

    return $this->newPage()
      ->setTitle($page_title)
--- a/src/applications/daemon/controller/PhabricatorDaemonBulkJobViewController.php
+++ b/src/applications/daemon/controller/PhabricatorDaemonBulkJobViewController.php
@ -29,7 +29,7 @@ final class PhabricatorDaemonBulkJobViewController
    $curtain = $this->buildCurtainView($job);

    $box = id(new PHUIObjectBoxView())
-      ->setHeaderText(pht('DETAILS'))
+      ->setHeaderText(pht('Details'))
      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
      ->addPropertyList($properties);

--- a/src/applications/dashboard/controller/PhabricatorDashboardManageController.php
+++ b/src/applications/dashboard/controller/PhabricatorDashboardManageController.php
@ -198,7 +198,7 @@ final class PhabricatorDashboardManageController
      $viewer->renderHandleList($dashboard->getPanelPHIDs()));

    return id(new PHUIObjectBoxView())
-      ->setHeaderText(pht('DETAILS'))
+      ->setHeaderText(pht('Details'))
      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
      ->addPropertyList($properties);
  }
--- a/src/applications/dashboard/controller/PhabricatorDashboardPanelViewController.php
+++ b/src/applications/dashboard/controller/PhabricatorDashboardPanelViewController.php
@ -165,7 +165,7 @@ final class PhabricatorDashboardPanelViewController
        : phutil_tag('em', array(), $does_not_appear));

    return id(new PHUIObjectBoxView())
-      ->setHeaderText(pht('DETAILS'))
+      ->setHeaderText(pht('Details'))
      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
      ->addPropertyList($properties);
  }
--- a/src/applications/differential/controller/DifferentialRevisionViewController.php
+++ b/src/applications/differential/controller/DifferentialRevisionViewController.php
@ -480,7 +480,7 @@ final class DifferentialRevisionViewController extends DifferentialController {
    }

    $header = id(new PHUIHeaderView())
-      ->setHeader(pht('DETAILS'));
+      ->setHeader(pht('Details'));

    return id(new PHUIObjectBoxView())
      ->setHeader($header)
--- a/src/applications/diffusion/controller/DiffusionBrowseController.php
+++ b/src/applications/diffusion/controller/DiffusionBrowseController.php
@ -310,7 +310,7 @@ final class DiffusionBrowseController extends DiffusionController {
        ));

    if ($properties) {
-      $view->addPropertySection(pht('DETAILS'), $properties);
+      $view->addPropertySection(pht('Details'), $properties);
    }

    $title = array($basename, $repository->getDisplayName());
@ -413,7 +413,7 @@ final class DiffusionBrowseController extends DiffusionController {
      ));

    if ($details) {
-      $view->addPropertySection(pht('DETAILS'), $details);
+      $view->addPropertySection(pht('Details'), $details);
    }

    return $this->newPage()
@ -1409,7 +1409,7 @@ final class DiffusionBrowseController extends DiffusionController {

    $file = $this->renderFileButton($file_uri);
    $header = id(new PHUIHeaderView())
-      ->setHeader(pht('DETAILS'))
+      ->setHeader(pht('Details'))
      ->addActionLink($file);

    $box = id(new PHUIObjectBoxView())
@ -1426,7 +1426,7 @@ final class DiffusionBrowseController extends DiffusionController {
      ->appendChild($message);

    $header = id(new PHUIHeaderView())
-      ->setHeader(pht('DETAILS'));
+      ->setHeader(pht('Details'));

    $box = id(new PHUIObjectBoxView())
      ->setHeader($header)
--- a/src/applications/diffusion/controller/DiffusionCommitController.php
+++ b/src/applications/diffusion/controller/DiffusionCommitController.php
@ -355,8 +355,8 @@ final class DiffusionCommitController extends DiffusionController {
        $change_list,
        $add_comment,
      ))
-      ->addPropertySection(pht('DESCRIPTION'), $detail_list)
-      ->addPropertySection(pht('DETAILS'), $details)
+      ->addPropertySection(pht('Description'), $detail_list)
+      ->addPropertySection(pht('Details'), $details)
      ->setCurtain($curtain);

    $page = $this->newPage()
--- a/src/applications/diffusion/controller/DiffusionRepositoryController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryController.php
@ -288,7 +288,7 @@ final class DiffusionRepositoryController extends DiffusionController {
      $description = new PHUIRemarkupView($viewer, $description);
      $view->addTextContent($description);
      return id(new PHUIObjectBoxView())
-        ->setHeaderText(pht('DESCRIPTION'))
+        ->setHeaderText(pht('Description'))
        ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
        ->appendChild($view);
    }
@ -354,7 +354,7 @@ final class DiffusionRepositoryController extends DiffusionController {
    }

    $box = id(new PHUIObjectBoxView())
-      ->setHeaderText(pht('DETAILS'))
+      ->setHeaderText(pht('Details'))
      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
      ->appendChild($view);

--- a/src/applications/fund/controller/FundInitiativeViewController.php
+++ b/src/applications/fund/controller/FundInitiativeViewController.php
@ -62,7 +62,7 @@ final class FundInitiativeViewController
        $timeline,
        $add_comment,
      ))
-      ->addPropertySection(pht('DETAILS'), $details);
+      ->addPropertySection(pht('Details'), $details);

    return $this->newPage()
      ->setTitle($title)
--- a/src/applications/harbormaster/controller/HarbormasterBuildViewController.php
+++ b/src/applications/harbormaster/controller/HarbormasterBuildViewController.php
@ -539,7 +539,7 @@ final class HarbormasterBuildViewController
      $this->getStatus($build));

    return id(new PHUIObjectBoxView())
-      ->setHeaderText(pht('PROPERTIES'))
+      ->setHeaderText(pht('Properties'))
      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
      ->appendChild($properties);

--- a/src/applications/harbormaster/controller/HarbormasterBuildableViewController.php
+++ b/src/applications/harbormaster/controller/HarbormasterBuildableViewController.php
@ -178,7 +178,7 @@ final class HarbormasterBuildableViewController
        : pht('Automatic Buildable'));

    return id(new PHUIObjectBoxView())
-      ->setHeaderText(pht('PROPERTIES'))
+      ->setHeaderText(pht('Properties'))
      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
      ->appendChild($properties);
  }
--- a/src/applications/harbormaster/controller/HarbormasterStepViewController.php
+++ b/src/applications/harbormaster/controller/HarbormasterStepViewController.php
@ -104,7 +104,7 @@ final class HarbormasterStepViewController
    }

    return id(new PHUIObjectBoxView())
-      ->setHeaderText(pht('PROPERTIES'))
+      ->setHeaderText(pht('Properties'))
      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
      ->appendChild($view);
  }
--- a/src/applications/herald/controller/HeraldRuleViewController.php
+++ b/src/applications/herald/controller/HeraldRuleViewController.php
@ -54,8 +54,8 @@ final class HeraldRuleViewController extends HeraldController {
      ->setHeader($header)
      ->setCurtain($curtain)
      ->setMainColumn($timeline)
-      ->addPropertySection(pht('DETAILS'), $details)
-      ->addPropertySection(pht('DESCRIPTION'), $description);
+      ->addPropertySection(pht('Details'), $details)
+      ->addPropertySection(pht('Description'), $description);

    return $this->newPage()
      ->setTitle($title)
--- a/src/applications/legalpad/controller/LegalpadDocumentManageController.php
+++ b/src/applications/legalpad/controller/LegalpadDocumentManageController.php
@ -176,7 +176,7 @@ final class LegalpadDocumentManageController extends LegalpadController {
    }

    return id(new PHUIObjectBoxView())
-      ->setHeaderText(pht('PROPERTIES'))
+      ->setHeaderText(pht('Properties'))
      ->addPropertyList($properties)
      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY);
  }
--- a/src/applications/macro/controller/PhabricatorMacroViewController.php
+++ b/src/applications/macro/controller/PhabricatorMacroViewController.php
@ -72,8 +72,8 @@ final class PhabricatorMacroViewController
        $timeline,
        $add_comment_form,
      ))
-      ->addPropertySection(pht('MACRO'), $file)
-      ->addPropertySection(pht('DETAILS'), $details);
+      ->addPropertySection(pht('Macro'), $file)
+      ->addPropertySection(pht('Details'), $details);

    return $this->newPage()
      ->setTitle($title_short)
--- a/src/applications/maniphest/controller/ManiphestTaskDetailController.php
+++ b/src/applications/maniphest/controller/ManiphestTaskDetailController.php
@ -88,8 +88,8 @@ final class ManiphestTaskDetailController extends ManiphestController {
        $timeline,
        $comment_view,
      ))
-      ->addPropertySection(pht('DESCRIPTION'), $description)
-      ->addPropertySection(pht('DETAILS'), $details);
+      ->addPropertySection(pht('Description'), $description)
+      ->addPropertySection(pht('Details'), $details);

    return $this->newPage()
      ->setTitle($title)
--- a/src/applications/meta/controller/PhabricatorApplicationDetailViewController.php
+++ b/src/applications/meta/controller/PhabricatorApplicationDetailViewController.php
@ -63,7 +63,7 @@ final class PhabricatorApplicationDetailViewController
          $policies,
          $panels,
        ))
-      ->addPropertySection(pht('DETAILS'), $details);
+      ->addPropertySection(pht('Details'), $details);

    return $this->newPage()
      ->setTitle($title)
--- a/src/applications/nuance/controller/NuanceItemManageController.php
+++ b/src/applications/nuance/controller/NuanceItemManageController.php
@ -40,7 +40,7 @@ final class NuanceItemManageController extends NuanceController {
    $view = id(new PHUITwoColumnView())
      ->setHeader($header)
      ->setCurtain($curtain)
-      ->addPropertySection(pht('DETAILS'), $properties)
+      ->addPropertySection(pht('Details'), $properties)
      ->setMainColumn($timeline);

    return $this->newPage()
--- a/src/applications/nuance/controller/NuanceSourceViewController.php
+++ b/src/applications/nuance/controller/NuanceSourceViewController.php
@ -40,8 +40,8 @@ final class NuanceSourceViewController
    $view = id(new PHUITwoColumnView())
      ->setHeader($header)
      ->setCurtain($curtain)
-      ->addPropertySection(pht('DETAILS'), $properties)
-      ->addPropertySection(pht('ROUTING'), $routing_list)
+      ->addPropertySection(pht('Details'), $properties)
+      ->addPropertySection(pht('Routing'), $routing_list)
      ->setMainColumn($timeline);

    return $this->newPage()
--- a/src/applications/passphrase/controller/PassphraseCredentialViewController.php
+++ b/src/applications/passphrase/controller/PassphraseCredentialViewController.php
@ -36,7 +36,7 @@ final class PassphraseCredentialViewController extends PassphraseController {
      ->setSubheader($subheader)
      ->setCurtain($curtain)
      ->setMainColumn($timeline)
-      ->addPropertySection(pht('PROPERTIES'), $content);
+      ->addPropertySection(pht('Properties'), $content);

    return $this->newPage()
      ->setTitle($title)
--- a/src/applications/people/controller/PhabricatorPeopleProfileManageController.php
+++ b/src/applications/people/controller/PhabricatorPeopleProfileManageController.php
@ -57,7 +57,7 @@ final class PhabricatorPeopleProfileManageController
    $manage = id(new PHUITwoColumnView())
      ->setHeader($header)
      ->setCurtain($curtain)
-      ->addPropertySection(pht('DETAILS'), $properties)
+      ->addPropertySection(pht('Details'), $properties)
      ->setMainColumn(
        array(
          $timeline,
--- a/src/applications/phlux/controller/PhluxViewController.php
+++ b/src/applications/phlux/controller/PhluxViewController.php
@ -41,7 +41,7 @@ final class PhluxViewController extends PhluxController {
    $timeline->setShouldTerminate(true);

    $object_box = id(new PHUIObjectBoxView())
-      ->setHeaderText(pht('DETAILS'))
+      ->setHeaderText(pht('Details'))
      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
      ->addPropertyList($properties);

--- a/src/applications/phortune/controller/PhortuneMerchantViewController.php
+++ b/src/applications/phortune/controller/PhortuneMerchantViewController.php
@ -131,7 +131,7 @@ final class PhortuneMerchantViewController
    $view->addProperty(pht('Status'), $status_view);

    return id(new PHUIObjectBoxView())
-      ->setHeaderText(pht('DETAILS'))
+      ->setHeaderText(pht('Details'))
      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
      ->appendChild($view);
  }
@ -146,7 +146,7 @@ final class PhortuneMerchantViewController
      $description = new PHUIRemarkupView($viewer, $description);
      $view->addTextContent($description);
      return id(new PHUIObjectBoxView())
-        ->setHeaderText(pht('DESCRIPTION'))
+        ->setHeaderText(pht('Description'))
        ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
        ->appendChild($view);
    }
--- a/src/applications/phortune/controller/PhortuneProductViewController.php
+++ b/src/applications/phortune/controller/PhortuneProductViewController.php
@ -38,7 +38,7 @@ final class PhortuneProductViewController extends PhortuneController {
        $product->getPriceAsCurrency()->formatForDisplay());

    $object_box = id(new PHUIObjectBoxView())
-      ->setHeaderText(pht('DETAILS'))
+      ->setHeaderText(pht('Details'))
      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
      ->addPropertyList($properties);

--- a/src/applications/phortune/controller/PhortuneSubscriptionViewController.php
+++ b/src/applications/phortune/controller/PhortuneSubscriptionViewController.php
@ -82,7 +82,7 @@ final class PhortuneSubscriptionViewController extends PhortuneController {
      $autopay_method);

    $details = id(new PHUIObjectBoxView())
-      ->setHeaderText(pht('DETAILS'))
+      ->setHeaderText(pht('Details'))
      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
      ->addPropertyList($properties);

--- a/src/applications/phurl/controller/PhabricatorPhurlURLViewController.php
+++ b/src/applications/phurl/controller/PhabricatorPhurlURLViewController.php
@ -145,7 +145,7 @@ final class PhabricatorPhurlURLViewController
    }

    return id(new PHUIObjectBoxView())
-      ->setHeaderText(pht('DETAILS'))
+      ->setHeaderText(pht('Details'))
      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
      ->appendChild($properties);
  }
--- a/src/applications/ponder/controller/PonderQuestionViewController.php
+++ b/src/applications/ponder/controller/PonderQuestionViewController.php
@ -119,7 +119,7 @@ final class PonderQuestionViewController extends PonderController {
      ->setSubheader($subheader)
      ->setCurtain($curtain)
      ->setMainColumn($ponder_content)
-      ->addPropertySection(pht('DETAILS'), $details)
+      ->addPropertySection(pht('Details'), $details)
      ->addClass('ponder-question-view');

    $page_objects = array_merge(
--- a/src/applications/project/controller/PhabricatorProjectManageController.php
+++ b/src/applications/project/controller/PhabricatorProjectManageController.php
@ -48,7 +48,7 @@ final class PhabricatorProjectManageController
    $manage = id(new PHUITwoColumnView())
      ->setHeader($header)
      ->setCurtain($curtain)
-      ->addPropertySection(pht('DETAILS'), $properties)
+      ->addPropertySection(pht('Details'), $properties)
      ->setMainColumn(
        array(
          $timeline,
--- a/src/applications/spaces/controller/PhabricatorSpacesViewController.php
+++ b/src/applications/spaces/controller/PhabricatorSpacesViewController.php
@ -45,7 +45,7 @@ final class PhabricatorSpacesViewController
    }

    $box = id(new PHUIObjectBoxView())
-      ->setHeaderText(pht('DETAILS'))
+      ->setHeaderText(pht('Details'))
      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
      ->addPropertyList($property_list);