1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 05:50:55 +01:00

Fix passing null to trim() error in DiffusionBrowseTableView render()

Summary:
When viewing the top level of a diffusion repository, $request->getPath() returns null, which then causes trim() to throw an error.

Fix is to update DiffusionRequest getPath() such that it returns '' instead of null, thus fixing it's return type.

Fixes T15522

Test Plan: Go to https://my.phorge.site/source/myrepo

Reviewers: O1 Blessed Committers, valerio.bozzolan, avivey

Reviewed By: O1 Blessed Committers, valerio.bozzolan, avivey

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15522

Differential Revision: https://we.phorge.it/D25329
This commit is contained in:
Steve Campbell 2023-07-17 11:05:03 +01:00
parent 65e57fe23d
commit 8af1624692

View file

@ -254,7 +254,7 @@ abstract class DiffusionRequest extends Phobject {
}
public function getPath() {
return $this->path;
return coalesce($this->path, '');
}
public function getLine() {