revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-20 01:08:50 +02:00
Code Issues Releases Wiki Activity

Add NEEDS_REVISION support to DifferentialRevisionQuery

Browse source 
Reviewed by: epriestley

See: https://github.com/facebook/phabricator/pull/370
This commit is contained in:
Kieran Brownlees 2013-08-07 14:53:49 +01:00 committed by epriestley
parent 1ab7622edf
commit 8b07c498d4
1 changed files with 17 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
src/applications/differential/query/DifferentialRevisionQuery.php
View file

@ -17,14 +17,15 @@ final class DifferentialRevisionQuery
private $pathIDs = array(); private $pathIDs = array();
private $status = 'status-any'; private $status = 'status-any';
const STATUS_ANY = 'status-any'; const STATUS_ANY = 'status-any';
const STATUS_OPEN = 'status-open'; const STATUS_OPEN = 'status-open';
const STATUS_ACCEPTED = 'status-accepted'; const STATUS_ACCEPTED = 'status-accepted';
const STATUS_NEEDS_REVIEW = 'status-needs-review'; const STATUS_NEEDS_REVIEW = 'status-needs-review';
const STATUS_CLOSED = 'status-closed'; // NOTE: Same as 'committed'. const STATUS_NEEDS_REVISION = 'status-needs-revision';
const STATUS_COMMITTED = 'status-committed'; // TODO: Remove. const STATUS_CLOSED = 'status-closed'; // NOTE: Same as 'committed'
const STATUS_ABANDONED = 'status-abandoned'; const STATUS_COMMITTED = 'status-committed'; // TODO: Remove.
const STATUS_ABANDONED = 'status-abandoned';
private $authors = array(); private $authors = array();
private $draftAuthors = array(); private $draftAuthors = array();
@ -660,6 +661,14 @@ final class DifferentialRevisionQuery
ArcanistDifferentialRevisionStatus::NEEDS_REVIEW, ArcanistDifferentialRevisionStatus::NEEDS_REVIEW,
)); ));
break; break;
case self::STATUS_NEEDS_REVISION:
$where[] = qsprintf(
$conn_r,
'r.status IN (%Ld)',
array(
ArcanistDifferentialRevisionStatus::NEEDS_REVISION,
));
break;
case self::STATUS_ACCEPTED: case self::STATUS_ACCEPTED:
$where[] = qsprintf( $where[] = qsprintf(
$conn_r, $conn_r,