From 8b5192ed713ea78ad0f71b6359b203b732d28eef Mon Sep 17 00:00:00 2001 From: James Rhodes Date: Fri, 1 Aug 2014 08:10:09 +1000 Subject: [PATCH] Move build status to the bottom of the property list Summary: This moves the status property of the build to the bottom of the property list so that it matches the build targets. Test Plan: Viewed a build, saw the status in the right position. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D10096 --- .../controller/HarbormasterBuildViewController.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/applications/harbormaster/controller/HarbormasterBuildViewController.php b/src/applications/harbormaster/controller/HarbormasterBuildViewController.php index 6b41e14b86..685c45d8d1 100644 --- a/src/applications/harbormaster/controller/HarbormasterBuildViewController.php +++ b/src/applications/harbormaster/controller/HarbormasterBuildViewController.php @@ -331,10 +331,6 @@ final class HarbormasterBuildViewController ->setActionList($actions); $box->addPropertyList($properties); - $properties->addProperty( - pht('Status'), - $this->getStatus($build)); - $handles = id(new PhabricatorHandleQuery()) ->setViewer($viewer) ->withPHIDs(array( @@ -350,6 +346,10 @@ final class HarbormasterBuildViewController pht('Build Plan'), $handles[$build->getBuildPlanPHID()]->renderLink()); + $properties->addProperty( + pht('Status'), + $this->getStatus($build)); + } private function getStatus(HarbormasterBuild $build) {