revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 08:52:39 +01:00
Code Issues Releases Wiki Activity

Fix an issue where PhabricatorHandleList could fail to completely iterate

Browse source 
Fixes T8140. If a HandleList contained a null (because some caller sloppily added `null` as a handle), iteration (e.g., via `iterator_to_array()`) would abort prematurely.

In T8140, some of the project transactions add a `null` for an old file PHID when there's no old profile image.

Auditors: btrahan
This commit is contained in:
epriestley 2015-05-09 13:23:37 -07:00
parent 7668d47e6d
commit 8b7a4670f8
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/applications/phid/handle/pool/PhabricatorHandleList.php
View file

@ -24,6 +24,7 @@ final class PhabricatorHandleList
private $handlePool; private $handlePool;
private $phids; private $phids;
private $count;
private $handles; private $handles;
private $cursor; private $cursor;
private $map; private $map;
@ -35,6 +36,7 @@ final class PhabricatorHandleList
public function setPHIDs(array $phids) { public function setPHIDs(array $phids) {
$this->phids = $phids; $this->phids = $phids;
$this->count = count($phids);
return $this; return $this;
} }
@ -119,7 +121,7 @@ final class PhabricatorHandleList
} }
public function valid() { public function valid() {
return isset($this->phids[$this->cursor]); return ($this->cursor < $this->count);
} }
@ -165,7 +167,7 @@ final class PhabricatorHandleList
public function count() { public function count() {
return count($this->phids); return $this->count;
} }
} }