Fix warning panel on large commits

Summary: The warning panel on large commits in diffusion was being overrun with other styles. Fixes T3952

Test Plan: test on a large commit

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Maniphest Tasks: T3952

Differential Revision: https://secure.phabricator.com/D7456

src/__celerity_resource_map__.php

@@ -859,7 +859,7 @@ celerity_register_resource_map(array(
   ),
   'aphront-error-view-css' =>
   array(
-    'uri' => '/res/07a74e07/rsrc/css/aphront/error-view.css',
+    'uri' => '/res/cb571901/rsrc/css/aphront/error-view.css',
     'type' => 'css',
     'requires' =>
     array(
@@ -4318,7 +4318,7 @@ celerity_register_resource_map(array(
 ), array(
   'packages' =>
   array(
-    'e3e5a752' =>
+    'b05e33c6' =>
     array(
       'name' => 'core.pkg.css',
       'symbols' =>
@@ -4367,7 +4367,7 @@ celerity_register_resource_map(array(
         41 => 'phabricator-tag-view-css',
         42 => 'phui-list-view-css',
       ),
-      'uri' => '/res/pkg/e3e5a752/core.pkg.css',
+      'uri' => '/res/pkg/b05e33c6/core.pkg.css',
       'type' => 'css',
     ),
     '2c1dba03' =>
@@ -4559,15 +4559,15 @@ celerity_register_resource_map(array(
   ),
   'reverse' =>
   array(
-    'aphront-dialog-view-css' => 'e3e5a752',
-    'aphront-error-view-css' => 'e3e5a752',
-    'aphront-list-filter-view-css' => 'e3e5a752',
-    'aphront-pager-view-css' => 'e3e5a752',
-    'aphront-panel-view-css' => 'e3e5a752',
-    'aphront-table-view-css' => 'e3e5a752',
-    'aphront-tokenizer-control-css' => 'e3e5a752',
-    'aphront-tooltip-css' => 'e3e5a752',
-    'aphront-typeahead-control-css' => 'e3e5a752',
+    'aphront-dialog-view-css' => 'b05e33c6',
+    'aphront-error-view-css' => 'b05e33c6',
+    'aphront-list-filter-view-css' => 'b05e33c6',
+    'aphront-pager-view-css' => 'b05e33c6',
+    'aphront-panel-view-css' => 'b05e33c6',
+    'aphront-table-view-css' => 'b05e33c6',
+    'aphront-tokenizer-control-css' => 'b05e33c6',
+    'aphront-tooltip-css' => 'b05e33c6',
+    'aphront-typeahead-control-css' => 'b05e33c6',
     'differential-changeset-view-css' => '1084b12b',
     'differential-core-view-css' => '1084b12b',
     'differential-inline-comment-editor' => '5e9e5c4e',
@@ -4581,7 +4581,7 @@ celerity_register_resource_map(array(
     'differential-table-of-contents-css' => '1084b12b',
     'diffusion-commit-view-css' => '270f4eb4',
     'diffusion-icons-css' => '270f4eb4',
-    'global-drag-and-drop-css' => 'e3e5a752',
+    'global-drag-and-drop-css' => 'b05e33c6',
     'inline-comment-summary-css' => '1084b12b',
     'javelin-aphlict' => '2c1dba03',
     'javelin-behavior' => '3e3be199',
@@ -4656,56 +4656,56 @@ celerity_register_resource_map(array(
     'javelin-util' => '3e3be199',
     'javelin-vector' => '3e3be199',
     'javelin-workflow' => '3e3be199',
-    'lightbox-attachment-css' => 'e3e5a752',
+    'lightbox-attachment-css' => 'b05e33c6',
     'maniphest-task-summary-css' => '49898640',
-    'phabricator-action-list-view-css' => 'e3e5a752',
-    'phabricator-application-launch-view-css' => 'e3e5a752',
+    'phabricator-action-list-view-css' => 'b05e33c6',
+    'phabricator-application-launch-view-css' => 'b05e33c6',
     'phabricator-busy' => '2c1dba03',
     'phabricator-content-source-view-css' => '1084b12b',
-    'phabricator-core-css' => 'e3e5a752',
-    'phabricator-crumbs-view-css' => 'e3e5a752',
+    'phabricator-core-css' => 'b05e33c6',
+    'phabricator-crumbs-view-css' => 'b05e33c6',
     'phabricator-drag-and-drop-file-upload' => '5e9e5c4e',
     'phabricator-dropdown-menu' => '2c1dba03',
     'phabricator-file-upload' => '2c1dba03',
-    'phabricator-filetree-view-css' => 'e3e5a752',
-    'phabricator-flag-css' => 'e3e5a752',
+    'phabricator-filetree-view-css' => 'b05e33c6',
+    'phabricator-flag-css' => 'b05e33c6',
     'phabricator-hovercard' => '2c1dba03',
-    'phabricator-jump-nav' => 'e3e5a752',
+    'phabricator-jump-nav' => 'b05e33c6',
     'phabricator-keyboard-shortcut' => '2c1dba03',
     'phabricator-keyboard-shortcut-manager' => '2c1dba03',
-    'phabricator-main-menu-view' => 'e3e5a752',
+    'phabricator-main-menu-view' => 'b05e33c6',
     'phabricator-menu-item' => '2c1dba03',
-    'phabricator-nav-view-css' => 'e3e5a752',
+    'phabricator-nav-view-css' => 'b05e33c6',
     'phabricator-notification' => '2c1dba03',
-    'phabricator-notification-css' => 'e3e5a752',
-    'phabricator-notification-menu-css' => 'e3e5a752',
+    'phabricator-notification-css' => 'b05e33c6',
+    'phabricator-notification-menu-css' => 'b05e33c6',
     'phabricator-object-selector-css' => '1084b12b',
     'phabricator-phtize' => '2c1dba03',
     'phabricator-prefab' => '2c1dba03',
     'phabricator-project-tag-css' => '49898640',
-    'phabricator-remarkup-css' => 'e3e5a752',
+    'phabricator-remarkup-css' => 'b05e33c6',
     'phabricator-shaped-request' => '5e9e5c4e',
-    'phabricator-side-menu-view-css' => 'e3e5a752',
-    'phabricator-standard-page-view' => 'e3e5a752',
-    'phabricator-tag-view-css' => 'e3e5a752',
+    'phabricator-side-menu-view-css' => 'b05e33c6',
+    'phabricator-standard-page-view' => 'b05e33c6',
+    'phabricator-tag-view-css' => 'b05e33c6',
     'phabricator-textareautils' => '2c1dba03',
     'phabricator-tooltip' => '2c1dba03',
-    'phabricator-transaction-view-css' => 'e3e5a752',
-    'phabricator-zindex-css' => 'e3e5a752',
-    'phui-button-css' => 'e3e5a752',
-    'phui-form-css' => 'e3e5a752',
-    'phui-form-view-css' => 'e3e5a752',
-    'phui-header-view-css' => 'e3e5a752',
-    'phui-icon-view-css' => 'e3e5a752',
-    'phui-list-view-css' => 'e3e5a752',
-    'phui-object-item-list-view-css' => 'e3e5a752',
-    'phui-property-list-view-css' => 'e3e5a752',
-    'phui-spacing-css' => 'e3e5a752',
-    'sprite-apps-large-css' => 'e3e5a752',
-    'sprite-gradient-css' => 'e3e5a752',
-    'sprite-icons-css' => 'e3e5a752',
-    'sprite-menu-css' => 'e3e5a752',
-    'sprite-status-css' => 'e3e5a752',
-    'syntax-highlighting-css' => 'e3e5a752',
+    'phabricator-transaction-view-css' => 'b05e33c6',
+    'phabricator-zindex-css' => 'b05e33c6',
+    'phui-button-css' => 'b05e33c6',
+    'phui-form-css' => 'b05e33c6',
+    'phui-form-view-css' => 'b05e33c6',
+    'phui-header-view-css' => 'b05e33c6',
+    'phui-icon-view-css' => 'b05e33c6',
+    'phui-list-view-css' => 'b05e33c6',
+    'phui-object-item-list-view-css' => 'b05e33c6',
+    'phui-property-list-view-css' => 'b05e33c6',
+    'phui-spacing-css' => 'b05e33c6',
+    'sprite-apps-large-css' => 'b05e33c6',
+    'sprite-gradient-css' => 'b05e33c6',
+    'sprite-icons-css' => 'b05e33c6',
+    'sprite-menu-css' => 'b05e33c6',
+    'sprite-status-css' => 'b05e33c6',
+    'syntax-highlighting-css' => 'b05e33c6',
   ),
 ));

src/applications/diffusion/controller/DiffusionCommitController.php

@@ -252,10 +252,8 @@ final class DiffusionCommitController extends DiffusionController {
         $warning_view = id(new AphrontErrorView())
           ->setSeverity(AphrontErrorView::SEVERITY_WARNING)
           ->setTitle('Very Large Commit')
-          ->appendChild(phutil_tag(
-            'p',
-            array(),
-            pht("This commit is very large. Load each file individually.")));
+          ->appendChild(
+            pht("This commit is very large. Load each file individually."));
 
         $change_panel->appendChild($warning_view);
         $change_panel->addButton($show_all_button);

webroot/rsrc/css/aphront/error-view.css

@@ -27,7 +27,12 @@ form.aphront-dialog-view .aphront-error-view {
   padding: 12px;
 }
 
-.aphront-error-view-head {
+.aphront-panel-plain .aphront-error-view {
+  margin-left: 0;
+  margin-right: 0;
+}
+
+h1.aphront-error-view-head {
   padding: 10px 10px 0 10px;
   font-weight: bold;
   color: {$darkgreytext};