mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-22 14:52:41 +01:00
Destroy surplus columns
Summary: Ref T1191. This destroys surplus columns: - Pholio's transaction comments have a `mockID` column, but this is not used. The `imageID` column is used instead. - Phragment has an unused `description` column. - Releeph has an unused `summary` column. Test Plan: - Grepped for usage of these columns. - Checked that these exist in production, too. - Ran upgrades. - Added Pholio inline comments. - Saw fewer warnings. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley, hach-que Maniphest Tasks: T1191 Differential Revision: https://secure.phabricator.com/D10591
This commit is contained in:
parent
943c62d1e9
commit
8bf24f53b3
6 changed files with 11 additions and 2 deletions
2
resources/sql/autopatches/20140927.schema.02.pholio1.sql
Normal file
2
resources/sql/autopatches/20140927.schema.02.pholio1.sql
Normal file
|
@ -0,0 +1,2 @@
|
|||
ALTER TABLE {$NAMESPACE}_pholio.pholio_transaction_comment
|
||||
DROP KEY `key_draft`;
|
2
resources/sql/autopatches/20140927.schema.03.pholio2.sql
Normal file
2
resources/sql/autopatches/20140927.schema.03.pholio2.sql
Normal file
|
@ -0,0 +1,2 @@
|
|||
ALTER TABLE {$NAMESPACE}_pholio.pholio_transaction_comment
|
||||
ADD UNIQUE KEY `key_draft` (authorPHID, imageID, transactionPHID);
|
2
resources/sql/autopatches/20140927.schema.04.pholio3.sql
Normal file
2
resources/sql/autopatches/20140927.schema.04.pholio3.sql
Normal file
|
@ -0,0 +1,2 @@
|
|||
ALTER TABLE {$NAMESPACE}_pholio.pholio_transaction_comment
|
||||
DROP COLUMN mockID;
|
|
@ -0,0 +1,2 @@
|
|||
ALTER TABLE {$NAMESPACE}_phragment.phragment_snapshot
|
||||
DROP COLUMN description;
|
|
@ -0,0 +1,2 @@
|
|||
ALTER TABLE {$NAMESPACE}_releeph.releeph_request
|
||||
DROP COLUMN summary;
|
|
@ -154,8 +154,7 @@ final class ReleephRequest extends ReleephDAO
|
|||
'userIntents' => self::SERIALIZATION_JSON,
|
||||
),
|
||||
self::CONFIG_COLUMN_SCHEMA => array(
|
||||
'summary' => 'text',
|
||||
'requstCommitPHID' => 'phid?',
|
||||
'requestCommitPHID' => 'phid?',
|
||||
'commitIdentifier' => 'text40',
|
||||
'pickStatus' => 'uint32',
|
||||
'inBranch' => 'bool',
|
||||
|
|
Loading…
Reference in a new issue