1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 14:52:41 +01:00

Destroy surplus columns

Summary:
Ref T1191. This destroys surplus columns:

  - Pholio's transaction comments have a `mockID` column, but this is not used. The `imageID` column is used instead.
  - Phragment has an unused `description` column.
  - Releeph has an unused `summary` column.

Test Plan:
  - Grepped for usage of these columns.
  - Checked that these exist in production, too.
  - Ran upgrades.
  - Added Pholio inline comments.
  - Saw fewer warnings.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley, hach-que

Maniphest Tasks: T1191

Differential Revision: https://secure.phabricator.com/D10591
This commit is contained in:
epriestley 2014-10-01 07:54:33 -07:00
parent 943c62d1e9
commit 8bf24f53b3
6 changed files with 11 additions and 2 deletions

View file

@ -0,0 +1,2 @@
ALTER TABLE {$NAMESPACE}_pholio.pholio_transaction_comment
DROP KEY `key_draft`;

View file

@ -0,0 +1,2 @@
ALTER TABLE {$NAMESPACE}_pholio.pholio_transaction_comment
ADD UNIQUE KEY `key_draft` (authorPHID, imageID, transactionPHID);

View file

@ -0,0 +1,2 @@
ALTER TABLE {$NAMESPACE}_pholio.pholio_transaction_comment
DROP COLUMN mockID;

View file

@ -0,0 +1,2 @@
ALTER TABLE {$NAMESPACE}_phragment.phragment_snapshot
DROP COLUMN description;

View file

@ -0,0 +1,2 @@
ALTER TABLE {$NAMESPACE}_releeph.releeph_request
DROP COLUMN summary;

View file

@ -154,8 +154,7 @@ final class ReleephRequest extends ReleephDAO
'userIntents' => self::SERIALIZATION_JSON,
),
self::CONFIG_COLUMN_SCHEMA => array(
'summary' => 'text',
'requstCommitPHID' => 'phid?',
'requestCommitPHID' => 'phid?',
'commitIdentifier' => 'text40',
'pickStatus' => 'uint32',
'inBranch' => 'bool',