From 8c8211787894a9d6ab48adadb3457fed093cecb8 Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Fri, 17 May 2024 11:20:07 +0200 Subject: [PATCH] Fix PonderQuestionCreateMailReceiver accessing non-existing PonderQuestionTransaction constants Summary: The transaction types `TYPE_TITLE` and `TYPE_CONTENT` were removed from `PonderQuestionTransaction` in rPdff028c4907dd1959859733ea0d947f244559e7f. Thus update `PonderQuestionCreateMailReceiver` to use the corresponding modular transactions `PonderQuestionTitleTransaction` and `PonderQuestionContentTransaction` instead. Test Plan: Carefully read the code, grep the code base, use the test case in D25656#18162. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D25656 --- .../ponder/mail/PonderQuestionCreateMailReceiver.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/applications/ponder/mail/PonderQuestionCreateMailReceiver.php b/src/applications/ponder/mail/PonderQuestionCreateMailReceiver.php index 32669855ea..496cedb8a1 100644 --- a/src/applications/ponder/mail/PonderQuestionCreateMailReceiver.php +++ b/src/applications/ponder/mail/PonderQuestionCreateMailReceiver.php @@ -20,11 +20,11 @@ final class PonderQuestionCreateMailReceiver $xactions = array(); $xactions[] = id(new PonderQuestionTransaction()) - ->setTransactionType(PonderQuestionTransaction::TYPE_TITLE) + ->setTransactionType(PonderQuestionTitleTransaction::TRANSACTIONTYPE) ->setNewValue($title); $xactions[] = id(new PonderQuestionTransaction()) - ->setTransactionType(PonderQuestionTransaction::TYPE_CONTENT) + ->setTransactionType(PonderQuestionContentTransaction::TRANSACTIONTYPE) ->setNewValue($mail->getCleanTextBody()); $question = PonderQuestion::initializeNewQuestion($author);